)]}'
{"id":"openocd~master~I857e87bf30558974a1c1058345aa6a3baefac031","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-10-21 21:26:14.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-10-09 09:55:47.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I857e87bf30558974a1c1058345aa6a3baefac031","subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","status":"MERGED","created":"2026-09-15 15:35:31.000000000","updated":"2026-10-21 21:26:14.000000000","submitted":"2026-10-21 21:26:14.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":21,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"10002","meta_rev_id":"8d64e1953699b4f6d0e01a18a67de42c3fbe2ea0","_number":10002,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-21 21:26:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-21 21:26:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-15 15:35:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-15 15:56:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-15 17:02:22.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"f4202231a5d0a19998cf7315f920fadb6ab24acf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-15 15:35:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"50bcc8d47f6d63158596d981b72673bdc581b9bc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-15 15:56:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24220/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23289/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a93f73a22e593a3f4b7ae840db93f62786cded49","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-15 17:02:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7b9fec37b02b404b321b13c1bb74c330a9da6cd5","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-15 18:47:07.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a975875ec9445c192fbc025df37120cf72076450","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-15 20:30:05.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2ffc8f9772d012abdd9e3a44530c810d4352fbcc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-16 07:09:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d3d35095b042d21c03bf57deda5874edf7c80ad7","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-16 07:12:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"762b2c14437e382ff1072a21c443ee8df47958d5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-16 07:28:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24222/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23291/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ff5dc47c73d7d6686f751388faec9e13ac16f791","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-16 08:22:03.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cf50af873dc57f8140fe8686478e357797f9a943","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-16 19:15:16.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"badd13050daeb57b7b03c2ab50067f190637245c","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-16 19:15:47.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4675271a30e38524e28271fb5c631d572be5f0af","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-16 19:35:06.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24237/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23306/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"88a27370aaf181a041c3ea18af5e7f5d009d5cc7","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-20 13:36:10.000000000","message":"Patch Set 3: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"9ed24d3b36bd656ada85feb22fd48ec05f4a46e8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-21 05:55:24.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3937da3f5d7c20785aeea71dc6557c0f6eeef94f","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-21 07:47:45.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"60c722b38eb2f545861a52f839214f1a5a8fa9e2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-09 09:55:47.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e8be9e191bf323557fe180778fec6cf3d498ab1a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-16 07:47:24.000000000","message":"Patch Set 3: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1af94308ef32cc088162fb4501167cba751f31a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-10-19 09:44:17.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"00975ff7517b9bf4960ed0afe20c367acde1a1f6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-19 10:21:09.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24590/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23653/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"9a3c065094a82bc4e9e2fb3ddbf78430961aa810","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-19 10:53:15.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"8d64e1953699b4f6d0e01a18a67de42c3fbe2ea0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-21 21:26:14.000000000","message":"Change has been successfully cherry-picked as 5088db4c9154ca833c6d558381074b33672e127a","accounts_in_message":[],"_revision_number":5}],"current_revision":"5088db4c9154ca833c6d558381074b33672e127a","revisions":{"9c41bf7af3da448feb799df61cac51f788efa2fa":{"kind":"REWORK","_number":4,"created":"2026-10-19 09:44:17.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/02/10002/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/10002/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/4 \u0026\u0026 git checkout -b change-10002 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/10002/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2893f940012e19cda8ccb6038766b0d77f26bd0e","subject":"tcl: fix broken datasheet link in hpm6360 config"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-10-19 09:42:34.000000000","tz":120},"subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","message":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027\n\nCurrently, \u0027flash erase_check\u0027 continues after an error occurs, such as\nwhen the target is not halted:\n\n\u003e flash erase_check 0\nTarget not halted\nError: checking erase state of flash bank #0 at 0x00000000\n        #  0: 0x00000000 (0x400 1kB) not erased\n        #  1: 0x00000400 (0x400 1kB) not erased\n        #  2: 0x00000800 (0x400 1kB) not erased\n        #  3: 0x00000c00 (0x400 1kB) not erased\n...\n\nReturn an error immediately when checking the erase state fails. While\nat it, remove the success message for the underlying flash driver\noperation to reduce verbosity.\n\nBecause sectors may not be readable, for example, due to read\nprotection settings, adapt default_flash_mem_blank_check() so that\nwhen a read fails, the sector is marked as \"unknown\" rather than\ntriggering a fatal error.\n\nChange-Id: I857e87bf30558974a1c1058345aa6a3baefac031\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"5088db4c9154ca833c6d558381074b33672e127a":{"kind":"REWORK","_number":5,"created":"2026-10-21 21:26:14.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/02/10002/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/10002/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/5 \u0026\u0026 git checkout -b change-10002 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/10002/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d2f72d49efed744eaa489ce931393b6e69122e66","subject":"jtag/drivers/ch347: show chip variant in initial info"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-21 21:26:14.000000000","tz":0},"subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","message":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027\n\nCurrently, \u0027flash erase_check\u0027 continues after an error occurs, such as\nwhen the target is not halted:\n\n\u003e flash erase_check 0\nTarget not halted\nError: checking erase state of flash bank #0 at 0x00000000\n        #  0: 0x00000000 (0x400 1kB) not erased\n        #  1: 0x00000400 (0x400 1kB) not erased\n        #  2: 0x00000800 (0x400 1kB) not erased\n        #  3: 0x00000c00 (0x400 1kB) not erased\n...\n\nReturn an error immediately when checking the erase state fails. While\nat it, remove the success message for the underlying flash driver\noperation to reduce verbosity.\n\nBecause sectors may not be readable, for example, due to read\nprotection settings, adapt default_flash_mem_blank_check() so that\nwhen a read fails, the sector is marked as \"unknown\" rather than\ntriggering a fatal error.\n\nChange-Id: I857e87bf30558974a1c1058345aa6a3baefac031\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/10002\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}},"847e3d3531024db3a2d7d5034a76510132588230":{"kind":"REWORK","_number":1,"created":"2026-09-15 15:35:31.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/02/10002/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/10002/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/1 \u0026\u0026 git checkout -b change-10002 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/10002/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f717c229fceff164b2961b4698d732f69800b22b","subject":"flash/nor: Support erase check on banks without sectors"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","message":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027\n\nCurrently, \u0027flash erase_check\u0027 continues after an error occurs, such as\nwhen the target is not halted:\n\n\u003e flash erase_check 0\nTarget not halted\nError: checking erase state of flash bank #0 at 0x00000000\n        #  0: 0x00000000 (0x400 1kB) not erased\n        #  1: 0x00000400 (0x400 1kB) not erased\n        #  2: 0x00000800 (0x400 1kB) not erased\n        #  3: 0x00000c00 (0x400 1kB) not erased\n...\n\nReturn an error immediately when checking the erase state fails. While\nat it, remove the success message for the underlying flash driver\noperation to reduce verbosity.\n\nChange-Id: I857e87bf30558974a1c1058345aa6a3baefac031\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"07d6ec6ca3b8778016ab182b31dd9b52683df443":{"kind":"REWORK","_number":2,"created":"2026-09-16 07:09:15.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/02/10002/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/10002/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/2 \u0026\u0026 git checkout -b change-10002 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/10002/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f717c229fceff164b2961b4698d732f69800b22b","subject":"flash/nor: Support erase check on banks without sectors"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-16 06:56:09.000000000","tz":0},"subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","message":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027\n\nCurrently, \u0027flash erase_check\u0027 continues after an error occurs, such as\nwhen the target is not halted:\n\n\u003e flash erase_check 0\nTarget not halted\nError: checking erase state of flash bank #0 at 0x00000000\n        #  0: 0x00000000 (0x400 1kB) not erased\n        #  1: 0x00000400 (0x400 1kB) not erased\n        #  2: 0x00000800 (0x400 1kB) not erased\n        #  3: 0x00000c00 (0x400 1kB) not erased\n...\n\nReturn an error immediately when checking the erase state fails. While\nat it, remove the success message for the underlying flash driver\noperation to reduce verbosity.\n\nBecause sectors may not be readable, for example, due to read\nprotection settings, adapt default_flash_mem_blank_check() such that\nnon-readable sectors are marked \u0027unknown\u0027 rather than treated as fatal\nerrors.\n\nChange-Id: I857e87bf30558974a1c1058345aa6a3baefac031\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"e04b5d5590992e433192f8e89c464d12a627ece9":{"kind":"REWORK","_number":3,"created":"2026-09-16 19:15:16.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/02/10002/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/10002/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/3 \u0026\u0026 git checkout -b change-10002 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/10002/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/10002/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f717c229fceff164b2961b4698d732f69800b22b","subject":"flash/nor: Support erase check on banks without sectors"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-15 15:34:51.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-09-16 18:57:46.000000000","tz":0},"subject":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027","message":"flash/nor/tcl: Do not continue on error in \u0027erase_check\u0027\n\nCurrently, \u0027flash erase_check\u0027 continues after an error occurs, such as\nwhen the target is not halted:\n\n\u003e flash erase_check 0\nTarget not halted\nError: checking erase state of flash bank #0 at 0x00000000\n        #  0: 0x00000000 (0x400 1kB) not erased\n        #  1: 0x00000400 (0x400 1kB) not erased\n        #  2: 0x00000800 (0x400 1kB) not erased\n        #  3: 0x00000c00 (0x400 1kB) not erased\n...\n\nReturn an error immediately when checking the erase state fails. While\nat it, remove the success message for the underlying flash driver\noperation to reduce verbosity.\n\nBecause sectors may not be readable, for example, due to read\nprotection settings, adapt default_flash_mem_blank_check() so that\nwhen a read fails, the sector is marked as \"unknown\" rather than\ntriggering a fatal error.\n\nChange-Id: I857e87bf30558974a1c1058345aa6a3baefac031\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}