)]}'
{"src/flash/nor/sh_qspi.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b2f4d87253f5ee943bea33b39d16fac459e46e84","unresolved":true,"context_lines":[{"line_number":845,"context_line":""},{"line_number":846,"context_line":"static int sh_qspi_flash_blank_check(struct flash_bank *bank)"},{"line_number":847,"context_line":"{"},{"line_number":848,"context_line":"\tLOG_ERROR(\"erase check is not implemented\");"},{"line_number":849,"context_line":"\treturn ERROR_NOT_IMPLEMENTED;"},{"line_number":850,"context_line":"}"},{"line_number":851,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"77c453cb_58127582","line":848,"updated":"2026-09-22 09:19:36.000000000","message":"Wouldn\u0027t this message be more suitable in an upper layer?","commit_id":"6c9e7bc8ac306f19fc8c5dc87cc907d691ff0fc9"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b85a353821f562365377da88fd50e1aab26491f0","unresolved":false,"context_lines":[{"line_number":845,"context_line":""},{"line_number":846,"context_line":"static int sh_qspi_flash_blank_check(struct flash_bank *bank)"},{"line_number":847,"context_line":"{"},{"line_number":848,"context_line":"\tLOG_ERROR(\"erase check is not implemented\");"},{"line_number":849,"context_line":"\treturn ERROR_NOT_IMPLEMENTED;"},{"line_number":850,"context_line":"}"},{"line_number":851,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0b812cf5_1daec3a2","line":848,"in_reply_to":"0adb3c5a_04a43c3f","updated":"2026-09-23 09:31:02.000000000","message":"Yes, let\u0027s keep this simple for now.","commit_id":"6c9e7bc8ac306f19fc8c5dc87cc907d691ff0fc9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"904c46cc31d5e6ca8a74ef6317bf2851a62585d8","unresolved":true,"context_lines":[{"line_number":845,"context_line":""},{"line_number":846,"context_line":"static int sh_qspi_flash_blank_check(struct flash_bank *bank)"},{"line_number":847,"context_line":"{"},{"line_number":848,"context_line":"\tLOG_ERROR(\"erase check is not implemented\");"},{"line_number":849,"context_line":"\treturn ERROR_NOT_IMPLEMENTED;"},{"line_number":850,"context_line":"}"},{"line_number":851,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0adb3c5a_04a43c3f","line":848,"in_reply_to":"77c453cb_58127582","updated":"2026-09-22 16:48:58.000000000","message":"Do you mean to return ERROR_NOT_IMPLEMENTED without logging error here, detect this error in `handle_flash_erase_check_command` in tcl.c and `command_print()` `not implemented` text instead of `Error: checking erase state of flash bank`?\nSounds like a good idea, however probably more functions than erase check should be treated this way. Little bit out of this topic.","commit_id":"6c9e7bc8ac306f19fc8c5dc87cc907d691ff0fc9"}]}