)]}'
{"id":"openocd~master~I81c490770b615b496b7046d4e895eeccf7e92a0d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-09-23 09:31:02.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-10-01 20:12:55.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I81c490770b615b496b7046d4e895eeccf7e92a0d","subject":"flash/nor: fix some stubs","status":"MERGED","created":"2026-09-16 13:36:17.000000000","updated":"2026-10-10 09:08:06.000000000","submitted":"2026-10-10 09:08:06.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10003","meta_rev_id":"906215c166fa61d6e922ba261407938e0ecb7693","_number":10003,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-10 09:08:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-10 09:08:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-10 09:08:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-16 13:36:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-16 13:59:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-20 13:43:28.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"77c1840dea2efe6d66751a6b0e3d7d94fc393a91","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-16 13:36:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81e3621f8bc5b23392ee1330609ba49a09e83dd2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-16 13:59:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24231/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23300/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b2f4d87253f5ee943bea33b39d16fac459e46e84","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-22 09:19:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"904c46cc31d5e6ca8a74ef6317bf2851a62585d8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-22 16:48:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b85a353821f562365377da88fd50e1aab26491f0","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-23 09:31:02.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82bf1a9645ca8d50d600e6bbed884d403c060d43","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 20:12:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"906215c166fa61d6e922ba261407938e0ecb7693","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-10 09:08:06.000000000","message":"Change has been successfully cherry-picked as 1232e7e1f0afee3f0f243cfe7af9c1b8f9fbf6f1","accounts_in_message":[],"_revision_number":2}],"current_revision":"1232e7e1f0afee3f0f243cfe7af9c1b8f9fbf6f1","revisions":{"1232e7e1f0afee3f0f243cfe7af9c1b8f9fbf6f1":{"kind":"REWORK","_number":2,"created":"2026-10-10 09:08:06.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/03/10003/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/10003/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/2 \u0026\u0026 git checkout -b change-10003 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/10003/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8da0578d7bce3e134821ccf10911182788debc32","subject":"tcl/fpga/altera/cyclone-iv: Fix typo in variable name"}],"author":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-09-16 13:29:44.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-10 09:08:06.000000000","tz":0},"subject":"flash/nor: fix some stubs","message":"flash/nor: fix some stubs\n\nDo not return ERROR_OK if erase_check of not memory mapped SPI\nflash is not implemented. Log error and return ERROR_NOT_IMPLEMENTED.\n\nmsp432: do not pretend that protect check is implemented.\nDrop the stub.\n\nChange-Id: I81c490770b615b496b7046d4e895eeccf7e92a0d\nSigned-off-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/10003\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}},"6c9e7bc8ac306f19fc8c5dc87cc907d691ff0fc9":{"kind":"REWORK","_number":1,"created":"2026-09-16 13:36:17.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/03/10003/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/10003/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/1 \u0026\u0026 git checkout -b change-10003 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/10003/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/10003/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f5831d25f58dbeed8de4ad6627c75e774bd2c","subject":"jtag/drivers/cmsis_dap: fix possible buffer overflow"}],"author":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-09-16 13:29:44.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-09-16 13:29:44.000000000","tz":120},"subject":"flash/nor: fix some stubs","message":"flash/nor: fix some stubs\n\nDo not return ERROR_OK if erase_check of not memory mapped SPI\nflash is not implemented. Log error and return ERROR_NOT_IMPLEMENTED.\n\nmsp432: do not pretend that protect check is implemented.\nDrop the stub.\n\nChange-Id: I81c490770b615b496b7046d4e895eeccf7e92a0d\nSigned-off-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}