)]}'
{"id":"openocd~master~Idf108f6ee4a6ab42412fcb756cbdb1700bbc6d4f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001991":{"account":{"_account_id":1001991,"name":"Ryan QIAN","email":"jianghao.qian@outlook.com","username":"jhqian"},"last_update":"2026-10-10 09:08:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idf108f6ee4a6ab42412fcb756cbdb1700bbc6d4f","subject":"contrib/loaders/flash/hpmicro: enable fpu before calling rom apis","status":"MERGED","created":"2026-09-30 11:34:05.000000000","updated":"2026-10-10 09:08:56.000000000","submitted":"2026-10-10 09:08:56.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10072","meta_rev_id":"8f14c2c9a18b278e67886f5ab567187d8a19c966","_number":10072,"owner":{"_account_id":1001991,"name":"Ryan QIAN","email":"jianghao.qian@outlook.com","username":"jhqian"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-10 09:08:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-10 09:08:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-30 11:40:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-30 12:23:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-10-01 21:38:39.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"80ea2e8eefaf82a51f8d84e8ffb609f66abb57b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001991,"name":"Ryan QIAN","email":"jianghao.qian@outlook.com","username":"jhqian"},"real_author":{"_account_id":1001991,"name":"Ryan QIAN","email":"jianghao.qian@outlook.com","username":"jhqian"},"date":"2026-09-30 11:34:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a707ab8f5e16bb6c9c73410abfdecf2ad85cf61","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-30 12:23:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24386/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23454/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"789d2ac9387d91afdd1a9fb0aff947cea13c5683","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 21:38:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8f14c2c9a18b278e67886f5ab567187d8a19c966","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-10 09:08:56.000000000","message":"Change has been successfully cherry-picked as ca0f021e78e08661a8d2425e9f9cf6eaf5d524a6","accounts_in_message":[],"_revision_number":2}],"current_revision":"ca0f021e78e08661a8d2425e9f9cf6eaf5d524a6","revisions":{"ca0f021e78e08661a8d2425e9f9cf6eaf5d524a6":{"kind":"REWORK","_number":2,"created":"2026-10-10 09:08:56.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/72/10072/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/10072/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/2 \u0026\u0026 git checkout -b change-10072 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/10072/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77a277fd64265d921c0e9900dec22dd3c0088a85","subject":"contrib/loaders/flash/hpmicro: fix hybrid xpi support check"}],"author":{"name":"Ryan QIAN","email":"jianghao.qian@hpmicro.com","date":"2026-09-30 05:43:28.000000000","tz":480},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-10 09:08:56.000000000","tz":0},"subject":"contrib/loaders/flash/hpmicro: enable fpu before calling rom apis","message":"contrib/loaders/flash/hpmicro: enable fpu before calling rom apis\n\n- rom routines on some devices, early hpm6200 for example, use floating\n  point in their calculations. the loader is entered with mstatus.FS\n  clear, so the first fp instruction in rom code traps and the flash\n  operation fails on the target.\n\nChange-Id: Idf108f6ee4a6ab42412fcb756cbdb1700bbc6d4f\nSigned-off-by: Ryan QIAN \u003cjianghao.qian@hpmicro.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/10072\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}},"3a53dec850e8474d638eb80049f84a32e6c19461":{"kind":"REWORK","_number":1,"created":"2026-09-30 11:34:05.000000000","uploader":{"_account_id":1001991,"name":"Ryan QIAN","email":"jianghao.qian@outlook.com","username":"jhqian"},"ref":"refs/changes/72/10072/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/10072/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/1 \u0026\u0026 git checkout -b change-10072 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/10072/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/10072/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d81ed55b63cfa8755a1e196d902d466330f14fae","subject":"contrib/loaders/flash/hpmicro: fix hybrid xpi support check"}],"author":{"name":"Ryan QIAN","email":"jianghao.qian@hpmicro.com","date":"2026-09-30 05:43:28.000000000","tz":480},"committer":{"name":"Ryan QIAN","email":"jianghao.qian@hpmicro.com","date":"2026-09-30 11:13:34.000000000","tz":480},"subject":"contrib/loaders/flash/hpmicro: enable fpu before calling rom apis","message":"contrib/loaders/flash/hpmicro: enable fpu before calling rom apis\n\n- rom routines on some devices, early hpm6200 for example, use floating\n  point in their calculations. the loader is entered with mstatus.FS\n  clear, so the first fp instruction in rom code traps and the flash\n  operation fails on the target.\n\nChange-Id: Idf108f6ee4a6ab42412fcb756cbdb1700bbc6d4f\nSigned-off-by: Ryan QIAN \u003cjianghao.qian@hpmicro.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}