)]}'
{"id":"openocd~master~Iaeefbd1bd16314295090a0a7b85eb40affa1f92c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-10-13 13:07:36.000000000","reason":"Change was submitted"},"1002363":{"account":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"last_update":"2026-10-13 13:07:36.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-10-05 18:55:28.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iaeefbd1bd16314295090a0a7b85eb40affa1f92c","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1","status":"MERGED","created":"2026-09-30 13:52:04.000000000","updated":"2026-10-13 13:07:36.000000000","submitted":"2026-10-13 13:07:36.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10076","meta_rev_id":"57cd1c57aed516da943fd0bb2e6914e44641f7e3","_number":10076,"owner":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-13 13:07:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-13 13:07:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-30 14:03:09.000000000","updated_by":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-09-30 14:03:09.000000000","updated_by":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2026-09-30 14:22:46.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-30 15:11:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"34c14833bbc8677ab6feb39d2c12fd3e5e6155df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-09-30 13:52:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35c2fd2868e269451d9d86d2f52835891da85e70","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-09-30 14:03:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b7cc56c15bfbf96b9f7eae79d28a2f268b4873cf","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-30 15:11:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24392/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23460/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bacbc0b7c47ccc8b293d4bc2a2d6e802a880fec1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 20:43:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"940f6236e1d3f53c882042638fbd280555e7f967","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 21:30:44.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9b31c3fab1cef9b80e6c2d3893b4bbf603d35c7d","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-01 21:52:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3c5da2a2991eeefb2bfa53ecc43369ba087e37ef","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 22:06:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f5d42a6ea40b243e915a9e40bc215192b7cab942","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 12:35:06.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e5fa73824fc51d0b678b0b1d780992f4188a8dcd","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 12:37:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fb720b1ec7e7441756712805f5c832ec1f4eaa68","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-05 13:12:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9878cba87890dfa45ba43f14d7332cb59ac006a8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 15:01:28.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b5cd7ab32889160b3b8632572460b132c4b2291e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-05 15:01:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/23492/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/24426/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ff31e04e839ba828ab2ef3f1b777400bf2e4ef72","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-05 17:19:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24433/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23497/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"977f5dd1eb7837c874d5cb1d6d20d0e4f40ce9c0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-05 18:55:28.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"57cd1c57aed516da943fd0bb2e6914e44641f7e3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-13 13:07:36.000000000","message":"Change has been successfully cherry-picked as a59bf8b7d2b5d43699ab69db97724084eb4af46a","accounts_in_message":[],"_revision_number":4}],"current_revision":"a59bf8b7d2b5d43699ab69db97724084eb4af46a","revisions":{"90c3c12c36e18174ca10fe3d249bddfce18647c1":{"kind":"REWORK","_number":1,"created":"2026-09-30 13:52:04.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/76/10076/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/10076/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/1 \u0026\u0026 git checkout -b change-10076 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/10076/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21f88d7815edfb7632548090934c51017604f450","subject":"doc: fix incorrect @xref"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 09:54:29.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 12:59:16.000000000","tz":120},"subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1","message":"flash/nor/kinetis: set sysmodectrlr_type on S32K1\n\nkinetis_probe_chip_s32k() never set sysmodectrlr_type, so it used the\ndefault KINETIS_SMC. This resulted in using 8-bit wide registers for\nSMC_PMCTRL \u0026 SMC_PMSTAT at 0x4007E001 \u0026 0x4007E003 respectively. On\nS32K1xx the SMC registers are 32 bits wide at 0x4007E00C \u0026 0x4007E014\nrespectively (see the RM sec. 40.3).\n\nTested on S32K118: with the core in VLPR, \u0027flash erase_sector\u0027 now\nswitches to RUN mode first (SMC_PMSTAT 0x04 -\u003e 0x01).\n\nChange-Id: Iaeefbd1bd16314295090a0a7b85eb40affa1f92c\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"c3d0ceb9b4dc05a1aec7be06a87e8c47daee486f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-10-05 12:35:06.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/76/10076/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/10076/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/2 \u0026\u0026 git checkout -b change-10076 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/10076/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21f88d7815edfb7632548090934c51017604f450","subject":"doc: fix incorrect @xref"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 09:54:29.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-10-05 12:33:46.000000000","tz":120},"subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1","message":"flash/nor/kinetis: set sysmodectrlr_type on S32K1\n\nkinetis_probe_chip_s32k() never set sysmodectrlr_type, so it used the\ndefault KINETIS_SMC. This resulted in using 8-bit wide registers for\nSMC_PMCTRL \u0026 SMC_PMSTAT at 0x4007E001 \u0026 0x4007E003 respectively. On\nS32K1xx the SMC registers are 32 bits wide at 0x4007E00C \u0026 0x4007E014\nrespectively (see the RM sec. 40.3).\n\nTested on S32K118: with the core in VLPR, \u0027flash erase_sector\u0027 now\nswitches to RUN mode first (SMC_PMSTAT 0x04 -\u003e 0x01).\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iaeefbd1bd16314295090a0a7b85eb40affa1f92c\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"7e64fe0b7ff745a0512c89e32378a4ba01bd9aa3":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-10-05 15:01:28.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/76/10076/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/10076/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/3 \u0026\u0026 git checkout -b change-10076 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/10076/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8da0578d7bce3e134821ccf10911182788debc32","subject":"tcl/fpga/altera/cyclone-iv: Fix typo in variable name"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 09:54:29.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-10-05 14:58:36.000000000","tz":120},"subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1","message":"flash/nor/kinetis: set sysmodectrlr_type on S32K1\n\nkinetis_probe_chip_s32k() never set sysmodectrlr_type, so it used the\ndefault KINETIS_SMC. This resulted in using 8-bit wide registers for\nSMC_PMCTRL \u0026 SMC_PMSTAT at 0x4007E001 \u0026 0x4007E003 respectively. On\nS32K1xx the SMC registers are 32 bits wide at 0x4007E00C \u0026 0x4007E014\nrespectively (see the RM sec. 40.3).\n\nTested on S32K118: with the core in VLPR, \u0027flash erase_sector\u0027 now\nswitches to RUN mode first (SMC_PMSTAT 0x04 -\u003e 0x01).\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iaeefbd1bd16314295090a0a7b85eb40affa1f92c\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"a59bf8b7d2b5d43699ab69db97724084eb4af46a":{"kind":"REWORK","_number":4,"created":"2026-10-13 13:07:36.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/76/10076/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/10076/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/4 \u0026\u0026 git checkout -b change-10076 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/10076/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/10076/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"751e5af67bf487c0f45ed2f5b53043dacfe72404","subject":"target: prevent image load to overwrite a breakpoint"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 09:54:29.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-13 13:07:36.000000000","tz":0},"subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1","message":"flash/nor/kinetis: set sysmodectrlr_type on S32K1\n\nkinetis_probe_chip_s32k() never set sysmodectrlr_type, so it used the\ndefault KINETIS_SMC. This resulted in using 8-bit wide registers for\nSMC_PMCTRL \u0026 SMC_PMSTAT at 0x4007E001 \u0026 0x4007E003 respectively. On\nS32K1xx the SMC registers are 32 bits wide at 0x4007E00C \u0026 0x4007E014\nrespectively (see the RM sec. 40.3).\n\nTested on S32K118: with the core in VLPR, \u0027flash erase_sector\u0027 now\nswitches to RUN mode first (SMC_PMSTAT 0x04 -\u003e 0x01).\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iaeefbd1bd16314295090a0a7b85eb40affa1f92c\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/10076\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}