)]}'
{"id":"openocd~master~Iee5483f0f54db038dab905b2c67aeac2d4013762","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002363":{"account":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"last_update":"2026-10-13 13:07:50.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-10-05 18:55:58.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iee5483f0f54db038dab905b2c67aeac2d4013762","subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","status":"MERGED","created":"2026-09-30 13:52:04.000000000","updated":"2026-10-13 13:07:50.000000000","submitted":"2026-10-13 13:07:50.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10077","meta_rev_id":"d590c20869e32ebd775e19455004316b3ece7b6b","_number":10077,"owner":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-13 13:07:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-13 13:07:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-30 14:00:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-30 14:53:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-10-01 20:53:28.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"9ba520af39e0af518d4e352a5bb627dce7399912","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-09-30 13:52:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"130bd3d26237e89e192e0a6e9a060e645605c5c6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-30 14:53:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24391/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23459/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2dc78f805c399fbb2f685bacbf9f6c1eb666c615","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 20:53:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1c4620b7c9109ad0e42be1819f87dc2afbe26687","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 12:35:06.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"af0b847c4168de9d8cbde96a485647dfd689a39c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 14:51:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9c708bd9dcb87d96a96f8f397ad4a9eca845d7db","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-05 14:52:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/24424/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"74b4c77cb0abafcec3cfaffc1560d049d4af4d62","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2026-10-05 15:01:28.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"a307f4cfa92305a2838b30a8ea58a77615646dab","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-05 15:01:37.000000000","message":"Patch Set 3:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":3},{"id":"f80457824d80ddcafa6ba3ef07ddc0ddd1c82122","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-10-05 17:00:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24432/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23496/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"a6473c4ffbcbce5f93a32eee9fa42833b6c83994","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-05 18:55:58.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d590c20869e32ebd775e19455004316b3ece7b6b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-13 13:07:50.000000000","message":"Change has been successfully cherry-picked as 60343e5cf960c68731353c5ad47307d3341aa313","accounts_in_message":[],"_revision_number":5}],"current_revision":"60343e5cf960c68731353c5ad47307d3341aa313","revisions":{"d68bd8a3767515bd11674417989eed3dff2de6a9":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-10-05 15:01:28.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/77/10077/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/10077/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/4 \u0026\u0026 git checkout -b change-10077 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/10077/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e64fe0b7ff745a0512c89e32378a4ba01bd9aa3","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-28 15:57:42.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-10-05 14:58:36.000000000","tz":120},"subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","message":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding\n\nTwo problems with SIM_FCFG1[DEPART] on S32K1xx:\n\nDEPART 0xf was treated like a 1xxx data flash size code. This can be\nvalid on S32K148, but not any other S32K1xx parts.\n\nAlso, kinetis_blank_check() read DEPART from bits 11:8 as on Kinetis K.\nOn S32K1xx these bits are reserved and DEPART is in bits 15:12, so the\nblock command was used even with an EEPROM backup partition and failed\nwith ACCERR (\"Flash operation failed, illegal command\") before falling\nback to sector checks.\n\nTested on S32K118, unpartitioned: probe reports 0 KiB data flash instead\nof 512 KiB. Partitioned as 8 KiB data flash / 24 KiB EEPROM backup:\n\u0027flash erase_check\u0027 on the FlexNVM bank no longer reports an error.\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iee5483f0f54db038dab905b2c67aeac2d4013762\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"60343e5cf960c68731353c5ad47307d3341aa313":{"kind":"REWORK","_number":5,"created":"2026-10-13 13:07:50.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/77/10077/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/10077/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/5 \u0026\u0026 git checkout -b change-10077 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/10077/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a59bf8b7d2b5d43699ab69db97724084eb4af46a","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-28 15:57:42.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-13 13:07:50.000000000","tz":0},"subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","message":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding\n\nTwo problems with SIM_FCFG1[DEPART] on S32K1xx:\n\nDEPART 0xf was treated like a 1xxx data flash size code. This can be\nvalid on S32K148, but not any other S32K1xx parts.\n\nAlso, kinetis_blank_check() read DEPART from bits 11:8 as on Kinetis K.\nOn S32K1xx these bits are reserved and DEPART is in bits 15:12, so the\nblock command was used even with an EEPROM backup partition and failed\nwith ACCERR (\"Flash operation failed, illegal command\") before falling\nback to sector checks.\n\nTested on S32K118, unpartitioned: probe reports 0 KiB data flash instead\nof 512 KiB. Partitioned as 8 KiB data flash / 24 KiB EEPROM backup:\n\u0027flash erase_check\u0027 on the FlexNVM bank no longer reports an error.\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iee5483f0f54db038dab905b2c67aeac2d4013762\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/10077\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\nTested-by: jenkins\n"}},"6f8e3cef39a20175b2d024c004af0b17a4e8bafc":{"kind":"REWORK","_number":1,"created":"2026-09-30 13:52:04.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/77/10077/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/10077/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/1 \u0026\u0026 git checkout -b change-10077 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/10077/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"90c3c12c36e18174ca10fe3d249bddfce18647c1","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-28 15:57:42.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-30 13:00:27.000000000","tz":120},"subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","message":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding\n\nTwo problems with SIM_FCFG1[DEPART] on S32K1xx:\n\nDEPART 0xf was treated like a 1xxx data flash size code. This can be\nvalid on S32K148, but not any other S32K1xx parts.\n\nAlso, kinetis_blank_check() read DEPART from bits 11:8 as on Kinetis K.\nOn S32K1xx these bits are reserved and DEPART is in bits 15:12, so the\nblock command was used even with an EEPROM backup partition and failed\nwith ACCERR (\"Flash operation failed, illegal command\") before falling\nback to sector checks.\n\nTested on S32K118, unpartitioned: probe reports 0 KiB data flash instead\nof 512 KiB. Partitioned as 8 KiB data flash / 24 KiB EEPROM backup:\n\u0027flash erase_check\u0027 on the FlexNVM bank no longer reports an error.\n\nChange-Id: Iee5483f0f54db038dab905b2c67aeac2d4013762\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"4c9b88f064e719ec66e495fe9b7d81f7c27798f4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-10-05 12:35:06.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/77/10077/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/10077/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/2 \u0026\u0026 git checkout -b change-10077 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/10077/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3d0ceb9b4dc05a1aec7be06a87e8c47daee486f","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-28 15:57:42.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-10-05 12:34:01.000000000","tz":120},"subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","message":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding\n\nTwo problems with SIM_FCFG1[DEPART] on S32K1xx:\n\nDEPART 0xf was treated like a 1xxx data flash size code. This can be\nvalid on S32K148, but not any other S32K1xx parts.\n\nAlso, kinetis_blank_check() read DEPART from bits 11:8 as on Kinetis K.\nOn S32K1xx these bits are reserved and DEPART is in bits 15:12, so the\nblock command was used even with an EEPROM backup partition and failed\nwith ACCERR (\"Flash operation failed, illegal command\") before falling\nback to sector checks.\n\nTested on S32K118, unpartitioned: probe reports 0 KiB data flash instead\nof 512 KiB. Partitioned as 8 KiB data flash / 24 KiB EEPROM backup:\n\u0027flash erase_check\u0027 on the FlexNVM bank no longer reports an error.\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iee5483f0f54db038dab905b2c67aeac2d4013762\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}},"e047b1d60b223f0328e4110b46596a82a99eafab":{"kind":"REWORK","_number":3,"created":"2026-10-05 14:51:58.000000000","uploader":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"ref":"refs/changes/77/10077/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/10077/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/3 \u0026\u0026 git checkout -b change-10077 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/10077/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/10077/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3d0ceb9b4dc05a1aec7be06a87e8c47daee486f","subject":"flash/nor/kinetis: set sysmodectrlr_type on S32K1"}],"author":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-09-28 15:57:42.000000000","tz":120},"committer":{"name":"Jasper v. Blanckenburg","email":"jasper@mezzo.de","date":"2026-10-05 14:38:28.000000000","tz":120},"subject":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding","message":"flash/nor/kinetis: fix S32K1 FlexNVM partition decoding\n\nTwo problems with SIM_FCFG1[DEPART] on S32K1xx:\n\nDEPART 0xf was treated like a 1xxx data flash size code. This can be\nvalid on S32K148, but not any other S32K1xx parts.\n\nAlso, kinetis_blank_check() read DEPART from bits 11:8 as on Kinetis K.\nOn S32K1xx these bits are reserved and DEPART is in bits 15:12, so the\nblock command was used even with an EEPROM backup partition and failed\nwith ACCERR (\"Flash operation failed, illegal command\") before falling\nback to sector checks.\n\nTested on S32K118, unpartitioned: probe reports 0 KiB data flash instead\nof 512 KiB. Partitioned as 8 KiB data flash / 24 KiB EEPROM backup:\n\u0027flash erase_check\u0027 on the FlexNVM bank no longer reports an error.\n\nCheckpatch-ignore: BAD_SIGN_OFF\nChange-Id: Iee5483f0f54db038dab905b2c67aeac2d4013762\nCo-authored-by: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
