)]}'
{"id":"openocd~master~I1ad2370435015604db9f27c1a76c153480311a28","project":"openocd","branch":"master","hashtags":[],"change_id":"I1ad2370435015604db9f27c1a76c153480311a28","subject":"stm32 configs: use 4kB working area size by default","status":"MERGED","created":"2013-05-04 21:15:30.000000000","updated":"2013-05-10 14:17:57.000000000","submitted":"2013-05-10 14:17:57.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3e4d4d0ce4ae7cdf65712ab03940c9d0c17b5b45","_number":1378,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2013-05-10 14:17:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":1,"date":"2013-05-10 14:17:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":2,"date":"2013-05-10 14:17:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"date":"2013-05-10 14:17:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-06 14:56:48.000000000","updated_by":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"reviewer":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"state":"REVIEWER"},{"updated":"2013-05-08 20:31:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-10 14:17:56.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"dd9fe16665140faf3adecf7c42ff484131778206","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-04 21:25:29.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2892/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2343/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9612324e087221558502d4a62e3cadeda41943b2","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2013-05-06 14:56:48.000000000","message":"Patch Set 1:\n\nShouldn\u0027t you change the value in stm32f1x_stlink.cfg rather than in stm32_stlink.cfg? The former sets WORKAREASIZE to 0x4000 and includes the latter, so the value in the \"internal\" stm32_stlink.cfg will - in most cases - be overriden.","accounts_in_message":[],"_revision_number":1},{"id":"e0735f6c13b0887167ef98732a92a5b1d371966c","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-08 20:21:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3aea03df91b7ae86055a5ee82d1952ff6c051548","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-08 20:23:22.000000000","message":"Patch Set 1:\n\nYep, silly me, haven\u0027t noticed that using a too specific grep pattern, thank you, Freddie.","accounts_in_message":[],"_revision_number":1},{"id":"549307af8894a219302c94ac98f58098ee163836","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-08 20:31:24.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2909/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2360/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2eb6a72e3c3d4c873e662cb93b3fa17a14526bd3","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-10 14:17:56.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3e4d4d0ce4ae7cdf65712ab03940c9d0c17b5b45","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-10 14:17:57.000000000","message":"Change has been successfully cherry-picked as 49af0788e9fdfff45bcf72c4013497b568b42ede","accounts_in_message":[],"_revision_number":3}],"current_revision":"49af0788e9fdfff45bcf72c4013497b568b42ede","revisions":{"04c9354dd004f8f7e95b484be1b68126bd2f989c":{"kind":"REWORK","_number":1,"created":"2013-05-04 21:15:30.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/78/1378/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/1378/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/1 \u0026\u0026 git checkout -b change-1378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/1378/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71789401140ec69448d4ba74e1000783cad6ef9d","subject":"Restore -dev suffix"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-04 21:09:15.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-04 21:09:15.000000000","tz":240},"subject":"stm32 configs: use 4kB working area size by default","message":"stm32 configs: use 4kB working area size by default\n\nThis is needed for configs that might be used with the cheapest\nSTM32F100 parts that have only 4kB SRAM.\n\nRestrictions for the other STM32 families are verified to be set\nappropriately.\n\nChange-Id: I1ad2370435015604db9f27c1a76c153480311a28\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"f1ade72dd85d08181c3fc309615e8138c3e04fa4":{"kind":"REWORK","_number":2,"created":"2013-05-08 20:21:15.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/78/1378/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/1378/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/2 \u0026\u0026 git checkout -b change-1378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/1378/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4264431824f1e3c5fdd7e5fb417c4edad5aa3343","subject":"telnet_server: support C-p, C-n for moving through history"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-04 21:09:15.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-08 20:20:11.000000000","tz":240},"subject":"stm32 configs: use 4kB working area size by default","message":"stm32 configs: use 4kB working area size by default\n\nThis is needed for configs that might be used with the cheapest\nSTM32F100 parts that have only 4kB SRAM.\n\nRestrictions for the other STM32 families are verified to be set\nappropriately.\n\nChange-Id: I1ad2370435015604db9f27c1a76c153480311a28\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"49af0788e9fdfff45bcf72c4013497b568b42ede":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-05-10 14:17:57.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/78/1378/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/1378/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/3 \u0026\u0026 git checkout -b change-1378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/1378/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/1378/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4264431824f1e3c5fdd7e5fb417c4edad5aa3343","subject":"telnet_server: support C-p, C-n for moving through history"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-04 21:09:15.000000000","tz":240},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-05-10 14:17:56.000000000","tz":0},"subject":"stm32 configs: use 4kB working area size by default","message":"stm32 configs: use 4kB working area size by default\n\nThis is needed for configs that might be used with the cheapest\nSTM32F100 parts that have only 4kB SRAM.\n\nRestrictions for the other STM32 families are verified to be set\nappropriately.\n\nChange-Id: I1ad2370435015604db9f27c1a76c153480311a28\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/1378\nTested-by: jenkins\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
