)]}'
{"src/jtag/drivers/remote_bitbang.c":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"476fb2e67d103ed5a6b11f2d9a24bc095d4e98ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#define UNIX_PATH_LEN 108"},{"line_number":34,"context_line":"#endif"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/* arbitrary limit on host name length: */"},{"line_number":37,"context_line":"#define REMOTE_BITBANG_HOST_MAX 255"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#define REMOTE_BITBANG_RAISE_ERROR(expr ...) \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2FY%3D","side":"PARENT","line":36,"updated":"2013-05-08 20:56:09.000000000","message":"The man page seems to also require\n       #include \u003csys/types.h\u003e\n       #include \u003csys/socket.h\u003e\n\nNot sure if omitting them might do any bad for non-GNU systems though.","commit_id":"c765ef0ff6706736da4df1e832063b7ffefe984b"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"fb2d8111d37e173c6f600c64bf7394d3f69606b3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#define UNIX_PATH_LEN 108"},{"line_number":34,"context_line":"#endif"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/* arbitrary limit on host name length: */"},{"line_number":37,"context_line":"#define REMOTE_BITBANG_HOST_MAX 255"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#define REMOTE_BITBANG_RAISE_ERROR(expr ...) \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2FI%3D","side":"PARENT","line":36,"in_reply_to":"AAABs3%2F%2F%2F%2FY%3D","updated":"2013-05-08 23:33:49.000000000","message":"These are \"standard\" headers in OpenOCD that are always available and included via config.h. On other OSes (Windows, specifically), the getaddrinfo prototype and the types it uses are found in other headers than what POSIX specifies. Config.h takes care of these details.","commit_id":"c765ef0ff6706736da4df1e832063b7ffefe984b"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"476fb2e67d103ed5a6b11f2d9a24bc095d4e98ce","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"static int remote_bitbang_init_tcp(void)"},{"line_number":137,"context_line":"{"},{"line_number":138,"context_line":"\tstruct addrinfo hints \u003d { .ai_family \u003d AF_UNSPEC, .ai_socktype \u003d SOCK_STREAM };"},{"line_number":139,"context_line":"\tstruct addrinfo *result, *rp;"},{"line_number":140,"context_line":"\tint fd;"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2Fc%3D","line":138,"updated":"2013-05-08 20:56:09.000000000","message":"\"All the other  members  in the hints parameter must contain either 0, or a null pointer.\" Since the variable is auto, this condition is not met, i\u0027m afraid.","commit_id":"c88bc61cb75a82738d29f6dbd1dd53e56909df18"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"fb2d8111d37e173c6f600c64bf7394d3f69606b3","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"static int remote_bitbang_init_tcp(void)"},{"line_number":137,"context_line":"{"},{"line_number":138,"context_line":"\tstruct addrinfo hints \u003d { .ai_family \u003d AF_UNSPEC, .ai_socktype \u003d SOCK_STREAM };"},{"line_number":139,"context_line":"\tstruct addrinfo *result, *rp;"},{"line_number":140,"context_line":"\tint fd;"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2FE%3D","line":138,"in_reply_to":"AAABs3%2F%2F%2F%2Fc%3D","updated":"2013-05-08 23:33:49.000000000","message":"Yes it is. Unspecified fields in a C99 struct or array initializer are always zero/null. Doesn\u0027t matter if it\u0027s auto or static.","commit_id":"c88bc61cb75a82738d29f6dbd1dd53e56909df18"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"476fb2e67d103ed5a6b11f2d9a24bc095d4e98ce","unresolved":false,"context_lines":[{"line_number":139,"context_line":"\tstruct addrinfo *result, *rp;"},{"line_number":140,"context_line":"\tint fd;"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"\tLOG_INFO(\"Connecting to %s:%s\", remote_bitbang_host ?: \"localhost\", remote_bitbang_port);"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"\t/* Obtain address(es) matching host/port */"},{"line_number":145,"context_line":"\tint s \u003d getaddrinfo(remote_bitbang_host, remote_bitbang_port, \u0026hints, \u0026result);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2Fg%3D","line":142,"updated":"2013-05-08 20:56:09.000000000","message":"This relies on the GNU extension to the conditional operator, however, it\u0027s supported on LLVM/Clang too: http://clang.llvm.org/doxygen/classclang_1_1BinaryConditionalOperator.html","commit_id":"c88bc61cb75a82738d29f6dbd1dd53e56909df18"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"fb2d8111d37e173c6f600c64bf7394d3f69606b3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"\tstruct addrinfo *result, *rp;"},{"line_number":140,"context_line":"\tint fd;"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"\tLOG_INFO(\"Connecting to %s:%s\", remote_bitbang_host ?: \"localhost\", remote_bitbang_port);"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"\t/* Obtain address(es) matching host/port */"},{"line_number":145,"context_line":"\tint s \u003d getaddrinfo(remote_bitbang_host, remote_bitbang_port, \u0026hints, \u0026result);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"AAABs3%2F%2F%2F%2FA%3D","line":142,"in_reply_to":"AAABs3%2F%2F%2F%2Fg%3D","updated":"2013-05-08 23:33:49.000000000","message":"Right. Even though OpenOCD probably wont compile on any other compiler, it\u0027s unnecessary to make it even harder just to save a few chars. Will change this.","commit_id":"c88bc61cb75a82738d29f6dbd1dd53e56909df18"}]}
