)]}'
{"id":"openocd~master~I990a49506cac4b26faf77587937e506138371f7c","project":"openocd","branch":"master","hashtags":[],"change_id":"I990a49506cac4b26faf77587937e506138371f7c","subject":"remote_bitbang: Convert to use getaddrinfo()","status":"MERGED","created":"2013-05-05 22:00:47.000000000","updated":"2013-05-10 14:46:44.000000000","submitted":"2013-05-10 14:46:44.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1e200706452b1c69a45c4175b4d5528769c909ff","_number":1379,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2013-05-10 14:46:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":1,"date":"2013-05-10 14:46:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":1,"date":"2013-05-10 14:46:44.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2013-05-10 14:46:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"date":"2013-05-10 14:46:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-06 15:10:57.000000000","updated_by":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"reviewer":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"state":"REVIEWER"},{"updated":"2013-05-09 18:09:55.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2013-05-09 18:15:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-10 14:46:44.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"0449425d2cded764bb2f6947ca8f9cf935e7a437","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-05 22:11:07.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2895/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2346/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"68746f1d609496813366a2c45800f0e345037725","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2013-05-06 15:10:57.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"476fb2e67d103ed5a6b11f2d9a24bc095d4e98ce","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-08 20:56:09.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(3 inline comments)\n\nThe hints usage feels really fishy to me, see patch comments.","accounts_in_message":[],"_revision_number":1},{"id":"fb2d8111d37e173c6f600c64bf7394d3f69606b3","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2013-05-08 23:33:49.000000000","message":"Patch Set 1: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"2c924acf893b466a80b81582f38086bf454550f7","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-09 09:17:31.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nTo compensate for my initializers mistake I decided to actually test the driver real-life :)\n\nEverything works fine so far: IPv6, IPv6LL, IPv4, fallback to the next addrinfo result, Unix sockets.\n\nJust for the kicks, speed testing over WiFi:\ndumped 4096 bytes in 33.031002s (0.121 KiB/s)\nLocally over a Unix socket:\ndumped 4096 bytes in 11.712077s (0.342 KiB/s)\n\nWill post the test server to Gerrit soon.","accounts_in_message":[],"_revision_number":1},{"id":"6c1449e95c95b03c60730f3323c051b646111fcc","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2013-05-09 17:57:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"afc4bffdb8ffbd4596496b53b04d3eca628b07a0","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-09 18:09:55.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"888a9f28463997b667f0a278cf00465e112ba8e7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-09 18:15:31.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2912/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2363/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"956657ac0ca49851259a96462d00ca76bed2aafa","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-10 14:46:44.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1e200706452b1c69a45c4175b4d5528769c909ff","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-10 14:46:44.000000000","message":"Change has been successfully cherry-picked as 00ba179dbc1861bf51a67565abd4fa687831573f","accounts_in_message":[],"_revision_number":3}],"current_revision":"00ba179dbc1861bf51a67565abd4fa687831573f","revisions":{"c88bc61cb75a82738d29f6dbd1dd53e56909df18":{"kind":"REWORK","_number":1,"created":"2013-05-05 22:00:47.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/79/1379/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/1379/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/1 \u0026\u0026 git checkout -b change-1379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/1379/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c765ef0ff6706736da4df1e832063b7ffefe984b","subject":"Restore normal development cycle"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2013-05-05 21:58:32.000000000","tz":120},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2013-05-05 21:58:32.000000000","tz":120},"subject":"remote_bitbang: Convert to use getaddrinfo()","message":"remote_bitbang: Convert to use getaddrinfo()\n\nSince gethostbyname() is deprecated and inconvenient, rewrite to use\ngetaddrinfo() using an implementation more or less copied from its man\npage. This automatically enables support for IPv6.\n\nThis also fixes a FTBFS on ARM due to alignment issues.\n\nChange-Id: I990a49506cac4b26faf77587937e506138371f7c\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"12fd26a8122072c1599b5a80bc2d70b1082bd1b4":{"kind":"REWORK","_number":2,"created":"2013-05-09 17:57:40.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/79/1379/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/1379/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/2 \u0026\u0026 git checkout -b change-1379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/1379/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c765ef0ff6706736da4df1e832063b7ffefe984b","subject":"Restore normal development cycle"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2013-05-05 21:58:32.000000000","tz":120},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2013-05-09 17:55:17.000000000","tz":120},"subject":"remote_bitbang: Convert to use getaddrinfo()","message":"remote_bitbang: Convert to use getaddrinfo()\n\nSince gethostbyname() is deprecated and inconvenient, rewrite to use\ngetaddrinfo() using an implementation more or less copied from its man\npage. This automatically enables support for IPv6.\n\nThis also fixes a FTBFS on ARM due to alignment issues.\n\nChange-Id: I990a49506cac4b26faf77587937e506138371f7c\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"00ba179dbc1861bf51a67565abd4fa687831573f":{"kind":"REWORK","_number":3,"created":"2013-05-10 14:46:44.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/79/1379/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/1379/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/3 \u0026\u0026 git checkout -b change-1379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/1379/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/1379/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"232af6cc9bae571d74838dd1d7ce52544c0b6380","subject":"Added functionality to the SYS_SYSTEM semihosting call."}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2013-05-05 21:58:32.000000000","tz":120},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-05-10 14:46:44.000000000","tz":0},"subject":"remote_bitbang: Convert to use getaddrinfo()","message":"remote_bitbang: Convert to use getaddrinfo()\n\nSince gethostbyname() is deprecated and inconvenient, rewrite to use\ngetaddrinfo() using an implementation more or less copied from its man\npage. This automatically enables support for IPv6.\n\nThis also fixes a FTBFS on ARM due to alignment issues.\n\nChange-Id: I990a49506cac4b26faf77587937e506138371f7c\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/1379\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
