)]}'
{"id":"openocd~master~I3768866579fc7e9185814a90edf6bd9c381fa9f9","project":"openocd","branch":"master","hashtags":[],"change_id":"I3768866579fc7e9185814a90edf6bd9c381fa9f9","subject":"reset_config: default to srst_nogate for ARMv7-M targets","status":"ABANDONED","created":"2013-05-11 11:37:28.000000000","updated":"2013-06-03 10:57:29.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e850038a3807e3a73120145cc323bee72b2495a1","_number":1404,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2013-05-29 14:34:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":1,"date":"2013-05-15 06:40:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":-1,"date":"2013-05-29 15:48:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2013-05-15 06:40:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-15 06:40:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-29 14:34:18.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"26e0ac745b612c76f29345ead53d174c1a92ed2d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-11 11:46:27.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2915/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2366/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"20083365593ec6b3170e40b16b37e72f6d6bb748","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-11 11:52:33.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nThis actually conflicts with assumption in cortex_m.c that if SRST_NO_GATING flag is present, it\u0027s ok to try pulling srst, will rebase on top of a fix for that.","accounts_in_message":[],"_revision_number":1},{"id":"4fa779db4a8a3e719aaadf1dee6512f47e357935","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-11 12:00:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1899d367c6f88363447fab3a4965ea37ac79dde3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-11 12:10:07.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2916/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2367/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c512944f5198c6bc3b9064d2894c98fc5cf02427","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-14 09:27:31.000000000","message":"Patch Set 2:\n\nI agree the reset needs cleaning up. We have before mentioned a schemem where the target registers what it supports, that way we can adapt the reset behaviour a bit better.\n\nCan we not do this in armv7m_init_arch_info, that way we can handle the hla adapters aswell?","accounts_in_message":[],"_revision_number":2},{"id":"5b2c89f6592143d437a0e50ad22244043ad686c4","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-15 06:20:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"153d84c4e067f10f2c648c15fb79bca636cf4894","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-15 06:40:53.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2371/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2919/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"fdc710dd4c0e29c53b04342ab691dcfed2913566","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-29 14:34:18.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"31d7d85d5c8a0a144ead878c2cd78764da9b587a","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-29 15:48:04.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\nI have been thinking about this and am not convinced forcing it here is the best solution. One of my test platforms has a stm32 and a str750 on the jtag chain and this patch breaks that.","accounts_in_message":[],"_revision_number":3},{"id":"0aadba90350a86cd5a50e465902e882fb6f51047","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-06-03 10:23:32.000000000","message":"Patch Set 3: Abandoned\n\nI thought that for such an odd case one can simply add \"reset_config srst_gates_jtag\" command just before init, so it wouldn\u0027t be a big deal.\n\nBut if there\u0027re existing configs in the wild that would be broken by such a change, I see there\u0027s clearly too little reason to have that minor improvement if it is not possible to keep the existing configs working without changes.\n\nProbably this topic should be revisited when some more elaborated reset infrastructure is implemented.\n\nThank you for the testing, and sorry for the noise.","accounts_in_message":[],"_revision_number":3},{"id":"ae42cc8e4dcc005056b22b16cf8fd83bc54b8bec","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-06-03 10:57:29.000000000","message":"Patch Set 3:\n\nThe problem is the reset config is global, so if you have one device on the chain that supports srst_gates_jtag this would tell OpenOCD that all devices on the chain support this option.\n\nIn the past we have talked about how this needs changing, ie each target describes what it supports, the adapter describes what it supports, and from this OpenOCD can decides the best method that will work. Perhaps one day.","accounts_in_message":[],"_revision_number":3}],"current_revision":"490c7639c6bdbece73611f8abe79eb799c10bd66","revisions":{"490c7639c6bdbece73611f8abe79eb799c10bd66":{"kind":"REWORK","_number":3,"created":"2013-05-15 06:20:40.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/04/1404/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/1404/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/3 \u0026\u0026 git checkout -b change-1404 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/1404/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1739841b4d068fe9d94143f47cee6bdf626159e6","subject":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:26:50.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-15 06:18:55.000000000","tz":240},"subject":"reset_config: default to srst_nogate for ARMv7-M targets","message":"reset_config: default to srst_nogate for ARMv7-M targets\n\nARM DDI 0405A-91 (ARM v7-M Architecture Application Level Reference\nManual) C1.1 Introduction to debug states:\n\n``Debug is normally accessed via the DAP (see The Debug Access Port\n(DAP) on page C1-4), which allows access to debug and system memory\nwhether the processor is running, halted, or held in reset. When a\ncore is halted, the core is in debug state.\u0027\u0027\n\nARM DDI 0337E (Cortex-M3 TRM) 11.2 System debug access states:\n\n``During a system reset the debugger can read all registers within the\nPPB space. It can also write to registers within the PPB space that\nare only reset by a power on reset.\u0027\u0027\n\nSo for the overwhelming majority of usecases involving armv7m\n(including cortex-m), that being either a single or multiple cortex-m\ncores per JTAG chain, system reset does not prevent JTAG access so set\nthis as default.\n\nChange-Id: I3768866579fc7e9185814a90edf6bd9c381fa9f9\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"c6729d0a3eaf3c9f8e8318302ff492610d9d6105":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-05-11 12:00:37.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/04/1404/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/1404/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/2 \u0026\u0026 git checkout -b change-1404 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/1404/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"021bddade361674058b505c99ac6e1d26e10544e","subject":"cortex_m: do not try asserting SRST if it\u0027s not present"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:26:50.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:58:59.000000000","tz":240},"subject":"reset_config: default to srst_nogate for Cortex-M targets","message":"reset_config: default to srst_nogate for Cortex-M targets\n\nARM DDI 0337E (Cortex-M3 TRM) 11.2 System debug access states:\n\n``During a system reset the debugger can read all registers within the PPB\nspace. It can also write to registers within the PPB space that are only\nreset by a power on reset.\u0027\u0027\n\nFor the overwhelming majority of usecases involving cortex-m (either a\nsingle or multiple cortex-m cores per JTAG chain) system reset does not\nprevent JTAG access so set this as default.\n\nChange-Id: I3768866579fc7e9185814a90edf6bd9c381fa9f9\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"cf340929d1ad0f0b0508daebc17d103cb52acefd":{"kind":"REWORK","_number":1,"created":"2013-05-11 11:37:28.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/04/1404/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/1404/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/1 \u0026\u0026 git checkout -b change-1404 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/1404/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/1404/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4264431824f1e3c5fdd7e5fb417c4edad5aa3343","subject":"telnet_server: support C-p, C-n for moving through history"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:26:50.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:35:50.000000000","tz":240},"subject":"reset_config: default to srst_nogate for Cortex-M targets","message":"reset_config: default to srst_nogate for Cortex-M targets\n\nARM DDI 0337E (Cortex-M3 TRM) 11.2 System debug access states:\n\n``During a system reset the debugger can read all registers within the PPB\nspace. It can also write to registers within the PPB space that are only\nreset by a power on reset.\u0027\u0027\n\nFor the overwhelming majority of usecases involving cortex-m (either a\nsingle or multiple cortex-m cores per JTAG chain) system reset does not\nprevent JTAG access so set this as default.\n\nChange-Id: I3768866579fc7e9185814a90edf6bd9c381fa9f9\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
