)]}'
{"id":"openocd~master~Ib1c6f68feed0b8057d55afd5f260bb22ab332ced","project":"openocd","branch":"master","hashtags":[],"change_id":"Ib1c6f68feed0b8057d55afd5f260bb22ab332ced","subject":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present","status":"MERGED","created":"2013-05-11 12:00:37.000000000","updated":"2013-05-29 14:39:27.000000000","submitted":"2013-05-29 14:39:27.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"98518faad7846238e2f486f9a8ad737bea3d01e9","_number":1405,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2013-05-29 14:39:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":1,"date":"2013-05-29 14:39:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2013-05-29 14:39:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"date":"2013-05-29 14:39:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-15 06:31:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-29 14:33:42.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"5434b52874de21bc1c3856e8d4af8de5c47d26b3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-11 12:18:30.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2917/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2368/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"aebe6c34f9095a1e6d056c81216d3338c0f9d8da","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-11 12:20:47.000000000","message":"Patch Set 1:\n\nThe way reset config is currently handled seems a bit messy and it\u0027s not clear what to do about it. Same problem as shown by this patch is present in hla_target.c and there\u0027re other places where it\u0027s assumed that if NO_GATING flag is present then SRST must be available too.\n\nMy idea is just to have sensible defaults for the user...","accounts_in_message":[],"_revision_number":1},{"id":"dcb723bb8b61c6b87ba3b31e937159dfb8addb93","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-14 09:20:05.000000000","message":"Patch Set 1:\n\nCan you add support to the hla target aswell?\nHad a quick look and all the other targets look ok.","accounts_in_message":[],"_revision_number":1},{"id":"704d74d7d14b85902e9e6f687cebdc79292bfa88","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-15 06:20:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e8df0356da145984170f8f1ebc89c2592231fea0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-15 06:31:13.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2370/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2920/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"72cb2c2d1ff1367fae5743a56c22cfda1821ead7","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-29 14:33:42.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"98518faad7846238e2f486f9a8ad737bea3d01e9","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-29 14:39:27.000000000","message":"Change has been successfully cherry-picked as afca2e817dbc7592abd49a32e3457772afc98cd7","accounts_in_message":[],"_revision_number":3}],"current_revision":"afca2e817dbc7592abd49a32e3457772afc98cd7","revisions":{"021bddade361674058b505c99ac6e1d26e10544e":{"kind":"REWORK","_number":1,"created":"2013-05-11 12:00:37.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/05/1405/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/1405/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/1 \u0026\u0026 git checkout -b change-1405 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/1405/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:55:20.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:58:17.000000000","tz":240},"subject":"cortex_m: do not try asserting SRST if it\u0027s not present","message":"cortex_m: do not try asserting SRST if it\u0027s not present\n\nChange-Id: Ib1c6f68feed0b8057d55afd5f260bb22ab332ced\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"afca2e817dbc7592abd49a32e3457772afc98cd7":{"kind":"REWORK","_number":3,"created":"2013-05-29 14:39:27.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/05/1405/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/1405/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/3 \u0026\u0026 git checkout -b change-1405 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/1405/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a231e295ce608665c64442b19ee0d2fff4fc38c","subject":"interface/ftdi: remove \"untested\" warning from DP Busblaster"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:55:20.000000000","tz":240},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-05-29 14:39:26.000000000","tz":0},"subject":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present","message":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present\n\nThis should cover all the cases when RESET_SRST_NO_GATING is set\nwithout RESET_HAS_SRST. This might happen when RESET_SRST_NO_GATING is\nautomatically set by a target code (and not from tcl).\n\nHowever, there\u0027re some other places (mips_m4k, arm7_9_common) where\nadding RESET_SRST_PULLS_TRST would lead to trying to use SRST even if\nit\u0027s not present. Currently it\u0027s impossible for the user to enable\nthat flag without enabling SRST.\n\nChange-Id: Ib1c6f68feed0b8057d55afd5f260bb22ab332ced\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/1405\nTested-by: jenkins\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"1739841b4d068fe9d94143f47cee6bdf626159e6":{"kind":"REWORK","_number":2,"created":"2013-05-15 06:20:40.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/05/1405/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/1405/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/2 \u0026\u0026 git checkout -b change-1405 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/1405/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/1405/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-11 11:55:20.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-15 06:18:28.000000000","tz":240},"subject":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present","message":"cortex_m, hla_target: do not try asserting SRST if it\u0027s not present\n\nThis should cover all the cases when RESET_SRST_NO_GATING is set\nwithout RESET_HAS_SRST. This might happen when RESET_SRST_NO_GATING is\nautomatically set by a target code (and not from tcl).\n\nHowever, there\u0027re some other places (mips_m4k, arm7_9_common) where\nadding RESET_SRST_PULLS_TRST would lead to trying to use SRST even if\nit\u0027s not present. Currently it\u0027s impossible for the user to enable\nthat flag without enabling SRST.\n\nChange-Id: Ib1c6f68feed0b8057d55afd5f260bb22ab332ced\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
