)]}'
{"configure.ac":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c3f1c740bede6f030d37d5d96fa459380289a6e8","unresolved":false,"context_lines":[{"line_number":760,"context_line":"  AC_DEFINE([BUILD_USBPROG], [0], [0 if you don\u0027t want the usbprog JTAG driver.])"},{"line_number":761,"context_line":"fi"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"if test $build_openjtag_ftd2xx \u003d yes -o $build_openjtag_ftdi \u003d yes; then"},{"line_number":764,"context_line":"  AC_DEFINE([BUILD_OPENJTAG], [1], [1 if you want the OpenJTAG driver.])"},{"line_number":765,"context_line":"  if test $build_openjtag_ftd2xx \u003d yes; then"},{"line_number":766,"context_line":"    AC_DEFINE([BUILD_OPENJTAG_FTD2XX], [1], [1 if you want the OpenJTAG driver with FTD2XX driver.])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAABtX%2F%2F%2F%2Fs%3D","line":763,"updated":"2013-05-15 21:16:24.000000000","message":"Splitting these into two separate if-else will be much cleaner.","commit_id":"e2492ac78ac4edc1486f08896621739e77b28385"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c3f1c740bede6f030d37d5d96fa459380289a6e8","unresolved":false,"context_lines":[{"line_number":864,"context_line":"  AC_MSG_ERROR([The option: with_ftd2xx_linux_tardir is for LINUX only.])"},{"line_number":865,"context_line":"fi"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"if test $build_ft2232_ftd2xx \u003d yes -o $build_presto_ftd2xx \u003d yes -o $build_usb_blaster_ftd2xx \u003d yes -o $build_openjtag_ftd2xx; then"},{"line_number":868,"context_line":"  AC_MSG_CHECKING([for ftd2xx.lib exists (win32)])"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"  # if we are given a zipdir..."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAABtX%2F%2F%2F%2Fw%3D","line":867,"updated":"2013-05-15 21:16:24.000000000","message":"missing \" \u003d yes\", causing build failure.","commit_id":"e2492ac78ac4edc1486f08896621739e77b28385"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c3f1c740bede6f030d37d5d96fa459380289a6e8","unresolved":false,"context_lines":[{"line_number":937,"context_line":"  LDFLAGS \u003d \"$LDFLAGS -L/usr/lib/x86_64-linux-gnu/\""},{"line_number":938,"context_line":"  LIBS\u003d\"$LIBS -lftdi\""},{"line_number":939,"context_line":"  AC_MSG_RESULT([-L/usr/lib/x86_64-linux-gnu/ -lftdi])"},{"line_number":940,"context_line":"fi"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"if test $is_win32 \u003d no \u0026\u0026 test $is_darwin \u003d no ; then"},{"line_number":943,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAABtX%2F%2F%2F%2F0%3D","line":940,"updated":"2013-05-15 21:16:24.000000000","message":"I\u0027m no autotools whiz, but I\u0027m pretty sure this is not the way to do it. Besides, libftdi is already checked for at line 1061, piggyback on that test instead.","commit_id":"e2492ac78ac4edc1486f08896621739e77b28385"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c3f1c740bede6f030d37d5d96fa459380289a6e8","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"build_usb\u003dno"},{"line_number":1176,"context_line":"if test $build_vsllink \u003d yes -o $build_usbprog \u003d yes -o \\"},{"line_number":1177,"context_line":"  $build_rlink \u003d yes -o $build_ulink \u003d yes -o $build_armjtagew \u003d yes \\"},{"line_number":1178,"context_line":"  -o $build_openjtag_ftd2xx \u003d yes"},{"line_number":1179,"context_line":"then"},{"line_number":1180,"context_line":"  build_usb\u003dyes"},{"line_number":1181,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAABtX%2F%2F%2F%2F4%3D","line":1178,"updated":"2013-05-15 21:16:24.000000000","message":"I don\u0027t think you need the libusb-0.1 header?","commit_id":"e2492ac78ac4edc1486f08896621739e77b28385"}],"src/jtag/drivers/openjtag.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b44565eab6cabe0c24576760c0d5b70e2d8d8ea2","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"/* OpenJTAG vid/pid */"},{"line_number":86,"context_line":"static uint16_t openjtag_vid \u003d 0x0403;"},{"line_number":87,"context_line":"static uint16_t openjtag_pid \u003d 0x6001;"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"static char *openjtag_device_desc;"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"AAABtX%2F%2F%2F%2FU%3D","line":87,"updated":"2013-05-16 23:01:32.000000000","message":"It\u0027s a bad idea to use the standard FTDI VID/PID for this adapter, at least without setting and checking the description string. Any FTDI USB\u003c-\u003eserial adapter that happens to be plugged in can and will be mistaken for an OpenJTAG adapter. Not that there\u0027s much to do about it in OpenOCD.","commit_id":"5620c20bfccb21ded4ec8d721b6c59d168f33b3a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b44565eab6cabe0c24576760c0d5b70e2d8d8ea2","unresolved":false,"context_lines":[{"line_number":311,"context_line":"\t\t\tftdi_get_error_string(\u0026ftdic));"},{"line_number":312,"context_line":"\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":313,"context_line":"\t};"},{"line_number":314,"context_line":"#endif"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\treturn ERROR_OK;"},{"line_number":317,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"AAABtX%2F%2F%2F%2FI%3D","line":314,"updated":"2013-05-16 23:01:32.000000000","message":"Doesn\u0027t the adapter support setting the speed robustly? According to the protocol description, there is a clock divisor command. Fiddling with the baudrate is probably not the right way.","commit_id":"5620c20bfccb21ded4ec8d721b6c59d168f33b3a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b44565eab6cabe0c24576760c0d5b70e2d8d8ea2","unresolved":false,"context_lines":[{"line_number":795,"context_line":"\t}"},{"line_number":796,"context_line":"\telse"},{"line_number":797,"context_line":"\t\tLOG_WARNING(\"incomplete usb_blaster_vid_pid configuration\");"},{"line_number":798,"context_line":"\t*/"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"\treturn ERROR_OK;"},{"line_number":801,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"AAABtX%2F%2F%2F%2FQ%3D","line":798,"updated":"2013-05-16 23:01:32.000000000","message":"Don\u0027t add code that is commented out. If the command isn\u0027t implemented, don\u0027t add it.","commit_id":"5620c20bfccb21ded4ec8d721b6c59d168f33b3a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b44565eab6cabe0c24576760c0d5b70e2d8d8ea2","unresolved":false,"context_lines":[{"line_number":844,"context_line":"\t\tLOG_ERROR(\"%s takes exactly two arguments\", CMD_NAME);"},{"line_number":845,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":846,"context_line":"\t}"},{"line_number":847,"context_line":"\t*/"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"\treturn ERROR_OK;"},{"line_number":850,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"AAABtX%2F%2F%2F%2FM%3D","line":847,"updated":"2013-05-16 23:01:32.000000000","message":"Ditto","commit_id":"5620c20bfccb21ded4ec8d721b6c59d168f33b3a"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"ce345a32018969a7ad3aa38086f4af07bc761753","unresolved":false,"context_lines":[{"line_number":28,"context_line":" *   You should have received a copy of the GNU General Public License         *"},{"line_number":29,"context_line":" *   along with this program; if not, write to the                             *"},{"line_number":30,"context_line":" *   Free Software Foundation, Inc.,                                           *"},{"line_number":31,"context_line":" *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.                 *"},{"line_number":32,"context_line":" ***************************************************************************/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/***************************************************************************"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"AAABtn%2F%2F%2F4g%3D","line":31,"updated":"2013-06-04 20:16:04.000000000","message":"FSF address needs updating - 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.","commit_id":"fc2fecf7966558c6f7e17b95db688553f6e287be"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b466e2291e5721ce8f74fc72cea8f186ea048eb0","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"static int openjtag_speed(int speed)"},{"line_number":303,"context_line":"{"},{"line_number":304,"context_line":"\tint clockcmd \u003d 0xE0;"},{"line_number":305,"context_line":"\tswitch (speed) {"},{"line_number":306,"context_line":"\t\tcase 48000:"},{"line_number":307,"context_line":"\t\t\tclockcmd \u003d 0x00;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"AAABtn%2F%2F%2F4M%3D","line":304,"updated":"2013-06-04 21:57:16.000000000","message":"Remove unnecessary initialization... probably you needed it to silence compiler warning caused by bug in case 375 below.","commit_id":"fc2fecf7966558c6f7e17b95db688553f6e287be"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b466e2291e5721ce8f74fc72cea8f186ea048eb0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"\t\t\tbreak;"},{"line_number":327,"context_line":"\t\tcase 375:"},{"line_number":328,"context_line":"\t\t\tbreak;"},{"line_number":329,"context_line":"\t\t\tclockcmd \u003d 0xE0;"},{"line_number":330,"context_line":"\t\tdefault:"},{"line_number":331,"context_line":"\t\t\tclockcmd \u003d 0xE0;"},{"line_number":332,"context_line":"\t\t\tLOG_WARNING(\"adapter speed not recognized, reverting to 375 kHz\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"AAABtn%2F%2F%2F4I%3D","line":329,"updated":"2013-06-04 21:57:16.000000000","message":"The order of these statements are reversed.","commit_id":"fc2fecf7966558c6f7e17b95db688553f6e287be"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b466e2291e5721ce8f74fc72cea8f186ea048eb0","unresolved":false,"context_lines":[{"line_number":787,"context_line":""},{"line_number":788,"context_line":"static int openjtag_khz(int khz, int *jtag_speed)"},{"line_number":789,"context_line":"{"},{"line_number":790,"context_line":"\t*jtag_speed \u003d khz;"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"\treturn ERROR_OK;"},{"line_number":793,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"AAABtn%2F%2F%2F4Q%3D","line":790,"updated":"2013-06-04 21:57:16.000000000","message":"I think here you could set *jtag_speed to the highest supported speed equal or lower than khz. Just to avoid falling back to the lowest speed if the requested one isn\u0027t a perfect match.\n\nThe speed handling interface is really awkward. I\u0027ve been meaning to fix it for some time.","commit_id":"fc2fecf7966558c6f7e17b95db688553f6e287be"}],"src/jtag/interface.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b44565eab6cabe0c24576760c0d5b70e2d8d8ea2","unresolved":false,"context_lines":[{"line_number":16,"context_line":" *   it under the terms of the GNU General Public License as published by  *"},{"line_number":17,"context_line":" *   the Free Software Foundation; either version 2 of the License, or     *"},{"line_number":18,"context_line":" *   (at your option) any later version.                                   *"},{"line_number":19,"context_line":"*                                                                         *"},{"line_number":20,"context_line":" *   This program is distributed in the hope that it will be useful,       *"},{"line_number":21,"context_line":" *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *"},{"line_number":22,"context_line":" *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"AAABtX%2F%2F%2F%2FY%3D","line":19,"updated":"2013-05-16 23:01:32.000000000","message":"Remove this unrelated change as well.","commit_id":"5620c20bfccb21ded4ec8d721b6c59d168f33b3a"}],"tcl/interface/openjtag.cfg":[{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"ce345a32018969a7ad3aa38086f4af07bc761753","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"interface openjtag"},{"line_number":8,"context_line":"adapter_khz 6000"},{"line_number":9,"context_line":"openjtag_device_desc \"Open JTAG Project\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"AAABtn%2F%2F%2F4c%3D","line":8,"updated":"2013-06-04 20:16:04.000000000","message":"should not really set speed here, this should be done in the target","commit_id":"fc2fecf7966558c6f7e17b95db688553f6e287be"}]}
