)]}'
{"id":"openocd~master~Ib9289fc6d946630133ec6e36c20015ccb50acf61","project":"openocd","branch":"master","hashtags":[],"change_id":"Ib9289fc6d946630133ec6e36c20015ccb50acf61","subject":"targets: fix target_type name for Cortex-A targets","status":"MERGED","created":"2013-05-23 11:32:46.000000000","updated":"2013-05-28 08:48:46.000000000","submitted":"2013-05-28 08:48:46.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"271b2ae918d8c1c262c7a6f2a1d6d81399f21546","_number":1420,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},{"value":0,"date":"2013-05-28 08:48:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":1,"date":"2013-05-28 08:48:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":1,"date":"2013-05-28 08:48:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},{"value":2,"date":"2013-05-28 08:48:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"date":"2013-05-28 08:48:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-24 03:30:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-27 04:36:30.000000000","updated_by":{"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},"reviewer":{"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},"state":"REVIEWER"},{"updated":"2013-05-28 08:48:45.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"7b19ebe943db2f5d8d2736b096fcbc88c8faa6ce","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-23 11:41:33.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2381/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2930/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2d45de016559aaf16a8db09b20cd9870a15a89bd","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-23 18:48:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"97025ed85e2276eb7ba78cfd481b2310fd5362c7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-23 18:57:04.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2382/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2931/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b7d8e19b29b9be010545744e2e5cfa5cd665e464","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-24 03:21:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1a06161f355901e6ba1e19c9d21624f162c9395c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-24 03:30:30.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2384/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2933/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"c25ed3d87b81cca4136a11e60670a584a9c9ffa7","author":{"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},"real_author":{"_account_id":1000435,"name":"Chris Johns","email":"chrisj@rtems.org","username":"kiwichris"},"date":"2013-05-27 04:36:30.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nLooks good. This change requires board/imx6.cfg be changes to cortex_a rather than cortex_a8.","accounts_in_message":[],"_revision_number":3},{"id":"fa2300870125647715c52168ce17c3e57e06624f","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-28 08:48:45.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"271b2ae918d8c1c262c7a6f2a1d6d81399f21546","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-05-28 08:48:46.000000000","message":"Change has been successfully cherry-picked as 2aada5b8d9869ebc69984223710253ba905d61cd","accounts_in_message":[],"_revision_number":4}],"current_revision":"2aada5b8d9869ebc69984223710253ba905d61cd","revisions":{"2aada5b8d9869ebc69984223710253ba905d61cd":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2013-05-28 08:48:46.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/20/1420/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/1420/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/4 \u0026\u0026 git checkout -b change-1420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/1420/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 11:20:45.000000000","tz":240},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-05-28 08:48:45.000000000","tz":0},"subject":"targets: fix target_type name for Cortex-A targets","message":"targets: fix target_type name for Cortex-A targets\n\nCommit d9ba56c295f057e716519a798bf9cdb4898c24f4 did a bunch of\nrenaming of cortex_a8 to cortex_a, including the names in config\nfiles. However that introduced a regression as the name in target_type\nstruct remained unchanged.\n\nThis adds the last missing bit: actual renaming of the target name as\nunderstood by OpenOCD.\n\nAlso change the (hopefully) last instance of using it in the supplied\nconfig files, namely from imx6.cfg.\n\nChange-Id: Ib9289fc6d946630133ec6e36c20015ccb50acf61\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/1420\nTested-by: jenkins\nReviewed-by: Chris Johns \u003cchrisj@rtems.org\u003e\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"31420f8712729433f4e35a2677c736572504bf26":{"kind":"REWORK","_number":3,"created":"2013-05-24 03:21:50.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/20/1420/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/1420/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/3 \u0026\u0026 git checkout -b change-1420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/1420/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 11:20:45.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-24 03:20:56.000000000","tz":240},"subject":"targets: fix target_type name for Cortex-A targets","message":"targets: fix target_type name for Cortex-A targets\n\nCommit d9ba56c295f057e716519a798bf9cdb4898c24f4 did a bunch of\nrenaming of cortex_a8 to cortex_a, including the names in config\nfiles. However that introduced a regression as the name in target_type\nstruct remained unchanged.\n\nThis adds the last missing bit: actual renaming of the target name as\nunderstood by OpenOCD.\n\nAlso change the (hopefully) last instance of using it in the supplied\nconfig files, namely from imx6.cfg.\n\nChange-Id: Ib9289fc6d946630133ec6e36c20015ccb50acf61\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"45f8498ed4daf4e4245ee3ff814c9ed19b44e59a":{"kind":"REWORK","_number":2,"created":"2013-05-23 18:48:00.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/20/1420/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/1420/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/2 \u0026\u0026 git checkout -b change-1420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/1420/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 11:20:45.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 18:45:20.000000000","tz":240},"subject":"targets: fix target_type name for Cortex-A targets","message":"targets: fix target_type name for Cortex-A targets\n\nCommit d9ba56c295f057e716519a798bf9cdb4898c24f4 did a bunch of\nrenaming of cortex_a8 to cortex_a, including the names in config\nfiles. However that introduced a regression as the name in target_type\nstruct remained unchanged.\n\nThis adds the last missing bit: actual renaming of the target name as\nunderstood by OpenOCD.\n\nChange-Id: Ib9289fc6d946630133ec6e36c20015ccb50acf61\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"bdefc26bac4ac5c0161aab8c3ca949feb804c778":{"kind":"REWORK","_number":1,"created":"2013-05-23 11:32:46.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/20/1420/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/20/1420/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/1 \u0026\u0026 git checkout -b change-1420 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/20/1420/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/20/1420/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a2ffac8e2db994e691065259422fa6886ee67f","subject":"remote_bitbang: De-duplicate init code and clean up on error"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 11:20:45.000000000","tz":240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2013-05-23 11:20:45.000000000","tz":240},"subject":"targets: fix target_type name for Cortex-A targets","message":"targets: fix target_type name for Cortex-A targets\n\nCommit d9ba56c295f057e716519a798bf9cdb4898c24f4 did a bunch of\nrenaming of cortex_a8 to cortex_a, including the names in config\nfiles. However that introduced a regression as the name in target_type\nstruct remained unchanged.\n\nThis adds the last missing bit: actual renaming of the target name as\nunderstood by OpenOCD.\n\nChange-Id: Ib9289fc6d946630133ec6e36c20015ccb50acf61\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
