)]}'
{"id":"openocd~master~I9947b465aef26519258027ff6c0ac9b15252fffd","project":"openocd","branch":"master","hashtags":[],"change_id":"I9947b465aef26519258027ff6c0ac9b15252fffd","subject":"jlink: add PID for jlink included on SAM4 kits","status":"ABANDONED","created":"2013-05-23 23:32:01.000000000","updated":"2013-05-24 15:46:01.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eb5a2c5e87244e4543f36856f7c401344fe2f083","_number":1421,"owner":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":-1,"date":"2013-05-23 23:32:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"disliked":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":-1,"date":"2013-05-24 06:57:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2013-05-23 23:32:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-23 23:32:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-24 06:57:28.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"4a1862554538d47806534c06e719a3de92efcd92","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-05-23 23:32:21.000000000","message":"Patch Set 1: Fails\n\nBuild Failed \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2383/ : FAILURE\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/2932/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"0230b360f0b8b7ef3c20554702ee45ef4753e884","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2013-05-24 06:57:28.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nHi,\n\nGoogling confirms that the board has 0x0105 version of jlink. But please state it clearly in your commit message if this new jlink version is functionality tested on real hardware or not.\n\nTo make checkpatch not complain I propose to get rid of VID, PID macros altogether and move vids/pids arrays to the beginning of the file and initialise them explicitely.","accounts_in_message":[],"_revision_number":1},{"id":"56db32d690ac1877f97a9305525ba3cb87b9cca9","author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"real_author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"date":"2013-05-24 15:46:01.000000000","message":"Patch Set 1: Abandoned\n\nOk.  I didn\u0027t like the way the IDs were written either but didn\u0027t think it was acceptable to change it while adding one ID.  I\u0027ll fix that and submit a new patch.  I\u0027d prefer that they\u0027re a proper array declaration with no null terminator and we use the typical ARRAY_SIZE() macro to determine the number of entries rather than looking for a null entry.\n\nThis version of jlink seems to work on the piece of hardware I mentioned in the commit message but I\u0027ll do some more testing to make sure I haven\u0027t missed something.","accounts_in_message":[],"_revision_number":1}],"current_revision":"41f737d399ceb16f64696178241549f6c7227a83","revisions":{"41f737d399ceb16f64696178241549f6c7227a83":{"kind":"REWORK","_number":1,"created":"2013-05-23 23:32:01.000000000","uploader":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"ref":"refs/changes/21/1421/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/1421/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/1421/1 \u0026\u0026 git checkout -b change-1421 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/1421/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/1421/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/1421/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/1421/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/1421/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"08ddb19fd3a708d21057c88e8b86215e04c781ec","subject":"Revert \"mpsse: Always perform a general reset of the MPSSE in mpsse_open()\""}],"author":{"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","date":"2013-05-23 23:23:28.000000000","tz":-420},"committer":{"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","date":"2013-05-23 23:31:37.000000000","tz":-420},"subject":"jlink: add PID for jlink included on SAM4 kits","message":"jlink: add PID for jlink included on SAM4 kits\n\nAdd one more USB PID, 0105, to the PID list for jlink.  This device is\nfound on Atmel\u0027s SAM4 development kits, for example the SAM4L-EK board.\n\nSigned-off-by: Andrey Yurovsky \u003cyurovsky@gmail.com\u003e\nChange-Id: I9947b465aef26519258027ff6c0ac9b15252fffd\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
