)]}'
{"id":"openocd~master~I44d3fc65916c131b7a226869dd16aed5afb441b4","project":"openocd","branch":"master","hashtags":[],"change_id":"I44d3fc65916c131b7a226869dd16aed5afb441b4","subject":"cortex_m: set fpb_enabled on enabling fpb","status":"MERGED","created":"2013-09-19 09:21:14.000000000","updated":"2013-10-29 22:55:04.000000000","submitted":"2013-10-29 22:55:04.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9e12ec2486e34807c41104ee6ce11e04d9366a8c","_number":1634,"owner":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2013-10-29 22:55:04.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2013-10-29 22:55:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":2,"date":"2013-10-29 22:55:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"date":"2013-10-29 22:55:04.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-09-20 21:07:38.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2013-10-29 22:51:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7b788f7a7c1d88ce618fb85739750ad4335a7060","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-09-19 09:32:18.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/3468/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2916/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2574a66e929358da6412699e08ff86e4ee1a145a","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2013-09-20 21:07:38.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b82f97cfaa820cd6ba7ee6daea5c022407eed5ca","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-09-25 13:44:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9c2746487e7303e8869eb8538ba202aaeb438453","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-09-25 13:57:21.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/3501/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/2949/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5be270edc4c0b104c251071da5194360c76157b5","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-10-29 22:28:24.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"20e399220b2758915c96432c83e4fcfa56c6b2dc","date":"2013-10-29 22:28:41.000000000","message":"Your change could not be merged due to a path conflict.\n\nPlease merge (or rebase) the change locally and upload the resolution for review.","accounts_in_message":[],"_revision_number":2},{"id":"91a938ebe6850cca31c4e768b13c76f1499a54bd","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-10-29 22:38:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ae19f9a0319edbc897af13971cd8bf4b3c418dc5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2013-10-29 22:51:25.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/3084/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/3638/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"6711c44704e68df41e4f9819a3402166cc452cc0","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-10-29 22:55:04.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"9e12ec2486e34807c41104ee6ce11e04d9366a8c","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2013-10-29 22:55:04.000000000","message":"Change has been successfully cherry-picked as 3b3e3f67c10cc458321eb9030b671a922eceb149","accounts_in_message":[],"_revision_number":4}],"current_revision":"3b3e3f67c10cc458321eb9030b671a922eceb149","revisions":{"d7ba7a3958a1dc3913e1270421218fecf57dd34c":{"kind":"REWORK","_number":2,"created":"2013-09-25 13:44:09.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/34/1634/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/1634/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/2 \u0026\u0026 git checkout -b change-1634 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/1634/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a8c547dd94f06872b3db62eb976be9614a0b421","subject":"hla: move memory read/write functionality to driver"}],"author":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-25 13:43:08.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-25 13:43:08.000000000","tz":60},"subject":"cortex_m: set fpb_enabled on enabling fpb","message":"cortex_m: set fpb_enabled on enabling fpb\n\nIf the fpb_enabled is not set then as part of cortex_m3_set_breakpoint we\nenable the fpb, however we do not signal the fpb as being enabled.\n\nThis issue only effects the hla target as the current cortex_m code enables\nthe fpb during cortex_m3_endreset_event.\n\nChange-Id: I44d3fc65916c131b7a226869dd16aed5afb441b4\nSigned-off-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"6ea4e38edfaf197915a98d33cde338d1bc303313":{"kind":"REWORK","_number":3,"created":"2013-10-29 22:38:46.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/34/1634/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/1634/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/3 \u0026\u0026 git checkout -b change-1634 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/1634/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a3d8312e757ade229d426b144b48f3673f41a3","subject":"armada370: initial support for Marvell Armada 370 family"}],"author":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-25 13:43:08.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-10-29 22:37:54.000000000","tz":0},"subject":"cortex_m: set fpb_enabled on enabling fpb","message":"cortex_m: set fpb_enabled on enabling fpb\n\nIf the fpb_enabled is not set then as part of cortex_m3_set_breakpoint we\nenable the fpb, however we do not signal the fpb as being enabled.\n\nThis issue only effects the hla target as the current cortex_m code enables\nthe fpb during cortex_m3_endreset_event.\n\nChange-Id: I44d3fc65916c131b7a226869dd16aed5afb441b4\nSigned-off-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"9490a7baec3f5dca481a97fc01b0ee92b5c8a7fe":{"kind":"REWORK","_number":1,"created":"2013-09-19 09:21:14.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/34/1634/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/1634/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/1 \u0026\u0026 git checkout -b change-1634 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/1634/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a8c547dd94f06872b3db62eb976be9614a0b421","subject":"hla: move memory read/write functionality to driver"}],"author":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-19 09:19:57.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-19 09:19:57.000000000","tz":60},"subject":"cortex_m: set fpb_enabled on enabling fpb","message":"cortex_m: set fpb_enabled on enabling fpb\n\nIf the fpb_enabled is not set then as part of cortex_m3_set_breakpoint we\nenable the fpb, however we do not signal the fpb as being enabled.\n\nThis issue only effects the hla target as the current cortex_m code enables\nthe fpb during cortex_m3_endreset_event.\n\nChange-Id: I44d3fc65916c131b7a226869dd16aed5afb441b4\nSigned-off-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"3b3e3f67c10cc458321eb9030b671a922eceb149":{"kind":"REWORK","_number":4,"created":"2013-10-29 22:55:04.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/34/1634/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/1634/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/4 \u0026\u0026 git checkout -b change-1634 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/1634/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/1634/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ebf1eb94d06f892d8699bb35a8af65c721b5f5f","subject":"hla/stlink: Re-order trace parameters to allow trace output file to be optional"}],"author":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-09-25 13:43:08.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2013-10-29 22:55:04.000000000","tz":0},"subject":"cortex_m: set fpb_enabled on enabling fpb","message":"cortex_m: set fpb_enabled on enabling fpb\n\nIf the fpb_enabled is not set then as part of cortex_m3_set_breakpoint we\nenable the fpb, however we do not signal the fpb as being enabled.\n\nThis issue only effects the hla target as the current cortex_m code enables\nthe fpb during cortex_m3_endreset_event.\n\nChange-Id: I44d3fc65916c131b7a226869dd16aed5afb441b4\nSigned-off-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\nReviewed-on: http://openocd.zylin.com/1634\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
