)]}'
{"src/svf/svf.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"14bf88a103e54d86d8010901831dfd08a05b5c83","unresolved":false,"context_lines":[{"line_number":249,"context_line":"\tsvf_hexbuf_print(LOG_LVL_##_lvl ,  __FILE__, __LINE__, __func__, _buf, _nbits, _desc)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"static void svf_hexbuf_print(int dbg_lvl, const char *file, unsigned line,"},{"line_number":252,"context_line":"\t\t\t     const char *function, uint8_t *buf, int bit_len, char *desc)"},{"line_number":253,"context_line":"{"},{"line_number":254,"context_line":"\tint j, i \u003d 1, len \u003d 0;"},{"line_number":255,"context_line":"\tint byte_len \u003d (bit_len + 7) \u003e\u003e 3;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c438bcff_805c567e","line":252,"range":{"start_line":252,"start_character":30,"end_line":252,"end_character":37},"updated":"2014-05-04 10:16:01.000000000","message":"I guess buf and desc should be const.","commit_id":"b9d20d042683a3ebd874446e18b233bfc6b7b6b0"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"14bf88a103e54d86d8010901831dfd08a05b5c83","unresolved":false,"context_lines":[{"line_number":252,"context_line":"\t\t\t     const char *function, uint8_t *buf, int bit_len, char *desc)"},{"line_number":253,"context_line":"{"},{"line_number":254,"context_line":"\tint j, i \u003d 1, len \u003d 0;"},{"line_number":255,"context_line":"\tint byte_len \u003d (bit_len + 7) \u003e\u003e 3;"},{"line_number":256,"context_line":"\tint msbits \u003d bit_len%8;"},{"line_number":257,"context_line":"\tchar *prbuf \u003d NULL;"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c438bcff_60615238","line":255,"updated":"2014-05-04 10:16:01.000000000","message":"Use DIV_ROUND_UP(bit_len, 8) instead. (Also it would be nice with spaces around the % below, minor detail)","commit_id":"b9d20d042683a3ebd874446e18b233bfc6b7b6b0"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"14bf88a103e54d86d8010901831dfd08a05b5c83","unresolved":false,"context_lines":[{"line_number":254,"context_line":"\tint j, i \u003d 1, len \u003d 0;"},{"line_number":255,"context_line":"\tint byte_len \u003d (bit_len + 7) \u003e\u003e 3;"},{"line_number":256,"context_line":"\tint msbits \u003d bit_len%8;"},{"line_number":257,"context_line":"\tchar *prbuf \u003d NULL;"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\t/* allocate space for print buffer"},{"line_number":260,"context_line":"\t   add extra 32 bytes for formating passed description */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c438bcff_c055be4f","line":257,"updated":"2014-05-04 10:16:01.000000000","message":"Don\u0027t initialize, or even better, declare at point of first use.","commit_id":"b9d20d042683a3ebd874446e18b233bfc6b7b6b0"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"14bf88a103e54d86d8010901831dfd08a05b5c83","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\t/* allocate space for print buffer"},{"line_number":260,"context_line":"\t   add extra 32 bytes for formating passed description */"},{"line_number":261,"context_line":"\tprbuf \u003d malloc(sizeof(desc) + byte_len + 32);"},{"line_number":262,"context_line":"\tif (!prbuf)"},{"line_number":263,"context_line":"\t\treturn;"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c438bcff_20674a51","line":261,"updated":"2014-05-04 10:16:01.000000000","message":"Multiple errors and oddities here...\n\nWhy sizeof(desc)?? A pointer tends to be either 4 or 8 bytes but I don\u0027t see anything printed that depends on that. I suspect you\u0027d want strlen(desc) instead... or rather \"desc ? strlen(desc) : 0\".\n\nYou allocate a byte for every 8 bits, but printing 8 bits in hex requires *two* chars...\n\nAnd what is supposed to be printed on the 32 extra bytes? I\u0027m guessing it\u0027s covering up for crashes due to the errors above. Of course, you\u0027ll need some extra space for \" \u003d \" and the \"%8\" padding below but it\u0027s better to be exact and catch bugs using valgrind.","commit_id":"b9d20d042683a3ebd874446e18b233bfc6b7b6b0"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"14bf88a103e54d86d8010901831dfd08a05b5c83","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"\t/* take care of most significant unaligned bit len */"},{"line_number":269,"context_line":"\tlen +\u003d sprintf(prbuf + len,"},{"line_number":270,"context_line":"\t\t       (msbits \u003e 4  || msbits \u003d\u003d 0) ? \"0x%02x\" : \"0x%01x\", buf[byte_len - i++]);"},{"line_number":271,"context_line":"\tfor (j \u003d byte_len - i; j \u003e\u003d 0; j--)"},{"line_number":272,"context_line":"\t\tlen +\u003d sprintf(prbuf + len, \"%02x\", buf[j]);"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c438bcff_a0523a63","line":270,"updated":"2014-05-04 10:16:01.000000000","message":"A good reason to treat the MSB specially is because it may contain garbage bits if msbits !\u003d 0. Other than that I can\u0027t really think of a reason.\n\nFor that, I don\u0027t think this quite does the trick. Consider the following instead (untested):\n\n uint8_t msb \u003d buf[byte_len - 1] \u0026 (msbits ? (1 \u003c\u003c msbits) - 1 : 0xff);\n len +\u003d sprintf(prbuf + len, \"0x%02\"PRIx8, msb);\n for (j \u003d byte_len - 2; j \u003e\u003d 0; j--)\n     len +\u003d sprintf(prbuf + len, \"%02\"PRIx8, buf[j]);","commit_id":"b9d20d042683a3ebd874446e18b233bfc6b7b6b0"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b1b6cd8355726d55a164f42e175568ff70b872db","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\tint msbits \u003d bit_len % 8;"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\t/* allocate for desc string and 2 bytes per hex digit */"},{"line_number":260,"context_line":"\tchar *prbuf \u003d malloc((desc ? strlen(desc) : 0) + (byte_len * 2) + 1);"},{"line_number":261,"context_line":"\tif (!prbuf)"},{"line_number":262,"context_line":"\t\treturn;"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c438bcff_80e616b1","line":260,"updated":"2014-05-05 19:24:43.000000000","message":"I guess you forgot to remove the desc calculation after you solved it in a better way below.","commit_id":"ac1cebc7b21a5f9230ac5c408f1b343dd8a40890"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"b1b6cd8355726d55a164f42e175568ff70b872db","unresolved":false,"context_lines":[{"line_number":267,"context_line":"\tfor (j \u003d byte_len - 2; j \u003e\u003d 0; j--)"},{"line_number":268,"context_line":"\t\tlen +\u003d sprintf(prbuf + len, \"%02\"PRIx8, buf[j]);"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"\tlog_printf_lf(dbg_lvl, file, line, function, \"%8s \u003d %s\", desc ? desc : \" \", prbuf);"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"\tfree(prbuf);"},{"line_number":273,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c438bcff_40ec0e95","line":270,"updated":"2014-05-05 19:24:43.000000000","message":"Oh, that\u0027s a nice solution.","commit_id":"ac1cebc7b21a5f9230ac5c408f1b343dd8a40890"}]}
