)]}'
{"id":"openocd~master~Ie89902403bdb61ff458418446c2ca1253ea2a63f","project":"openocd","branch":"master","hashtags":[],"change_id":"Ie89902403bdb61ff458418446c2ca1253ea2a63f","subject":"svf: Fix debug and error messages that print hex buffer","status":"MERGED","created":"2014-02-21 23:41:53.000000000","updated":"2014-05-05 20:25:10.000000000","submitted":"2014-05-05 20:25:10.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5b1bd64ff0e5a11be5378eda59fab79f07a6d179","_number":1964,"owner":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000162,"name":"simon qian","email":"openocd@versaloon.com","username":"versaloon"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},{"value":1,"date":"2014-05-05 20:25:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":0,"_account_id":1000162,"name":"simon qian","email":"openocd@versaloon.com","username":"versaloon"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2014-05-05 20:25:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000162,"name":"simon qian","email":"openocd@versaloon.com","username":"versaloon"},{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-28 14:37:43.000000000","updated_by":{"_account_id":1000162,"name":"simon qian","email":"openocd@versaloon.com","username":"versaloon"},"reviewer":{"_account_id":1000162,"name":"simon qian","email":"openocd@versaloon.com","username":"versaloon"},"state":"REVIEWER"},{"updated":"2014-04-24 17:20:42.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2014-05-05 20:12:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-05-05 20:25:10.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"a0353dcfe7a6a3733a7e63cc09b7b0e77a00838f","author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"real_author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"date":"2014-02-21 23:41:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e1846d30f746cf7aa66a916170e99d7ebebd04e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-02-21 23:53:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4037/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/3478/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"661b769b801b5c38de0ef346e2dce00f5f79f0b4","author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"real_author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"date":"2014-05-02 14:57:47.000000000","message":"Patch Set 1:\n\ncan you please review this change?\n\nThanks\nKamal","accounts_in_message":[],"_revision_number":1},{"id":"14bf88a103e54d86d8010901831dfd08a05b5c83","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-05-04 10:16:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)\n\nDespite the many inline comments, this is a significant improvement, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"982ab3d459720d51ea26fb72ebbde595db3ac309","author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"real_author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"date":"2014-05-05 18:54:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"38470de24a88293ca23ce5cdafe17470ba98ac97","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-05-05 19:11:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4413/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/3858/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b1b6cd8355726d55a164f42e175568ff70b872db","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-05-05 19:24:43.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nNice, just some odd leftover code you should remove, don\u0027t forget the comment.","accounts_in_message":[],"_revision_number":2},{"id":"c102bfaff98409a708a4ab57d78ab977d4faa8fc","author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"real_author":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"date":"2014-05-05 19:57:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"952637e00d8830b4313dd942d7c0c8fefb26e160","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-05-05 20:09:31.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"96c462ec03fd91ab371b171f7a9418d05bc2203f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-05-05 20:12:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4414/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/3859/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5b1bd64ff0e5a11be5378eda59fab79f07a6d179","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-05-05 20:25:10.000000000","message":"Change has been successfully cherry-picked as 2eb8a31a6bc91a645ed6aa06752835f4c61cd703","accounts_in_message":[],"_revision_number":4}],"current_revision":"2eb8a31a6bc91a645ed6aa06752835f4c61cd703","revisions":{"2eb8a31a6bc91a645ed6aa06752835f4c61cd703":{"kind":"REWORK","_number":4,"created":"2014-05-05 20:25:10.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/64/1964/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/1964/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/4 \u0026\u0026 git checkout -b change-1964 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/1964/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1beaa36e2d6ae6ffdf5bddbaae6ac165f984510","subject":"doc: document [start end] parameters of \"profile\" command"}],"author":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2013-12-03 21:15:42.000000000","tz":-300},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2014-05-05 20:25:10.000000000","tz":0},"subject":"svf: Fix debug and error messages that print hex buffer","message":"svf: Fix debug and error messages that print hex buffer\n\nAdded SVF_BUF_LOG macro to properly print the hex buffer of parsed\nstring for SIR, SDR, TDI, TDO and MASK. The original debug and error\nlogs with respect to printing real values were misleading and also\nhad endianess issues. All the bits are printed now instead of just\nu32 values.\n\nChange-Id: Ie89902403bdb61ff458418446c2ca1253ea2a63f\nSigned-off-by: Kamal Dasu \u003ckdasu.kdev@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/1964\nReviewed-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nTested-by: jenkins\n"}},"b9d20d042683a3ebd874446e18b233bfc6b7b6b0":{"kind":"REWORK","_number":1,"created":"2014-02-21 23:41:53.000000000","uploader":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"ref":"refs/changes/64/1964/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/1964/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/1 \u0026\u0026 git checkout -b change-1964 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/1964/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6c74255ee2569bf2748ecbbd252e2a91bbce6644","subject":"arm926ejs: fix write memory operations with caches enabled"}],"author":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2013-12-03 21:15:42.000000000","tz":-300},"committer":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2014-02-21 23:37:59.000000000","tz":-300},"subject":"svf: Fix debug and error messages that print hex buffer","message":"svf: Fix debug and error messages that print hex buffer\n\nAdded SVF_BUF_LOG macro to properly print the hex buffer of parsed\nstring for SIR, SDR, TDI, TDO and MASK. The original debug and error\nlogs with respect to printing real values were misleading and also\nhad endianess issues. All the bits are printed now instead of just\nu32 values.\n\nChange-Id: Ie89902403bdb61ff458418446c2ca1253ea2a63f\nSigned-off-by: Kamal Dasu \u003ckdasu.kdev@gmail.com\u003e\n"}},"ac1cebc7b21a5f9230ac5c408f1b343dd8a40890":{"kind":"REWORK","_number":2,"created":"2014-05-05 18:54:55.000000000","uploader":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"ref":"refs/changes/64/1964/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/1964/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/2 \u0026\u0026 git checkout -b change-1964 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/1964/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8fa67bd57dba0f43ead29fe26d10044b24023649","subject":"Restore normal development cycle"}],"author":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2013-12-03 21:15:42.000000000","tz":-300},"committer":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2014-05-05 18:53:43.000000000","tz":-240},"subject":"svf: Fix debug and error messages that print hex buffer","message":"svf: Fix debug and error messages that print hex buffer\n\nAdded SVF_BUF_LOG macro to properly print the hex buffer of parsed\nstring for SIR, SDR, TDI, TDO and MASK. The original debug and error\nlogs with respect to printing real values were misleading and also\nhad endianess issues. All the bits are printed now instead of just\nu32 values.\n\nChange-Id: Ie89902403bdb61ff458418446c2ca1253ea2a63f\nSigned-off-by: Kamal Dasu \u003ckdasu.kdev@gmail.com\u003e\n"}},"4376f783fdc819c0a5bce81f1fb505f438c01f92":{"kind":"REWORK","_number":3,"created":"2014-05-05 19:57:20.000000000","uploader":{"_account_id":1000213,"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","username":"kdasu.kdev"},"ref":"refs/changes/64/1964/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/1964/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/3 \u0026\u0026 git checkout -b change-1964 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/1964/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/1964/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8fa67bd57dba0f43ead29fe26d10044b24023649","subject":"Restore normal development cycle"}],"author":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2013-12-03 21:15:42.000000000","tz":-300},"committer":{"name":"Kamal Dasu","email":"kdasu.kdev@gmail.com","date":"2014-05-05 19:54:18.000000000","tz":-240},"subject":"svf: Fix debug and error messages that print hex buffer","message":"svf: Fix debug and error messages that print hex buffer\n\nAdded SVF_BUF_LOG macro to properly print the hex buffer of parsed\nstring for SIR, SDR, TDI, TDO and MASK. The original debug and error\nlogs with respect to printing real values were misleading and also\nhad endianess issues. All the bits are printed now instead of just\nu32 values.\n\nChange-Id: Ie89902403bdb61ff458418446c2ca1253ea2a63f\nSigned-off-by: Kamal Dasu \u003ckdasu.kdev@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
