)]}'
{"id":"openocd~master~I370e6199ac24f802426e9541e19ee38f18f1209a","project":"openocd","branch":"master","hashtags":[],"change_id":"I370e6199ac24f802426e9541e19ee38f18f1209a","subject":"interface/ftdi/xds100v2.cfg: Add another VID/PID, drop desc","status":"MERGED","created":"2014-03-03 21:07:46.000000000","updated":"2014-03-09 19:44:39.000000000","submitted":"2014-03-09 19:44:39.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d81693dadf894e87a8a7865aa0372d1981355906","_number":2016,"owner":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2014-03-09 19:44:39.000000000","_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"date":"2014-03-09 19:44:39.000000000","_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},{"value":1,"date":"2014-03-09 19:44:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":2,"date":"2014-03-09 19:44:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2014-03-09 19:44:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-03 21:34:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-03-04 05:19:17.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2014-03-07 19:49:16.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"e42fe796efad4cb74447b2cc02b152640023e037","author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"real_author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"date":"2014-03-03 21:07:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb1b76f813d5b4beaeb8b7e533cf6af574039a47","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-03-03 21:34:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/3536/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4096/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bf898a998fc04ac6a573cc6d64972074a7cfe77c","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2014-03-04 05:19:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c60aebf64f23497f3702570039266813107f63cc","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-03-07 19:49:16.000000000","message":"Patch Set 1:\n\nA problem is that this will happily open connected FTDI-based USB\u003c-\u003eserial adapters that have nothing to do with JTAG.","accounts_in_message":[],"_revision_number":1},{"id":"604bcf784f4d732f1bffbb0c75947b2edbcb1926","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2014-03-07 19:54:29.000000000","message":"Patch Set 1:\n\nBut many jtag adapters come with default ftdi usb descriptor, or is it not so?","accounts_in_message":[],"_revision_number":1},{"id":"63e8f303ba2167d787bbf8dff9aed05b0e7d6425","author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"real_author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"date":"2014-03-07 20:20:09.000000000","message":"Patch Set 1:\n\nThe problem is that indeed, many devices don\u0027t update the description.  Beaglebone White is 0x0403/0xa6d0 but other TI EVMs are 0x0403/0x6010, and in both cases are just generic FTDI descriptions.  The match on non-JTAG should be fine as we then try and talk with the device, see that there\u0027s no JTAG on the other side wired up anywhere and move on, yes?","accounts_in_message":[],"_revision_number":1},{"id":"b1c9925541bdaba88e1de884b9372fe850700ae4","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-03-07 21:06:10.000000000","message":"Patch Set 1:\n\nPerhaps we should have a separate xds100v2_evm.cfg with the default pid and no desc, to be sourced from the relevant board files?","accounts_in_message":[],"_revision_number":1},{"id":"f9b0c93d1d2e88152710195b766b12d833654a66","author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"real_author":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"date":"2014-03-08 12:54:49.000000000","message":"Patch Set 1:\n\nAndreas, would you mind summarizing where we\u0027re at after talking on irc a bit?  Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"729c3d39af513d7e289da918c29b1e6251649dd6","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-03-08 14:40:58.000000000","message":"Patch Set 1: Code-Review+2\n\nI guess this is the best we can do currently. It should be safe for users of standalone adapters because the custom pid is tried first. For embedded adapters with the original vid:pid it may or may not work if another device with the same id is connected, depending on which one is returned first from libusb. That\u0027s nothing we can do anything about in OpenOCD.","accounts_in_message":[],"_revision_number":1},{"id":"d81693dadf894e87a8a7865aa0372d1981355906","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-03-09 19:44:39.000000000","message":"Change has been successfully cherry-picked as bbf26e886a6647dbe0f7fe8b276e13e8e49b9d5a","accounts_in_message":[],"_revision_number":2}],"current_revision":"bbf26e886a6647dbe0f7fe8b276e13e8e49b9d5a","revisions":{"35d775e0249f4741db2e6bb65d06d320f9c310a6":{"kind":"REWORK","_number":1,"created":"2014-03-03 21:07:46.000000000","uploader":{"_account_id":1000202,"name":"Tom Rini","email":"trini@konsulko.com","username":"trini"},"ref":"refs/changes/16/2016/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/2016/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/1 \u0026\u0026 git checkout -b change-2016 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/2016/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"163fadff53a55c5e0fb98d1ef0e3a01fe6365870","subject":"tcl: target: icepick: add icepick_d_tapenable procedure"}],"author":{"name":"Tom Rini","email":"trini@ti.com","date":"2014-03-03 20:14:47.000000000","tz":-300},"committer":{"name":"Tom Rini","email":"trini@ti.com","date":"2014-03-03 21:06:30.000000000","tz":-300},"subject":"interface/ftdi/xds100v2.cfg: Add another VID/PID, drop desc","message":"interface/ftdi/xds100v2.cfg: Add another VID/PID, drop desc\n\nThe XDS100v2 is often embedded in a number of platforms using the\nVID/PID of 0x0403/0x6010 and a generic FTDI device description.  Add\nthis VID/PID combination and remove the description line.\n\nChange-Id: I370e6199ac24f802426e9541e19ee38f18f1209a\nSigned-off-by: Tom Rini \u003ctrini@ti.com\u003e\n"}},"bbf26e886a6647dbe0f7fe8b276e13e8e49b9d5a":{"kind":"REWORK","_number":2,"created":"2014-03-09 19:44:39.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/16/2016/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/2016/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/2 \u0026\u0026 git checkout -b change-2016 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/2016/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/2016/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"17fddb4289cb632a414d9780b3c2e60e368fa083","subject":"stlink: Use callback to increase frequency of trace data sampling"}],"author":{"name":"Tom Rini","email":"trini@ti.com","date":"2014-03-03 20:14:47.000000000","tz":-300},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2014-03-09 19:44:39.000000000","tz":0},"subject":"interface/ftdi/xds100v2.cfg: Add another VID/PID, drop desc","message":"interface/ftdi/xds100v2.cfg: Add another VID/PID, drop desc\n\nThe XDS100v2 is often embedded in a number of platforms using the\nVID/PID of 0x0403/0x6010 and a generic FTDI device description.  Add\nthis VID/PID combination and remove the description line.\n\nChange-Id: I370e6199ac24f802426e9541e19ee38f18f1209a\nSigned-off-by: Tom Rini \u003ctrini@ti.com\u003e\nReviewed-on: http://openocd.zylin.com/2016\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}