)]}'
{"id":"openocd~master~I1ba25a946f0d80872cbd96ddcc48f92695c4ae20","project":"openocd","branch":"master","hashtags":[],"change_id":"I1ba25a946f0d80872cbd96ddcc48f92695c4ae20","subject":"target: Remove \"-variant\" argument","status":"MERGED","created":"2014-09-08 20:13:18.000000000","updated":"2014-09-22 19:39:24.000000000","submitted":"2014-09-22 19:39:24.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"43801aa06e5fe90dffde6934c42a3af9c6f8d161","_number":2283,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"date":"2014-09-22 19:39:24.000000000","_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2014-09-22 19:39:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":2,"date":"2014-09-22 19:39:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-08 20:30:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-09-22 19:39:24.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"b1a30b6f4fbf18f1f03ae4816afce04084dfa3df","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-09-08 20:13:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f0e8603bc20cdf941f7996168501dab3bdf0fb6c","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2014-09-08 20:14:28.000000000","message":"Patch Set 1:\n\nJust some cleaning frenzy.\n\nIf someone feels nostalgic about this \"feature\" I don\u0027t particularly mind keeping it.","accounts_in_message":[],"_revision_number":1},{"id":"1d571fcf45e478fe9fe5a666027460b2b05b9b71","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-09-08 20:30:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/4278/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4834/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b4e5df89d0cf635abc70cba1e7d4d11121790a4f","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-09-13 08:41:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"43801aa06e5fe90dffde6934c42a3af9c6f8d161","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-09-22 19:39:24.000000000","message":"Change has been successfully cherry-picked as 1c021ed0afb5f9f7d9e8cbce53a4fe985a4c2235","accounts_in_message":[],"_revision_number":2}],"current_revision":"1c021ed0afb5f9f7d9e8cbce53a4fe985a4c2235","revisions":{"1c021ed0afb5f9f7d9e8cbce53a4fe985a4c2235":{"kind":"REWORK","_number":2,"created":"2014-09-22 19:39:24.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/83/2283/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/2283/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/2 \u0026\u0026 git checkout -b change-2283 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/2283/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2973be9cc3538026c837d1122ab344cebb40aa0","subject":"mpsse: Display libusb error names instead of numbers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2014-09-08 20:11:02.000000000","tz":120},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2014-09-22 19:39:24.000000000","tz":0},"subject":"target: Remove \"-variant\" argument","message":"target: Remove \"-variant\" argument\n\nRemove this underutilized feature. Despite the fact that a lot of configs\nspecifies a arbitrary \"variant\", only the xscale target actually defines\nany.\n\nIn the case of xscale, the use of -variant is dubious since\n\n1) it\u0027s used as a redundant irlen specifier,\n2) it carries a comment that it doesn\u0027t really need it and\n3) only two xscale configs even specify it.\n\nIf there\u0027s a future target that needs a variant set, a target specific\noption could be added when needed.\n\nChange-Id: I1ba25a946f0d80872cbd96ddcc48f92695c4ae20\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/2283\nTested-by: jenkins\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"ebd0a3dc6f3389a7112d676bcb383a6d92950718":{"kind":"REWORK","_number":1,"created":"2014-09-08 20:13:18.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/83/2283/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/2283/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/1 \u0026\u0026 git checkout -b change-2283 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/2283/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/2283/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bd0409aa938875ea5a8d8235f8996116be171b69","subject":"jtag: always configure enabled tap parameter appropriately"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2014-09-08 20:11:02.000000000","tz":120},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2014-09-08 20:11:02.000000000","tz":120},"subject":"target: Remove \"-variant\" argument","message":"target: Remove \"-variant\" argument\n\nRemove this underutilized feature. Despite the fact that a lot of configs\nspecifies a arbitrary \"variant\", only the xscale target actually defines\nany.\n\nIn the case of xscale, the use of -variant is dubious since\n\n1) it\u0027s used as a redundant irlen specifier,\n2) it carries a comment that it doesn\u0027t really need it and\n3) only two xscale configs even specify it.\n\nIf there\u0027s a future target that needs a variant set, a target specific\noption could be added when needed.\n\nChange-Id: I1ba25a946f0d80872cbd96ddcc48f92695c4ae20\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}