)]}'
{"src/flash/nor/stm32lx.c":[{"author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"change_message_id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tif (CMD_ARGC \u003c 1) {"},{"line_number":249,"context_line":"\t\tcommand_print(CMD_CTX, \"stm32lx mass_erase \u003cbank\u003e\");"},{"line_number":250,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":251,"context_line":"\t}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_c3ff8a32","line":250,"updated":"2014-10-02 00:15:12.000000000","message":"The error message isn\u0027t needed if .usage is filled out, returning ERROR_COMMAND_SYNTAX_ERROR should trigger printing .usage","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tif (CMD_ARGC \u003c 1) {"},{"line_number":249,"context_line":"\t\tcommand_print(CMD_CTX, \"stm32lx mass_erase \u003cbank\u003e\");"},{"line_number":250,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":251,"context_line":"\t}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_43beda64","line":250,"in_reply_to":"643f10e9_c3ff8a32","updated":"2014-10-02 08:08:59.000000000","message":"Done","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"change_message_id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","unresolved":false,"context_lines":[{"line_number":880,"context_line":"static const struct command_registration stm32lx_exec_command_handlers[] \u003d {"},{"line_number":881,"context_line":"\t{"},{"line_number":882,"context_line":"\t\t.name \u003d \"mass_erase\","},{"line_number":883,"context_line":"\t\t.handler \u003d stm32lx_handle_mass_erase_command,"},{"line_number":884,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":885,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":886,"context_line":"\t\t.help \u003d \"Erase entire flash device. Erase also the EEPROM\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_63eb167b","line":883,"updated":"2014-10-02 00:15:12.000000000","message":"Should we provide .usage as well?","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","unresolved":false,"context_lines":[{"line_number":880,"context_line":"static const struct command_registration stm32lx_exec_command_handlers[] \u003d {"},{"line_number":881,"context_line":"\t{"},{"line_number":882,"context_line":"\t\t.name \u003d \"mass_erase\","},{"line_number":883,"context_line":"\t\t.handler \u003d stm32lx_handle_mass_erase_command,"},{"line_number":884,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":885,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":886,"context_line":"\t\t.help \u003d \"Erase entire flash device. Erase also the EEPROM\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_23c3cef0","line":883,"in_reply_to":"643f10e9_63eb167b","updated":"2014-10-02 08:08:59.000000000","message":"It already has a usage field.","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"change_message_id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","unresolved":false,"context_lines":[{"line_number":883,"context_line":"\t\t.handler \u003d stm32lx_handle_mass_erase_command,"},{"line_number":884,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":885,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":886,"context_line":"\t\t.help \u003d \"Erase entire flash device. Erase also the EEPROM\","},{"line_number":887,"context_line":"\t},"},{"line_number":888,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":889,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_83e622b1","line":886,"updated":"2014-10-02 00:15:12.000000000","message":"Grammar.  How about \"Erase the entire Flash including EEPROM, if any\"?","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","unresolved":false,"context_lines":[{"line_number":883,"context_line":"\t\t.handler \u003d stm32lx_handle_mass_erase_command,"},{"line_number":884,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":885,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":886,"context_line":"\t\t.help \u003d \"Erase entire flash device. Erase also the EEPROM\","},{"line_number":887,"context_line":"\t},"},{"line_number":888,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":889,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_83b8e275","line":886,"in_reply_to":"643f10e9_83e622b1","updated":"2014-10-02 08:08:59.000000000","message":"Done","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"change_message_id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"\treturn target_read_u32(target, stm32lx_info-\u003eflash_base + FLASH_SR, status);"},{"line_number":1108,"context_line":"}"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"static int stm32lx_wait_until_bsy_clear(struct flash_bank *bank)"},{"line_number":1112,"context_line":"{"},{"line_number":1113,"context_line":"\tstruct target *target \u003d bank-\u003etarget;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_a3fcfe3e","line":1110,"updated":"2014-10-02 00:15:12.000000000","message":"extra newline here","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"\treturn target_read_u32(target, stm32lx_info-\u003eflash_base + FLASH_SR, status);"},{"line_number":1108,"context_line":"}"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"static int stm32lx_wait_until_bsy_clear(struct flash_bank *bank)"},{"line_number":1112,"context_line":"{"},{"line_number":1113,"context_line":"\tstruct target *target \u003d bank-\u003etarget;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_63bdd663","line":1110,"in_reply_to":"643f10e9_a3fcfe3e","updated":"2014-10-02 08:08:59.000000000","message":"Done","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"change_message_id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"\treturn retval;"},{"line_number":1145,"context_line":"}"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"/* Static methods for mass erase stuff implementation */"},{"line_number":1148,"context_line":"static int stm32lx_unlock_options_bytes(struct flash_bank *bank)"},{"line_number":1149,"context_line":"{"},{"line_number":1150,"context_line":"\tstruct target *target \u003d bank-\u003etarget;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_03fa1241","line":1147,"updated":"2014-10-02 00:15:12.000000000","message":"This comment seems like noise","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"},{"author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"change_message_id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"\treturn retval;"},{"line_number":1145,"context_line":"}"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"/* Static methods for mass erase stuff implementation */"},{"line_number":1148,"context_line":"static int stm32lx_unlock_options_bytes(struct flash_bank *bank)"},{"line_number":1149,"context_line":"{"},{"line_number":1150,"context_line":"\tstruct target *target \u003d bank-\u003etarget;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"643f10e9_c3b14a8f","line":1147,"in_reply_to":"643f10e9_03fa1241","updated":"2014-10-02 08:08:59.000000000","message":"Done","commit_id":"0c989624dc4f7987febe852c35fcaa42f255752c"}]}
