)]}'
{"id":"openocd~master~I6a1d7a3669789aea89c59a006ab2d883f3d827ca","project":"openocd","branch":"master","hashtags":[],"change_id":"I6a1d7a3669789aea89c59a006ab2d883f3d827ca","subject":"stm32: add mass erase support for STM32L","status":"MERGED","created":"2014-09-25 18:37:44.000000000","updated":"2014-10-06 18:41:30.000000000","submitted":"2014-10-06 18:41:30.000000000","submitter":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ebcb759f4f29cbb6006ab94a4a0cf9ad040dc1c2","_number":2319,"owner":{"_account_id":1000691,"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","username":"remi205"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},{"value":0,"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":1,"date":"2014-10-06 18:41:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":1,"date":"2014-10-06 18:41:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},{"value":2,"date":"2014-10-06 18:41:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-02 08:45:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-02 14:06:51.000000000","updated_by":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"reviewer":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"state":"REVIEWER"},{"updated":"2014-10-06 18:41:30.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"}],"messages":[{"id":"9d11ff2e33e71a41a9ac40fc9597807d204d4b7f","author":{"_account_id":1000691,"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","username":"remi205"},"real_author":{"_account_id":1000691,"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","username":"remi205"},"date":"2014-09-25 18:37:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"895978f977f5846fae6e6b8ce01c103dd02ec9de","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-09-25 18:38:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/4344/ : FAILURE\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4900/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"e5b19cf89f4131d10e8ac53ac48b9f39c50cd3e5","author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"real_author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"date":"2014-09-25 19:18:45.000000000","message":"Patch Set 1: Code-Review-1\n\nYou\u0027ve caused whitespace damage to pretty much the entire file with this patch.  Please configure your text editor properly (or use a different one) and please read HACKING, especially the note about using tools/checkpatch.pl to catch some of this stuff.","accounts_in_message":[],"_revision_number":1},{"id":"9f4b80f66769536a20b2154073c8d4fa113d01f3","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-01 22:10:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dbdc2c3f8d8f7b94889720a600fb9ff1bf7452d9","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-01 22:18:10.000000000","message":"Patch Set 2:\n\nRémi I have cleaned up this patch series, are you able to retest to check nothing has broken.\n\nFor info you really should read the guidelines - http://openocd.sourceforge.net/doc/doxygen/html/patchguide.html. As your original patches contained many problems. Feel vfree to ask if you have any questions on patches or using git.","accounts_in_message":[],"_revision_number":2},{"id":"5320a408600f9e6558cc50ea5688f2213039ef88","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-10-01 22:43:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/4358/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4914/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"72cfcc39bb45a2cadeea0a4a5aefd6d76fec86c6","author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"real_author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"date":"2014-10-02 00:15:12.000000000","message":"Patch Set 2:\n\n(5 comments)\n\nSeems nice aside from some minor comments.","accounts_in_message":[],"_revision_number":2},{"id":"d740031fef6301ac37a7326c9cd2b4e9150ec16f","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-02 08:08:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d1305f8d92878a4bdd21cf40a52e87d7b54ff6f3","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-02 08:08:59.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"50e1cb94c0ee47a7424f852b7fd2fd50430be5e0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2014-10-02 08:45:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/4362/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/4918/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"51b30dae2e46200f108c9353841d3658f2d5e375","author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"real_author":{"_account_id":1000433,"name":"Andrey Yurovsky","email":"yurovsky@gmail.com","username":"andrey"},"date":"2014-10-02 14:06:51.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"03a032ae52118b935592cf128f14519ae91f5f92","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-06 12:00:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ebcb759f4f29cbb6006ab94a4a0cf9ad040dc1c2","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2014-10-06 18:41:30.000000000","message":"Change has been successfully cherry-picked as 832f0a5bfb439ed9b6e16df69c4dd95e001db015","accounts_in_message":[],"_revision_number":4}],"current_revision":"832f0a5bfb439ed9b6e16df69c4dd95e001db015","revisions":{"832f0a5bfb439ed9b6e16df69c4dd95e001db015":{"kind":"REWORK","_number":4,"created":"2014-10-06 18:41:30.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/19/2319/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/2319/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/4 \u0026\u0026 git checkout -b change-2319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/2319/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b55ca1ad27d39cef37a9dc1801fc2706a26d63f7","subject":"stm32: Add config file for a new board STM32L052 dsicovery"}],"author":{"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","date":"2014-10-01 21:43:03.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2014-10-06 18:41:30.000000000","tz":0},"subject":"stm32: add mass erase support for STM32L","message":"stm32: add mass erase support for STM32L\n\nThe mass erase for STM32L was lack because the procedure is more complex\nthan the procedure for the STM32F4xx.\n\nThe reference manual RM0038 (L100 subfamily) page 79 is more accurate\nthan the reference manual for the STM32L0xx. On the L0, the mass-erase\nerase also the EEPROM. This is a limit to mass erase on L0.\n\nThe mass erase procedure is a command of telnet interface.\n\nTested on Discovery L053 and Discovery L100.\n\nChange-Id: I6a1d7a3669789aea89c59a006ab2d883f3d827ca\nSigned-off-by: Rémi PRUD\u0027HOMME \u003cprudhomme.remi@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/2319\nTested-by: jenkins\nReviewed-by: Andrey Yurovsky \u003cyurovsky@gmail.com\u003e\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}},"c7245db0c41eb5644f871097a32a514bf39f9f2c":{"kind":"REWORK","_number":1,"created":"2014-09-25 18:37:44.000000000","uploader":{"_account_id":1000691,"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","username":"remi205"},"ref":"refs/changes/19/2319/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/2319/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/1 \u0026\u0026 git checkout -b change-2319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/2319/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20378951655f83641851fb55a732a234dfa6c835","subject":"Add config file for a new board STM32L052 dsicovery"}],"author":{"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","date":"2014-09-25 18:33:16.000000000","tz":120},"committer":{"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","date":"2014-09-25 18:33:16.000000000","tz":120},"subject":"add new feature for STM32L  : mass erase","message":"add new feature for STM32L  : mass erase\n\nThe mass erase for STM32L was lack because the procedure is more complexe than the procedure\nfor the STM32F4xx.\nThe reference manual RM0038 (L100 subfamily ) page 79 is more accurate than the reference\nmanual for the STM32L0xx. On the L0, the mass-erase erase also the EEPROM. This is a limit\nto mass erase on L0\n\nThe mass erase procedure is a command of telnet interface.\n\nTested on Discovery L053 and Discovery L100.\n\nChange-Id: I6a1d7a3669789aea89c59a006ab2d883f3d827ca\nSigned-off-by: Rémi PRUD\u0027HOMME \u003cprudhomme.remi@gmail.com\u003e\n"}},"0c989624dc4f7987febe852c35fcaa42f255752c":{"kind":"REWORK","_number":2,"created":"2014-10-01 22:10:53.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/19/2319/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/2319/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/2 \u0026\u0026 git checkout -b change-2319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/2319/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f6a72f3ae394b1d830c2cccd5c75449df280982","subject":"stm32: Add config file for a new board STM32L052 dsicovery"}],"author":{"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","date":"2014-10-01 21:43:03.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2014-10-01 22:06:25.000000000","tz":60},"subject":"stm32: add mass erase support for STM32L","message":"stm32: add mass erase support for STM32L\n\nThe mass erase for STM32L was lack because the procedure is more complex\nthan the procedure for the STM32F4xx.\n\nThe reference manual RM0038 (L100 subfamily) page 79 is more accurate\nthan the reference manual for the STM32L0xx. On the L0, the mass-erase\nerase also the EEPROM. This is a limit to mass erase on L0.\n\nThe mass erase procedure is a command of telnet interface.\n\nTested on Discovery L053 and Discovery L100.\n\nChange-Id: I6a1d7a3669789aea89c59a006ab2d883f3d827ca\nSigned-off-by: Rémi PRUD\u0027HOMME \u003cprudhomme.remi@gmail.com\u003e\n"}},"033b08b4110a536d38414cb790e4ad3a80a4a6e9":{"kind":"REWORK","_number":3,"created":"2014-10-02 08:08:06.000000000","uploader":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"ref":"refs/changes/19/2319/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/2319/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/3 \u0026\u0026 git checkout -b change-2319 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/2319/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/2319/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"37b25416d51a0d81c22d95dd2f22f6e214167760","subject":"stm32: Add config file for a new board STM32L052 dsicovery"}],"author":{"name":"Rémi PRUD\u0027HOMME","email":"prudhomme.remi@gmail.com","date":"2014-10-01 21:43:03.000000000","tz":60},"committer":{"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","date":"2014-10-02 08:07:19.000000000","tz":60},"subject":"stm32: add mass erase support for STM32L","message":"stm32: add mass erase support for STM32L\n\nThe mass erase for STM32L was lack because the procedure is more complex\nthan the procedure for the STM32F4xx.\n\nThe reference manual RM0038 (L100 subfamily) page 79 is more accurate\nthan the reference manual for the STM32L0xx. On the L0, the mass-erase\nerase also the EEPROM. This is a limit to mass erase on L0.\n\nThe mass erase procedure is a command of telnet interface.\n\nTested on Discovery L053 and Discovery L100.\n\nChange-Id: I6a1d7a3669789aea89c59a006ab2d883f3d827ca\nSigned-off-by: Rémi PRUD\u0027HOMME \u003cprudhomme.remi@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
