)]}'
{"src/target/mips64.c":[{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"\treturn ERROR_OK;"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"int mips64_get_gdb_reg_list(struct target *target, struct reg **reg_list[],"},{"line_number":238,"context_line":"\tint *reg_list_size, enum target_register_class reg_class)"},{"line_number":239,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_86111006","line":236,"updated":"2014-10-07 04:54:27.000000000","message":"extra empty line","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"\t\treturn retval;"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\tfor (i \u003d 0; i \u003c MIPS64NUMCOREREGS; i++) {"},{"line_number":268,"context_line":"\t\t\tretval \u003d mips64-\u003eread_core_reg(target, i);"},{"line_number":269,"context_line":"\t}"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_665b24f5","line":268,"updated":"2014-10-07 04:54:27.000000000","message":"extra indent","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":433,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":434,"context_line":"\t\treturn retval;"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"\tif (dcr \u0026 (1 \u003c\u003c 16)) {"},{"line_number":437,"context_line":"\t\t/* get number of inst breakpoints */"},{"line_number":438,"context_line":"\t\tretval \u003d target_read_u64(target, EJTAG64_V25_IBS, \u0026bpinfo);"},{"line_number":439,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_460708cd","line":436,"updated":"2014-10-07 04:54:27.000000000","message":"Can we use EJTAG_DCR_IB here as src/target/mips32.c does?","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":451,"context_line":"\t\t\treturn retval;"},{"line_number":452,"context_line":"\t}"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"\tif (dcr \u0026 (1 \u003c\u003c 17)) {"},{"line_number":455,"context_line":"\t\t/* get number of data breakpoints */"},{"line_number":456,"context_line":"\t\tretval \u003d target_read_u64(target, EJTAG64_V25_DBS, \u0026bpinfo);"},{"line_number":457,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_260c7cef","line":454,"updated":"2014-10-07 04:54:27.000000000","message":"EJTAG_DCR_DB","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":488,"context_line":"\t\treturn retval;"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"\tif (enable) {"},{"line_number":491,"context_line":"\t\tif (!(dcr \u0026 (1 \u003c\u003c 4))) {"},{"line_number":492,"context_line":"\t\t\t/* enable interrupts */"},{"line_number":493,"context_line":"\t\t\tdcr |\u003d (1 \u003c\u003c 4);"},{"line_number":494,"context_line":"\t\t\tupdate \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_c66f9894","line":491,"updated":"2014-10-07 04:54:27.000000000","message":"EJTAG_DCR_INTE","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":490,"context_line":"\tif (enable) {"},{"line_number":491,"context_line":"\t\tif (!(dcr \u0026 (1 \u003c\u003c 4))) {"},{"line_number":492,"context_line":"\t\t\t/* enable interrupts */"},{"line_number":493,"context_line":"\t\t\tdcr |\u003d (1 \u003c\u003c 4);"},{"line_number":494,"context_line":"\t\t\tupdate \u003d 1;"},{"line_number":495,"context_line":"\t\t}"},{"line_number":496,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_e66614bd","line":493,"updated":"2014-10-07 04:54:27.000000000","message":"EJTAG_DCR_INTE","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":494,"context_line":"\t\t\tupdate \u003d 1;"},{"line_number":495,"context_line":"\t\t}"},{"line_number":496,"context_line":"\t} else {"},{"line_number":497,"context_line":"\t\tif (dcr \u0026 (1 \u003c\u003c 4))\t{"},{"line_number":498,"context_line":"\t\t\t/* disable interrupts */"},{"line_number":499,"context_line":"\t\t\tdcr \u0026\u003d ~(1 \u003c\u003c 4);"},{"line_number":500,"context_line":"\t\t\tupdate \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_a66c0ca1","line":497,"updated":"2014-10-07 04:54:27.000000000","message":"EJTAG_DCR_INTE","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000580,"name":"Antony Pavlov","email":"antonynpavlov@gmail.com","username":"frantony"},"change_message_id":"96fa7d02b23e9ef811380d4a519f665e022774b9","unresolved":false,"context_lines":[{"line_number":496,"context_line":"\t} else {"},{"line_number":497,"context_line":"\t\tif (dcr \u0026 (1 \u003c\u003c 4))\t{"},{"line_number":498,"context_line":"\t\t\t/* disable interrupts */"},{"line_number":499,"context_line":"\t\t\tdcr \u0026\u003d ~(1 \u003c\u003c 4);"},{"line_number":500,"context_line":"\t\t\tupdate \u003d 1;"},{"line_number":501,"context_line":"\t\t}"},{"line_number":502,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"643f10e9_066a2083","line":499,"updated":"2014-10-07 04:54:27.000000000","message":"EJTAG_DCR_INTE","commit_id":"e09de7987c614f43a8903edb763387b4267b62aa"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"2a75abc3556cc856a2ffa74bbbe4ddbef5119b09","unresolved":false,"context_lines":[{"line_number":491,"context_line":"\t\treturn retval;"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"\tif (enable) {"},{"line_number":494,"context_line":"\t\tif (!(dcr \u0026 (1 \u003c\u003c 4))) {"},{"line_number":495,"context_line":"\t\t\t/* enable interrupts */"},{"line_number":496,"context_line":"\t\t\tdcr |\u003d (1 \u003c\u003c 4);"},{"line_number":497,"context_line":"\t\t\tupdate \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"44292c1e_f44c58a1","line":494,"updated":"2015-06-08 18:31:45.000000000","message":"Ignored comments from previous review. Please use defines instead of magic numbers.","commit_id":"a1b7e8c32db02c7ccd4ff468d3f0ee0c5d0e2512"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"int mips64_save_context(struct target *target)"},{"line_number":260,"context_line":"{"},{"line_number":261,"context_line":"\tunsigned i;"},{"line_number":262,"context_line":"\tint retval;"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"\t/* get pointers to arch-specific information */"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_b450a0da","line":261,"updated":"2019-03-12 20:10:17.000000000","message":"Move variable into loop?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"int mips64_restore_context(struct target *target)"},{"line_number":280,"context_line":"{"},{"line_number":281,"context_line":"\tunsigned i;"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* get pointers to arch-specific information */"},{"line_number":284,"context_line":"\tstruct mips64_common *mips64 \u003d target-\u003earch_info;"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_d44d1441","line":281,"updated":"2019-03-12 20:10:17.000000000","message":"Same","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":385,"context_line":"\tmips64-\u003ecommon_magic \u003d MIPS64_COMMON_MAGIC;"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"\t/* has breakpoint/watchpint unit been scanned */"},{"line_number":388,"context_line":"\tmips64-\u003ebp_scanned \u003d 0;"},{"line_number":389,"context_line":"\tmips64-\u003edata_break_list \u003d NULL;"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"\tmips64-\u003eejtag_info.tap \u003d tap;"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_745a08fb","line":388,"updated":"2019-03-12 20:10:17.000000000","message":"bool?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":484,"context_line":"int mips64_enable_interrupts(struct target *target, int enable)"},{"line_number":485,"context_line":"{"},{"line_number":486,"context_line":"\tint retval;"},{"line_number":487,"context_line":"\tint update \u003d 0;"},{"line_number":488,"context_line":"\tuint64_t dcr;"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"\t/* read debug control register */"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_945f9ce8","line":487,"updated":"2019-03-12 20:10:17.000000000","message":"bool?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"2134be587cd70505d3044abaf7dec81690d79567","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"static uint8_t mips32_gdb_dummy_fp_value[] \u003d {0, 0, 0, 0};"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"int mips64_get_core_reg(struct reg *reg)"},{"line_number":209,"context_line":"{"},{"line_number":210,"context_line":"\tint retval;"},{"line_number":211,"context_line":"\tstruct mips64_core_reg *mips64_reg \u003d reg-\u003earch_info;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_dc0f853a","line":208,"updated":"2019-07-07 11:58:43.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"2134be587cd70505d3044abaf7dec81690d79567","unresolved":false,"context_lines":[{"line_number":220,"context_line":"\treturn retval;"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"int mips64_set_core_reg(struct reg *reg, uint8_t *buf)"},{"line_number":224,"context_line":"{"},{"line_number":225,"context_line":"\tstruct mips64_core_reg *mips64_reg \u003d reg-\u003earch_info;"},{"line_number":226,"context_line":"\tstruct target *target \u003d mips64_reg-\u003etarget;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_fc0cc147","line":223,"updated":"2019-07-07 11:58:43.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"2134be587cd70505d3044abaf7dec81690d79567","unresolved":false,"context_lines":[{"line_number":236,"context_line":"\treturn ERROR_OK;"},{"line_number":237,"context_line":"}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"int mips64_read_core_reg(struct target *target, int num)"},{"line_number":240,"context_line":"{"},{"line_number":241,"context_line":"\tuint64_t reg_value;"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_9c090d37","line":239,"updated":"2019-07-07 11:58:43.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"2134be587cd70505d3044abaf7dec81690d79567","unresolved":false,"context_lines":[{"line_number":254,"context_line":"\treturn ERROR_OK;"},{"line_number":255,"context_line":"}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"int mips64_write_core_reg(struct target *target, int num)"},{"line_number":258,"context_line":"{"},{"line_number":259,"context_line":"\tuint64_t reg_value;"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_bc064922","line":257,"updated":"2019-07-07 11:58:43.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":364,"context_line":"\tstruct reg_cache **cache_p \u003d register_get_last_cache_p(\u0026target-\u003ereg_cache);"},{"line_number":365,"context_line":"\tstruct reg_cache *cache \u003d malloc(sizeof(struct reg_cache));"},{"line_number":366,"context_line":"\tstruct reg *reg_list \u003d malloc(sizeof(struct reg) * num_regs);"},{"line_number":367,"context_line":"\tstruct mips64_core_reg *arch_info \u003d malloc(sizeof(struct mips64_core_reg) * num_regs);"},{"line_number":368,"context_line":"\tstruct reg_feature *feature;"},{"line_number":369,"context_line":"\tunsigned i;"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_5fbe07d3","line":367,"updated":"2019-07-16 12:54:38.000000000","message":"i can\u0027t find any related free() to here allocated resources.\nYou will need to add deinit_target(). For example like cortex_a_deinit_target()","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":399,"context_line":"\t\t\tif (reg_list[i].reg_data_type)"},{"line_number":400,"context_line":"\t\t\t\treg_list[i].reg_data_type-\u003etype \u003d mips64_regs[i].type;"},{"line_number":401,"context_line":"\t\t\telse"},{"line_number":402,"context_line":"\t\t\t\tLOG_ERROR(\"unable to allocate reg type list\");"},{"line_number":403,"context_line":"\t\t}"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"\t\treg_list[i].dirty \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_7fc3c361","line":402,"updated":"2019-07-16 12:54:38.000000000","message":"no error is returned","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":414,"context_line":"\t\t\tfeature-\u003ename \u003d mips64_regs[i].feature;"},{"line_number":415,"context_line":"\t\t\treg_list[i].feature \u003d feature;"},{"line_number":416,"context_line":"\t\t} else"},{"line_number":417,"context_line":"\t\t\tLOG_ERROR(\"unable to allocate feature list\");"},{"line_number":418,"context_line":"\t}"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"\treturn cache;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_1fb88fe1","line":417,"updated":"2019-07-16 12:54:38.000000000","message":"here should be return with error value as well.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":436,"context_line":"}"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"int mips64_run_algorithm(struct target *target, int num_mem_params,"},{"line_number":439,"context_line":"\tstruct mem_param *mem_params, int num_reg_params, struct reg_param *reg_params,"},{"line_number":440,"context_line":"\ttarget_addr_t entry_point, target_addr_t exit_point, int timeout_ms, void *arch_info)"},{"line_number":441,"context_line":"{"},{"line_number":442,"context_line":"\t/*FIXME*/"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_3fbd4bd2","line":439,"updated":"2019-07-16 12:54:38.000000000","message":"hm.. will it be better to not define this function. In this case may drivers will fail with error, instead of silently fail.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"\t\tmips64-\u003enum_inst_bpoints \u003d (bpinfo \u003e\u003e 24) \u0026 0x0F;"},{"line_number":488,"context_line":"\t\tmips64-\u003enum_inst_bpoints_avail \u003d mips64-\u003enum_inst_bpoints;"},{"line_number":489,"context_line":"\t\tmips64-\u003einst_break_list \u003d calloc(mips64-\u003enum_inst_bpoints, sizeof(struct mips64_comparator));"},{"line_number":490,"context_line":"\t\tfor (i \u003d 0; i \u003c mips64-\u003enum_inst_bpoints; i++)"},{"line_number":491,"context_line":"\t\t\tmips64-\u003einst_break_list[i].reg_address \u003d EJTAG64_V25_IBA0 + (0x100 * i);"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_dfd1b728","line":489,"updated":"2019-07-16 12:54:38.000000000","message":"allocation without free()","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"99bccba4e1346053686c79ef0e33df35d097f763","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\t\tmips64-\u003enum_data_bpoints \u003d (bpinfo \u003e\u003e 24) \u0026 0x0F;"},{"line_number":506,"context_line":"\t\tmips64-\u003enum_data_bpoints_avail \u003d mips64-\u003enum_data_bpoints;"},{"line_number":507,"context_line":"\t\tmips64-\u003edata_break_list \u003d calloc(mips64-\u003enum_data_bpoints, sizeof(struct mips64_comparator));"},{"line_number":508,"context_line":"\t\tfor (i \u003d 0; i \u003c mips64-\u003enum_data_bpoints; i++)"},{"line_number":509,"context_line":"\t\t\tmips64-\u003edata_break_list[i].reg_address \u003d EJTAG64_V25_DBA0 + (0x100 * i);"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_ffcef385","line":507,"updated":"2019-07-16 12:54:38.000000000","message":"allocation without free()","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"}],"src/target/mips64.h":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b5f259901e60b93c7f20750b67fee6741550b001","unresolved":false,"context_lines":[{"line_number":24,"context_line":" *   along with this program. If not, see \u003chttp://www.gnu.org/licenses/\u003e.  *"},{"line_number":25,"context_line":" ***************************************************************************/"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef MIPS64_H"},{"line_number":28,"context_line":"#define MIPS64_H"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"target.h\""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"89d89d6c_8e14bbf4","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":16},"updated":"2016-06-26 10:23:34.000000000","message":"Please fix #include guard. See http://openocd.org/doc/doxygen/html/stylec.html","commit_id":"36523d390712402bd4f78eb01347956be4406a19"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"e64d0dee7794c329280dde284333faae50a410d2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\tMIPS64NUMCOREREGS"},{"line_number":43,"context_line":"};"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"typedef struct mips64_comparator_s {"},{"line_number":46,"context_line":"\tint used;"},{"line_number":47,"context_line":"\tuint64_t bp_value;"},{"line_number":48,"context_line":"\tuint64_t reg_address;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"8e518320_4f53e543","line":45,"updated":"2017-02-28 21:12:40.000000000","message":"No typedeffing structs, use the full type, struct mips64_comparator.","commit_id":"e59f82d764d729063098b2dbd6d2e2119d50019a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"e64d0dee7794c329280dde284333faae50a410d2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\tuint64_t reg_address;"},{"line_number":49,"context_line":"} mips64_comparator_t;"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"typedef struct mips64_common_s {"},{"line_number":52,"context_line":"\tuint32_t common_magic;"},{"line_number":53,"context_line":"\tvoid *arch_info;"},{"line_number":54,"context_line":"\tstruct reg_cache *core_cache;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"8e518320_2f48a98b","line":51,"updated":"2017-02-28 21:12:40.000000000","message":"etc","commit_id":"e59f82d764d729063098b2dbd6d2e2119d50019a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"e64d0dee7794c329280dde284333faae50a410d2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\tint (*write_core_reg)(struct target *target, int num);"},{"line_number":69,"context_line":"} mips64_common_t;"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"typedef struct mips64_core_reg_s {"},{"line_number":72,"context_line":"\tuint32_t num;"},{"line_number":73,"context_line":"\tstruct target *target;"},{"line_number":74,"context_line":"\tmips64_common_t *mips64_common;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"8e518320_0f4ded9b","line":71,"updated":"2017-02-28 21:12:40.000000000","message":"etc","commit_id":"e59f82d764d729063098b2dbd6d2e2119d50019a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"e64d0dee7794c329280dde284333faae50a410d2","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"#define MIPS64_SYNC\t\t\t0x0000000F"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"extern int mips64_arch_state(struct target *target);"},{"line_number":156,"context_line":"extern int mips64_init_arch_info(struct target *target, mips64_common_t *mips64, struct jtag_tap *tap);"},{"line_number":157,"context_line":"extern int mips64_restore_context(struct target *target);"},{"line_number":158,"context_line":"extern int mips64_save_context(struct target *target);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"8e518320_ef617102","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":7},"updated":"2017-02-28 21:12:40.000000000","message":"Obviously it\u0027s extern, pointless keyword for functions.","commit_id":"e59f82d764d729063098b2dbd6d2e2119d50019a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d365693eb71df655bfc73ca7f7337cc12831c15c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"};"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"struct mips64_comparator {"},{"line_number":46,"context_line":"\tint used;"},{"line_number":47,"context_line":"\tuint64_t bp_value;"},{"line_number":48,"context_line":"\tuint64_t reg_address;"},{"line_number":49,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"0e6cb3ef_4e8bb320","line":46,"updated":"2019-02-25 23:17:16.000000000","message":"Same here (spotted on follow-up patches)","commit_id":"fc4a425f9f082f099a1eb6bf21a515377880f9f8"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":39,"context_line":"enum {"},{"line_number":40,"context_line":"\tMIPS64_PC \u003d MIPS64_NUM_CORE_REGS - 1,"},{"line_number":41,"context_line":"\tMIPS64_FIR \u003d MIPS64_NUM_CORE_REGS + MIPS64_NUM_FP_REGS - 1,"},{"line_number":42,"context_line":"\tMIPS64NUMCOREREGS"},{"line_number":43,"context_line":"};"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"struct mips64_comparator {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_f4461826","line":42,"updated":"2019-03-12 20:10:17.000000000","message":"Whitespacesbetweenwords? :)","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":161,"context_line":"\ttarget_addr_t entry_point, target_addr_t exit_point,"},{"line_number":162,"context_line":"\tint timeout_ms, void *arch_info);"},{"line_number":163,"context_line":"int mips64_configure_break_unit(struct target *target);"},{"line_number":164,"context_line":"int mips64_enable_interrupts(struct target *target, int enable);"},{"line_number":165,"context_line":"int mips64_examine(struct target *target);"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"int mips64_register_commands(struct command_context *cmd_ctx);"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_1444ec1b","line":164,"updated":"2019-03-12 20:10:17.000000000","message":"bool?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e62e66d4d2db745432f9e97ff91963504d538b87","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#define MIPS64_OP_BEQ\t0x04"},{"line_number":123,"context_line":"#define MIPS64_OP_BNE\t0x05"},{"line_number":124,"context_line":"#define MIPS64_OP_ADDI\t0x08"},{"line_number":125,"context_line":"#define MIPS64_OP_ANDI\t12"},{"line_number":126,"context_line":"#define MIPS64_OP_DADDI\t24"},{"line_number":127,"context_line":"#define MIPS64_OP_DADDIU\t25"},{"line_number":128,"context_line":"#define MIPS64_OP_AND\t0x24"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_7f00a304","line":125,"updated":"2019-07-07 12:14:44.000000000","message":"mixed dec + hex defines","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"}],"src/target/mips64_pracc.c":[{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"\tstatic uint64_t prev_text_address \u003d MIPS64_PRACC_TEXT;"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\tif ((address \u003e\u003d MIPS64_PRACC_PARAM_IN)"},{"line_number":130,"context_line":"\t\t\u0026\u0026 (address \u003c\u003d MIPS64_PRACC_PARAM_IN + ctx-\u003enum_iparam * MIPS64_PRACC_DATA_STEP)) {"},{"line_number":131,"context_line":"\t\toffset \u003d (address - MIPS64_PRACC_PARAM_IN) / MIPS64_PRACC_DATA_STEP;"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"\t\tif (offset \u003e\u003d MIPS64_PRACC_PARAM_IN_SIZE) {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_d38e467a","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":16},"updated":"2016-01-16 08:55:12.000000000","message":"Should be \"\u003c\" not \"\u003c\u003d\", risk of segfault.","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"\t\tLOG_DEBUG(\"Reading %016llx at %016llx\", (unsigned long long) data, (unsigned long long) address);"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_PARAM_OUT)"},{"line_number":146,"context_line":"\t\t\u0026\u0026 (address \u003c\u003d MIPS64_PRACC_PARAM_OUT + ctx-\u003enum_oparam * MIPS64_PRACC_DATA_STEP)) {"},{"line_number":147,"context_line":"\t\toffset \u003d (address - MIPS64_PRACC_PARAM_OUT) / MIPS64_PRACC_DATA_STEP;"},{"line_number":148,"context_line":"\t\tif (ctx-\u003elocal_oparam \u003d\u003d NULL) {"},{"line_number":149,"context_line":"\t\t\tLOG_ERROR(\"Error: unexpected reading of output parameter\");"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_f38b4a67","line":146,"range":{"start_line":146,"start_character":14,"end_line":146,"end_character":16},"updated":"2016-01-16 08:55:12.000000000","message":"Same problem","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\t\tdata \u003d ctx-\u003elocal_oparam[offset];"},{"line_number":153,"context_line":"\t\tLOG_DEBUG(\"Reading %016llx at %016llx\", (unsigned long long) data, (unsigned long long) address);"},{"line_number":154,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_TEXT)"},{"line_number":155,"context_line":"\t\t\u0026\u0026 (address \u003c\u003d MIPS64_PRACC_TEXT + ctx-\u003ecode_len * MIPS64_PRACC_ADDR_STEP)) {"},{"line_number":156,"context_line":"\t\t/* Check for correct text address incrementation */"},{"line_number":157,"context_line":"\t\tif ((address !\u003d MIPS64_PRACC_TEXT) \u0026\u0026"},{"line_number":158,"context_line":"\t\t    (address !\u003d prev_text_address + MIPS64_PRACC_ADDR_STEP * 2)) {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_13ea8e10","line":155,"range":{"start_line":155,"start_character":14,"end_line":155,"end_character":16},"updated":"2016-01-16 08:55:12.000000000","message":"Same problem","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"\tLOG_DEBUG(\"Writing %016llx at %016llx\\n\", (unsigned long long) data, (unsigned long long) address);"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"\tif ((address \u003e\u003d MIPS64_PRACC_PARAM_IN)"},{"line_number":227,"context_line":"\t\t\u0026\u0026 (address \u003c\u003d MIPS64_PRACC_PARAM_IN + ctx-\u003enum_iparam * MIPS64_PRACC_DATA_STEP)) {"},{"line_number":228,"context_line":"\t\toffset \u003d (address - MIPS64_PRACC_PARAM_IN) / MIPS64_PRACC_DATA_STEP;"},{"line_number":229,"context_line":"\t\tif (ctx-\u003elocal_iparam \u003d\u003d NULL) {"},{"line_number":230,"context_line":"\t\t\tLOG_ERROR(\"Error: unexpected writing of input parameter\");"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_33ef9221","line":227,"range":{"start_line":227,"start_character":14,"end_line":227,"end_character":16},"updated":"2016-01-16 08:55:12.000000000","message":"Same problem","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"\t\t}"},{"line_number":233,"context_line":"\t\tctx-\u003elocal_iparam[offset] \u003d data;"},{"line_number":234,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_PARAM_OUT)"},{"line_number":235,"context_line":"\t\t\u0026\u0026 (address \u003c\u003d MIPS64_PRACC_PARAM_OUT + ctx-\u003enum_oparam * MIPS64_PRACC_DATA_STEP)) {"},{"line_number":236,"context_line":"\t\toffset \u003d (address - MIPS64_PRACC_PARAM_OUT) / MIPS64_PRACC_DATA_STEP;"},{"line_number":237,"context_line":"\t\tif (ctx-\u003elocal_oparam \u003d\u003d NULL) {"},{"line_number":238,"context_line":"\t\t\tLOG_ERROR(\"Error: unexpected writing of output parameter\");"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_53f416f1","line":235,"range":{"start_line":235,"start_character":14,"end_line":235,"end_character":16},"updated":"2016-01-16 08:55:12.000000000","message":"Same problem","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"f658949398778e9f3c0406a9b74b244f8228433b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"\t/* stack sanity check */"},{"line_number":351,"context_line":"\tif (ctx.stack_offset !\u003d 0)"},{"line_number":352,"context_line":"\t\tLOG_ERROR(\"Pracc Stack not zero\");"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"\treturn ERROR_OK;"},{"line_number":355,"context_line":"}"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c9a295ae_73f91ae6","line":353,"range":{"start_line":353,"start_character":0,"end_line":353,"end_character":0},"updated":"2016-01-16 08:55:12.000000000","message":"How does this function handle the special case when resuming for a large time ?.\nIn the old mips32 code the cycle parameter was set to 0 to indicate it should shift out the deret instruction and exit without further checking. Obviously this can not be done now.\n\nNow it will exit with error, either error in pracc_exec_read if there is no more code to be shifted out (if still in debug mode) or an error in wait_for_pracc (timeout, if exited debug mode). It will never see a second pass through PRAC_TEXT.\nI am missing something?","commit_id":"edae95516e9a17812c195abb6b38ee6ab6012fd2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"0e07a1e058aa018c37d2420395d892894e419fc9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"{"},{"line_number":199,"context_line":"\tuint32_t ejtag_ctrl;"},{"line_number":200,"context_line":"\tuint64_t data;"},{"line_number":201,"context_line":"\tint offset;"},{"line_number":202,"context_line":"\tstruct mips_ejtag *ejtag_info \u003d ctx-\u003eejtag_info;"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"\tmips_ejtag_set_instr(ctx-\u003eejtag_info, EJTAG_INST_DATA);"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"0e6cb3ef_ce9fc361","line":201,"updated":"2019-02-25 23:11:49.000000000","message":"Is a negative offset possible?","commit_id":"fc4a425f9f082f099a1eb6bf21a515377880f9f8"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"0e07a1e058aa018c37d2420395d892894e419fc9","unresolved":false,"context_lines":[{"line_number":242,"context_line":"}"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"int mips64_pracc_exec(struct mips_ejtag *ejtag_info, int code_len, uint32_t *code,"},{"line_number":245,"context_line":"\tint num_param_in, uint64_t *param_in, int num_param_out, uint64_t *param_out, int cycle)"},{"line_number":246,"context_line":"{"},{"line_number":247,"context_line":"\tuint32_t ejtag_ctrl;"},{"line_number":248,"context_line":"\tuint64_t address \u003d 0, address_prev \u003d 0, data;"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"0e6cb3ef_aea28fa2","line":245,"updated":"2019-02-25 23:11:49.000000000","message":"For example","commit_id":"fc4a425f9f082f099a1eb6bf21a515377880f9f8"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"typedef struct {"},{"line_number":88,"context_line":"\tuint64_t *local_iparam;"},{"line_number":89,"context_line":"\tint num_iparam;"},{"line_number":90,"context_line":"\tuint64_t *local_oparam;"},{"line_number":91,"context_line":"\tint num_oparam;"},{"line_number":92,"context_line":"\tuint32_t *code;"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_345490c9","line":89,"updated":"2019-03-12 20:10:17.000000000","message":"negative?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":251,"context_line":"\tuint64_t address \u003d 0, address_prev \u003d 0, data;"},{"line_number":252,"context_line":"\tmips64_pracc_context ctx;"},{"line_number":253,"context_line":"\tint retval;"},{"line_number":254,"context_line":"\tint pass \u003d 0;"},{"line_number":255,"context_line":"\tint first_time_call \u003d 1;"},{"line_number":256,"context_line":"\tunsigned i;"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_f46db897","line":254,"updated":"2019-03-12 20:10:17.000000000","message":"data types..","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":312,"context_line":"\t\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":313,"context_line":"\t\t}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"\t\tfirst_time_call \u003d 0;"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"\t\t/* Check for read or write */"},{"line_number":318,"context_line":"\t\tif (ejtag_ctrl \u0026 EJTAG_CTRL_PRNW) {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_54590400","line":315,"updated":"2019-03-12 20:10:17.000000000","message":"bool?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"int mips64_pracc_read_u64(struct mips_ejtag *ejtag_info, uint64_t addr, uint64_t *buf)"},{"line_number":378,"context_line":"{"},{"line_number":379,"context_line":"\tuint32_t code[] \u003d {"},{"line_number":380,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"},{"line_number":381,"context_line":"\t\tMIPS64_LUI(15, UPPER16(MIPS64_PRACC_STACK)),\t\t/* $15 \u003d MIPS64_PRACC_STACK */"},{"line_number":382,"context_line":"\t\tMIPS64_ORI(15, 15, LOWER16(MIPS64_PRACC_STACK)),"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_146b8c83","line":379,"updated":"2019-03-12 20:10:17.000000000","message":"const?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":406,"context_line":"\t\tARRAY_SIZE(param_in), param_in, 1, (uint64_t *) buf, true);"},{"line_number":407,"context_line":"}"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"int mips64_pracc_read_mem32(struct mips_ejtag *ejtag_info, uint64_t addr, int count, uint32_t *buf)"},{"line_number":410,"context_line":"{"},{"line_number":411,"context_line":"\tint i, retval \u003d ERROR_OK;"},{"line_number":412,"context_line":"\tfor (i \u003d 0; i \u003c count; i++) {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_b46740b4","line":409,"updated":"2019-03-12 20:10:17.000000000","message":"negative count values?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"int mips64_pracc_read_u32(struct mips_ejtag *ejtag_info, uint64_t addr, uint32_t *buf)"},{"line_number":421,"context_line":"{"},{"line_number":422,"context_line":"\tuint32_t code[] \u003d {"},{"line_number":423,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"},{"line_number":424,"context_line":"\t\tMIPS64_LUI(15, UPPER16(MIPS64_PRACC_STACK)),\t\t/* $15 \u003d MIPS64_PRACC_STACK */"},{"line_number":425,"context_line":"\t\tMIPS64_ORI(15, 15, LOWER16(MIPS64_PRACC_STACK)),"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_d46434b1","line":422,"updated":"2019-03-12 20:10:17.000000000","message":"const?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":454,"context_line":"\treturn retval;"},{"line_number":455,"context_line":"}"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"int mips64_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint64_t addr, int count, uint16_t *buf)"},{"line_number":458,"context_line":"{"},{"line_number":459,"context_line":"\tint i, retval \u003d ERROR_OK;"},{"line_number":460,"context_line":"\tfor (i \u003d 0; i \u003c count; i++) {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_7401a8b8","line":457,"updated":"2019-03-12 20:10:17.000000000","message":"same","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"int mips64_pracc_read_u16(struct mips_ejtag *ejtag_info, uint64_t addr, uint16_t *buf)"},{"line_number":469,"context_line":"{"},{"line_number":470,"context_line":"\tuint32_t code[] \u003d {"},{"line_number":471,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"},{"line_number":472,"context_line":"\t\tMIPS64_LUI(15, UPPER16(MIPS64_PRACC_STACK)),\t\t/* $15 \u003d MIPS64_PRACC_STACK */"},{"line_number":473,"context_line":"\t\tMIPS64_ORI(15, 15, LOWER16(MIPS64_PRACC_STACK)),"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_9406bcd0","line":470,"updated":"2019-03-12 20:10:17.000000000","message":"const?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":550,"context_line":"\treturn retval;"},{"line_number":551,"context_line":"}"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"int mips64_pracc_write_mem(struct mips_ejtag *ejtag_info, uint64_t addr, int size, int count, void *buf)"},{"line_number":554,"context_line":"{"},{"line_number":555,"context_line":"\tswitch (size) {"},{"line_number":556,"context_line":"\t\tcase 1:"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_340b30db","line":553,"updated":"2019-03-12 20:10:17.000000000","message":"data types..","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e62e66d4d2db745432f9e97ff91963504d538b87","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\tunsigned num_oparam;"},{"line_number":92,"context_line":"\tconst uint32_t *code;"},{"line_number":93,"context_line":"\tunsigned code_len;"},{"line_number":94,"context_line":"\tuint64_t stack[32];"},{"line_number":95,"context_line":"\tunsigned stack_offset;"},{"line_number":96,"context_line":"\tstruct mips_ejtag *ejtag_info;"},{"line_number":97,"context_line":"} mips64_pracc_context;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_1f05ef13","line":94,"updated":"2019-07-07 12:14:44.000000000","message":"please define some name for stack size. stack_offset is used to navigate in stack[], can it overflow?","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"53c34fae2d188f91858c26ec01a4bc069fee369d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\twhile (1) {"},{"line_number":105,"context_line":"\t\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":106,"context_line":"\t\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":107,"context_line":"\t\tmips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\t\tif (ejtag_ctrl \u0026 EJTAG_CTRL_PRACC)"},{"line_number":110,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_df0e9737","line":107,"updated":"2019-07-07 14:30:33.000000000","message":"mips_ejtag_drscan_32 can return an error. Looks like return value for this function is mostly ignored in this patch.","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":158,"context_line":"\t\t\tdata |\u003d (uint64_t)ctx-\u003ecode[offset + 1];"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"\t\tLOG_DEBUG(\"Running commands %016llx at address %016llx\","},{"line_number":162,"context_line":"\t\t\t(unsigned long long) data, (unsigned long long) address);"},{"line_number":163,"context_line":"\t} else if ((address \u0026 ~7llu) \u003d\u003d MIPS64_PRACC_STACK) {"},{"line_number":164,"context_line":"\t\t/* load from our debug stack */"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_9f181f7c","line":161,"range":{"start_line":161,"start_character":31,"end_line":161,"end_character":37},"updated":"2019-07-07 16:06:42.000000000","message":"Please use portable PRIx64 instead of llx and remove unsigned long to unsigned long long casting. For all places in this patches.","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tjtag_add_clocks(5);"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"\tjtag_execute_queue();"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"\treturn ERROR_OK;"},{"line_number":195,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_bf15db42","line":192,"updated":"2019-07-07 16:06:42.000000000","message":"this may return error.\nProbably just:\nreturn jtag_execute_queue()","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":245,"context_line":"\t\t      unsigned code_len, const uint32_t *code,"},{"line_number":246,"context_line":"\t\t      unsigned num_param_in, uint64_t *param_in,"},{"line_number":247,"context_line":"\t\t      unsigned num_param_out, uint64_t *param_out,"},{"line_number":248,"context_line":"\t\t      bool cycle)"},{"line_number":249,"context_line":"{"},{"line_number":250,"context_line":"\tuint32_t ejtag_ctrl;"},{"line_number":251,"context_line":"\tuint64_t address \u003d 0, address_prev \u003d 0, data;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_1f1c0f6a","line":248,"updated":"2019-07-07 16:06:42.000000000","message":"I didn\u0027t found any place where cycle !\u003d 1. Do we need this option?","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":364,"context_line":"\treturn ERROR_FAIL;"},{"line_number":365,"context_line":"}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"int mips64_pracc_read_mem64(struct mips_ejtag *ejtag_info, uint64_t addr,"},{"line_number":368,"context_line":"\t\t\t    unsigned count, uint64_t *buf)"},{"line_number":369,"context_line":"{"},{"line_number":370,"context_line":"\tint retval \u003d ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_3f21cb9a","line":367,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":377,"context_line":"\treturn retval;"},{"line_number":378,"context_line":"}"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"int mips64_pracc_read_u64(struct mips_ejtag *ejtag_info, uint64_t addr, uint64_t *buf)"},{"line_number":381,"context_line":"{"},{"line_number":382,"context_line":"\tconst uint32_t code[] \u003d {"},{"line_number":383,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_bf2cfb90","line":380,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":409,"context_line":"\t\tARRAY_SIZE(param_in), param_in, 1, (uint64_t *) buf, true);"},{"line_number":410,"context_line":"}"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"int mips64_pracc_read_mem32(struct mips_ejtag *ejtag_info, uint64_t addr, unsigned count, uint32_t *buf)"},{"line_number":413,"context_line":"{"},{"line_number":414,"context_line":"\tint retval \u003d ERROR_OK;"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_df3537d9","line":412,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":421,"context_line":"\treturn retval;"},{"line_number":422,"context_line":"}"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"int mips64_pracc_read_u32(struct mips_ejtag *ejtag_info, uint64_t addr, uint32_t *buf)"},{"line_number":425,"context_line":"{"},{"line_number":426,"context_line":"\tconst uint32_t code[] \u003d {"},{"line_number":427,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_5f492769","line":424,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":458,"context_line":"\treturn retval;"},{"line_number":459,"context_line":"}"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"int mips64_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint64_t addr,"},{"line_number":462,"context_line":"\t\t\t    unsigned count, uint16_t *buf)"},{"line_number":463,"context_line":"{"},{"line_number":464,"context_line":"\tint retval \u003d ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_ff3273ee","line":461,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":471,"context_line":"\treturn retval;"},{"line_number":472,"context_line":"}"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"int mips64_pracc_read_u16(struct mips_ejtag *ejtag_info, uint64_t addr, uint16_t *buf)"},{"line_number":475,"context_line":"{"},{"line_number":476,"context_line":"\tconst uint32_t code[] \u003d {"},{"line_number":477,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_7f4e6374","line":474,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":508,"context_line":"\treturn retval;"},{"line_number":509,"context_line":"}"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"int mips64_pracc_read_mem8(struct mips_ejtag *ejtag_info, uint64_t addr,"},{"line_number":512,"context_line":"\t\t\t  unsigned count, uint8_t *buf)"},{"line_number":513,"context_line":"{"},{"line_number":514,"context_line":"\tint retval \u003d ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_9f2fbf85","line":511,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":521,"context_line":"\treturn retval;"},{"line_number":522,"context_line":"}"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"int mips64_pracc_read_u8(struct mips_ejtag *ejtag_info, uint64_t addr, uint8_t *buf)"},{"line_number":525,"context_line":"{"},{"line_number":526,"context_line":"\tconst uint32_t code[] \u003d {"},{"line_number":527,"context_line":"\t\tMIPS64_DMTC0(15, 31, 0),\t\t\t\t\t/* move $15 to COP0 DeSave */"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_1f53af1b","line":524,"updated":"2019-07-07 16:06:42.000000000","message":"static","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":575,"context_line":"\treturn ERROR_FAIL;"},{"line_number":576,"context_line":"}"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"int mips64_pracc_write_mem64(struct mips_ejtag *ejtag_info,"},{"line_number":579,"context_line":"\t\t\t     uint64_t addr, unsigned count, uint64_t *buf)"},{"line_number":580,"context_line":"{"},{"line_number":581,"context_line":"\tint retval \u003d ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_3f58eb34","line":578,"updated":"2019-07-07 16:06:42.000000000","message":"all mips64_pracc_write_* variants are static too","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"415dd06cea0535a231c52f6e4f0b9be3f8d14b01","unresolved":false,"context_lines":[{"line_number":65,"context_line":"static int mips64_pracc_write_mem32(struct mips_ejtag *ejtag_info, uint64_t addr, unsigned count, uint32_t *buf);"},{"line_number":66,"context_line":"static int mips64_pracc_write_u32(struct mips_ejtag *ejtag_info, uint64_t addr, uint32_t *buf);"},{"line_number":67,"context_line":"static int mips64_pracc_write_mem64(struct mips_ejtag *ejtag_info, uint64_t addr, unsigned count, uint64_t *buf);"},{"line_number":68,"context_line":"static int mips64_pracc_write_u64(struct mips_ejtag *ejtag_info, uint64_t addr, uint64_t *buf);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"static int wait_for_pracc_rw(struct mips_ejtag *ejtag_info, uint32_t *ctrl)"},{"line_number":71,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_7fb743d4","line":68,"updated":"2019-07-17 19:52:21.000000000","message":"All this function are used only in one place. Please just reorder them to avoid this needles declarations.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"c02d7f5b729c05d1940edc6dacfd4a12290442f8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"static int mips64_pracc_write_mem64(struct mips_ejtag *ejtag_info, uint64_t addr, unsigned count, uint64_t *buf);"},{"line_number":68,"context_line":"static int mips64_pracc_write_u64(struct mips_ejtag *ejtag_info, uint64_t addr, uint64_t *buf);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"static int wait_for_pracc_rw(struct mips_ejtag *ejtag_info, uint32_t *ctrl)"},{"line_number":71,"context_line":"{"},{"line_number":72,"context_line":"\tuint32_t ejtag_ctrl;"},{"line_number":73,"context_line":"\tint nt \u003d 5;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_df7f7710","line":70,"updated":"2019-07-16 18:05:52.000000000","message":"please use same naming schema - prefix mips64_pracc_","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"c02d7f5b729c05d1940edc6dacfd4a12290442f8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\tint nt \u003d 5;"},{"line_number":74,"context_line":"\tint rc;"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\twhile (1) {"},{"line_number":77,"context_line":"\t\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":78,"context_line":"\t\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":79,"context_line":"\t\trc \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_ff7cb31d","line":76,"updated":"2019-07-16 18:05:52.000000000","message":"while (true)","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5aae85f34d3ab56a9f7e0b358b2a36ab99dd0e52","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\tif (ejtag_ctrl \u0026 EJTAG_CTRL_PRACC)"},{"line_number":84,"context_line":"\t\t\tbreak;"},{"line_number":85,"context_line":"\t\tLOG_DEBUG(\"DEBUGMODULE: No memory access in progress!\\n\");"},{"line_number":86,"context_line":"\t\tif (nt \u003d\u003d 0)"},{"line_number":87,"context_line":"\t\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":88,"context_line":"\t\tnt--;"},{"line_number":89,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_bfc87b78","line":86,"updated":"2019-07-16 14:38:38.000000000","message":"I assume it is better to put this debug message here. No need to print it multiple times.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5aae85f34d3ab56a9f7e0b358b2a36ab99dd0e52","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\t\t\tLOG_ERROR(\"Error: unexpected reading of input parameter\");"},{"line_number":114,"context_line":"\t\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":115,"context_line":"\t\t}"},{"line_number":116,"context_line":"\t\tdata \u003d ctx-\u003elocal_iparam[offset];"},{"line_number":117,"context_line":"\t\tLOG_DEBUG(\"Reading %016llx at %016llx\", (unsigned long long) data, (unsigned long long) address);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_PARAM_OUT)"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_1faf2f93","line":116,"updated":"2019-07-16 14:38:38.000000000","message":"If i see it correctly, in many cases local_iparam is about:\nu64 array[2]\nand we have only one size protection:\nif (offset \u003e\u003d MIPS64_PRACC_PARAM_IN_SIZE)\n\nwhere MIPS64_PRACC_PARAM_IN_SIZE \u003d 0x1000.\nSo we can easily overflow.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5aae85f34d3ab56a9f7e0b358b2a36ab99dd0e52","unresolved":false,"context_lines":[{"line_number":123,"context_line":"\t\t\tLOG_ERROR(\"Error: unexpected reading of output parameter\");"},{"line_number":124,"context_line":"\t\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":125,"context_line":"\t\t}"},{"line_number":126,"context_line":"\t\tdata \u003d ctx-\u003elocal_oparam[offset];"},{"line_number":127,"context_line":"\t\tLOG_DEBUG(\"Reading %\" PRIx64 \" at %\" PRIx64, data, address);"},{"line_number":128,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_TEXT)"},{"line_number":129,"context_line":"\t\t\u0026\u0026 (address \u003c MIPS64_PRACC_TEXT + ctx-\u003ecode_len * MIPS64_PRACC_ADDR_STEP)) {"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_3fb46be4","line":126,"updated":"2019-07-16 14:38:38.000000000","message":"same here?","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5aae85f34d3ab56a9f7e0b358b2a36ab99dd0e52","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\t} else if ((address \u003e\u003d MIPS64_PRACC_TEXT)"},{"line_number":129,"context_line":"\t\t\u0026\u0026 (address \u003c MIPS64_PRACC_TEXT + ctx-\u003ecode_len * MIPS64_PRACC_ADDR_STEP)) {"},{"line_number":130,"context_line":"\t\toffset \u003d ((address \u0026 ~7ull) - MIPS64_PRACC_TEXT) / MIPS64_PRACC_ADDR_STEP;"},{"line_number":131,"context_line":"\t\tdata \u003d (uint64_t)ctx-\u003ecode[offset] \u003c\u003c 32;"},{"line_number":132,"context_line":"\t\tif (offset + 1 \u003c ctx-\u003ecode_len)"},{"line_number":133,"context_line":"\t\t\tdata |\u003d (uint64_t)ctx-\u003ecode[offset + 1];"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_df98d77e","line":131,"updated":"2019-07-16 14:38:38.000000000","message":"same with -\u003ecode[]?","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5aae85f34d3ab56a9f7e0b358b2a36ab99dd0e52","unresolved":false,"context_lines":[{"line_number":133,"context_line":"\t\t\tdata |\u003d (uint64_t)ctx-\u003ecode[offset + 1];"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"\t\tLOG_DEBUG(\"Running commands %016llx at address %016llx\","},{"line_number":137,"context_line":"\t\t\t(unsigned long long) data, (unsigned long long) address);"},{"line_number":138,"context_line":"\t} else if ((address \u0026 ~7llu) \u003d\u003d MIPS64_PRACC_STACK) {"},{"line_number":139,"context_line":"\t\t/* load from our debug stack */"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_ff959343","line":136,"updated":"2019-07-16 14:38:38.000000000","message":"%llx is not portable. In this patch there are more %llx to fix","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"c02d7f5b729c05d1940edc6dacfd4a12290442f8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"\t\t/* TODO: send JMP 0xFF200000 instruction. Hopefully processor jump back"},{"line_number":148,"context_line":"\t\t * to start of debug vector */"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"\t\tdata \u003d 0;"},{"line_number":151,"context_line":"\t\tLOG_ERROR(\"Error reading unexpected address %016llx\", (unsigned long long) address);"},{"line_number":152,"context_line":"\t\treturn ERROR_JTAG_DEVICE_ERROR;"},{"line_number":153,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_1f864f19","line":150,"updated":"2019-07-16 18:05:52.000000000","message":"no need to set data here.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"c02d7f5b729c05d1940edc6dacfd4a12290442f8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"\tif (rc !\u003d ERROR_OK)"},{"line_number":167,"context_line":"\t\treturn rc;"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"\tjtag_add_clocks(5);"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"\treturn jtag_execute_queue();"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_3f8b0b22","line":169,"updated":"2019-07-16 18:05:52.000000000","message":"please add comment. why it is needed here and why 5 is a good value.","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"fee6e9533579fd9ed6c18b277d9d797e43b75dee","unresolved":false,"context_lines":[{"line_number":268,"context_line":"\t\taddress32 \u003d data \u003d 0;"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"\t\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS);"},{"line_number":271,"context_line":"\t\tmips_ejtag_drscan_32(ejtag_info, \u0026address32);"},{"line_number":272,"context_line":"\t\tLOG_DEBUG(\"-\u003e %08x\", address32);"},{"line_number":273,"context_line":"\t\taddress \u003d 0xffffffffff200000ull | address32;"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_df9e9759","line":271,"updated":"2019-07-17 07:41:46.000000000","message":"Hm... according to EJTAG 6.10, EJTAG_INST_ADDRESS can be 64bit:\n\"The width of the register corresponds to\nthe size of the physical address in the processor implementation (from 32 to 64 bits). The specific length is determined by shifting through the Address register, because the length is not indicated elsewhere.\"\n\nAre there any reason why do we read only 32 bit?","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"fee6e9533579fd9ed6c18b277d9d797e43b75dee","unresolved":false,"context_lines":[{"line_number":273,"context_line":"\t\taddress \u003d 0xffffffffff200000ull | address32;"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"\t\tint psz \u003d (ejtag_ctrl \u003e\u003e 29) \u0026 3;"},{"line_number":276,"context_line":"\t\tint address20 \u003d address \u0026 7;"},{"line_number":277,"context_line":"\t\tswitch (psz) {"},{"line_number":278,"context_line":"\t\tcase 3:"},{"line_number":279,"context_line":"\t\t\tif (address20 !\u003d 7) {"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"8e7fc396_bfa5db9c","line":276,"updated":"2019-07-17 07:41:46.000000000","message":"do i understand it correctly. address20 is actually not address, it is size?\n\"Notice that the Address register does not contain the direct address from the access, because the three LSBs (64-bit\nprocessor) are modified to indicate the size in conjunction with Psz.\"","commit_id":"829ef36134f1165adb6adc512bb0e4e214b8b6ca"}],"src/target/mips64_pracc.h":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b5f259901e60b93c7f20750b67fee6741550b001","unresolved":false,"context_lines":[{"line_number":23,"context_line":" *   You should have received a copy of the GNU General Public License     *"},{"line_number":24,"context_line":" *   along with this program. If not, see \u003chttp://www.gnu.org/licenses/\u003e.  *"},{"line_number":25,"context_line":" ***************************************************************************/"},{"line_number":26,"context_line":"#ifndef MIPS64_PRACC_H"},{"line_number":27,"context_line":"#define MIPS64_PRACC_H"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#include \"mips_ejtag.h\""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"89d89d6c_6efaafbc","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":22},"updated":"2016-06-26 10:23:34.000000000","message":"Same","commit_id":"36523d390712402bd4f78eb01347956be4406a19"}],"src/target/mips_ejtag.c":[{"author":{"_account_id":1000850},"change_message_id":"626661fbb58c9b9636f3297aac71e4731eb1ea83","unresolved":false,"context_lines":[{"line_number":517,"context_line":"}"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"#if BUILD_TARGET64 \u003d\u003d 1"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"int mips64_ejtag_config_step(struct mips_ejtag *ejtag_info, int enable_step)"},{"line_number":523,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"4415acf2_b42de04a","line":520,"updated":"2015-07-01 10:38:16.000000000","message":"Should not be optional.","commit_id":"46493c935293baa3936dd475aa85ed74f8274ef1"},{"author":{"_account_id":1000850},"change_message_id":"626661fbb58c9b9636f3297aac71e4731eb1ea83","unresolved":false,"context_lines":[{"line_number":528,"context_line":"\t\tMIPS64_MTC0(1, 23, 0),\t\t    /* move $1 to COP0 Debug */"},{"line_number":529,"context_line":"\t\tMIPS64_MFC0(1, 31, 0),\t\t    /* move COP0 DeSave to $1 */"},{"line_number":530,"context_line":"\t\tMIPS64_SYNC,"},{"line_number":531,"context_line":"\t\tMIPS64_NOP,"},{"line_number":532,"context_line":"\t\tMIPS64_NOP,"},{"line_number":533,"context_line":"\t\tMIPS64_NOP,"},{"line_number":534,"context_line":"\t\tMIPS64_NOP,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"4415acf2_943264a4","line":531,"updated":"2015-07-01 10:38:16.000000000","message":"Are there some official reason why we have so many NOPs here? Please add some comments to source code. I would assume some body will try to optimize it...","commit_id":"46493c935293baa3936dd475aa85ed74f8274ef1"},{"author":{"_account_id":1000666,"name":"Peter Mamonov","email":"pmamonov@gmail.com","username":"piton"},"change_message_id":"a69d6d37b02c9dd142a57adf087b92bad5a281dc","unresolved":false,"context_lines":[{"line_number":528,"context_line":"\t\tMIPS64_MTC0(1, 23, 0),\t\t    /* move $1 to COP0 Debug */"},{"line_number":529,"context_line":"\t\tMIPS64_MFC0(1, 31, 0),\t\t    /* move COP0 DeSave to $1 */"},{"line_number":530,"context_line":"\t\tMIPS64_SYNC,"},{"line_number":531,"context_line":"\t\tMIPS64_NOP,"},{"line_number":532,"context_line":"\t\tMIPS64_NOP,"},{"line_number":533,"context_line":"\t\tMIPS64_NOP,"},{"line_number":534,"context_line":"\t\tMIPS64_NOP,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"4415acf2_141f7407","line":531,"in_reply_to":"4415acf2_943264a4","updated":"2015-07-01 11:04:59.000000000","message":"I agree, this is excessive. Will strip it down later.","commit_id":"46493c935293baa3936dd475aa85ed74f8274ef1"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"299a3d315d41a8ef74a9f249eeba218b4b835c90","unresolved":false,"context_lines":[{"line_number":537,"context_line":"\t\tMIPS64_NOP,"},{"line_number":538,"context_line":"\t\tMIPS64_NOP,"},{"line_number":539,"context_line":"\t\tMIPS64_B(NEG16(15)),"},{"line_number":540,"context_line":"\t\tMIPS64_NOP,"},{"line_number":541,"context_line":"\t\tMIPS64_NOP,"},{"line_number":542,"context_line":"\t\tMIPS64_NOP,"},{"line_number":543,"context_line":"\t\tMIPS64_NOP,"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c9a295ae_b0ce185a","line":540,"updated":"2016-01-11 22:22:13.000000000","message":"In all pracc functions there are 8 NOP\u0027s after the instruction in the delay slot ( something to expect in bmips with 4 instruction issue ), but here only 7, the first is in the delay slot...Why ?","commit_id":"2053d7ce34f68d0733eebae424b4c4d54ec742ee"},{"author":{"_account_id":1000156,"name":"Salvador Arroyo","email":"sarroyofdez@yahoo.es","username":"Salvador"},"change_message_id":"2e0563e27898742693ee92f0b9faca9a2d49c3ff","unresolved":false,"context_lines":[{"line_number":600,"context_line":"\t\tMIPS64_NOP,"},{"line_number":601,"context_line":"\t\tMIPS64_NOP,"},{"line_number":602,"context_line":"\t\tMIPS64_NOP,"},{"line_number":603,"context_line":"\t\tMIPS64_NOP,"},{"line_number":604,"context_line":"\t};"},{"line_number":605,"context_line":"\tLOG_DEBUG(\"enter mips64_pracc_exec\");"},{"line_number":606,"context_line":"\tmips64_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"e99d9970_865c78ec","line":603,"updated":"2016-01-05 18:02:05.000000000","message":"Are you sure that this code works as expected with only 7 NOPs ?\nOCD does not check if the target really exits debug.","commit_id":"2053d7ce34f68d0733eebae424b4c4d54ec742ee"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"int mips64_ejtag_config_step(struct mips_ejtag *ejtag_info, int enable_step)"},{"line_number":465,"context_line":"{"},{"line_number":466,"context_line":"\tuint32_t code_enable[] \u003d {"},{"line_number":467,"context_line":"\t\tMIPS64_MTC0(1, 31, 0),\t\t    /* move $1 to COP0 DeSave */"},{"line_number":468,"context_line":"\t\tMIPS64_MFC0(1, 23, 0),\t\t    /* move COP0 Debug to $1 */"},{"line_number":469,"context_line":"\t\tMIPS64_ORI(1, 1, 0x0100),\t\t /* set SSt bit in debug reg */"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_f4f4d8cd","line":466,"updated":"2019-03-12 20:10:17.000000000","message":"const?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":480,"context_line":"\t\tMIPS64_NOP,"},{"line_number":481,"context_line":"\t};"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"\tuint32_t code_disable[] \u003d {"},{"line_number":484,"context_line":"\t\tMIPS64_MTC0(15, 31, 0),                           /* move $15 to COP0 DeSave */"},{"line_number":485,"context_line":"\t\tMIPS64_LUI(15, UPPER16(MIPS64_PRACC_STACK)),     /* $15 \u003d MIPS64_PRACC_STACK */"},{"line_number":486,"context_line":"\t\tMIPS64_ORI(15, 15, LOWER16(MIPS64_PRACC_STACK)),"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_14f2acdf","line":483,"updated":"2019-03-12 20:10:17.000000000","message":"same","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"int mips64_ejtag_exit_debug(struct mips_ejtag *ejtag_info)"},{"line_number":518,"context_line":"{"},{"line_number":519,"context_line":"\tuint32_t code[] \u003d {"},{"line_number":520,"context_line":"\t\tMIPS64_DRET,"},{"line_number":521,"context_line":"\t\tMIPS64_NOP,"},{"line_number":522,"context_line":"\t\tMIPS64_NOP,"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_b4fe60aa","line":519,"updated":"2019-03-12 20:10:17.000000000","message":"same","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":508,"context_line":"\tconst uint32_t *code \u003d enable_step ? code_enable : code_disable;"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"\tLOG_DEBUG(\"enter mips64_pracc_exec\");"},{"line_number":511,"context_line":"\tmips64_pracc_exec(ejtag_info,\\"},{"line_number":512,"context_line":"\t\tenable_step ? ARRAY_SIZE(code_enable) : ARRAY_SIZE(code_disable),\\"},{"line_number":513,"context_line":"\t\tcode,\\"},{"line_number":514,"context_line":"\t\t0, NULL, 0, NULL, 1);"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_5f2287a3","line":511,"updated":"2019-07-07 16:06:42.000000000","message":"return value is ignored and formatting is ugly.","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"e11e9c8f42b16ec0a5ffef2d4eb94d253ea1f303","unresolved":false,"context_lines":[{"line_number":528,"context_line":"\t\tMIPS64_NOP,"},{"line_number":529,"context_line":"\t};"},{"line_number":530,"context_line":"\tLOG_DEBUG(\"enter mips64_pracc_exec\");"},{"line_number":531,"context_line":"\tmips64_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,"},{"line_number":532,"context_line":"\t\t0, NULL, 0, NULL, 1);"},{"line_number":533,"context_line":"\treturn ERROR_OK;"},{"line_number":534,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"8e7fc396_7f2743b2","line":531,"updated":"2019-07-07 16:06:42.000000000","message":"return is ignored.","commit_id":"63f78f215db4a61b5e5406ea1a985fd26760a99b"}],"src/target/mips_ejtag.h":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7c3b075e42a796a13843b65ededc86afd52cf82","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"int mips_ejtag_init(struct mips_ejtag *ejtag_info);"},{"line_number":253,"context_line":"int mips_ejtag_config_step(struct mips_ejtag *ejtag_info, int enable_step);"},{"line_number":254,"context_line":"int mips64_ejtag_config_step(struct mips_ejtag *ejtag_info, int enable_step);"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"static inline void mips_le_to_h_u32(jtag_callback_data_t arg)"},{"line_number":257,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0e6cb3ef_54102404","line":254,"updated":"2019-03-12 20:10:17.000000000","message":"bool?","commit_id":"06e6fcdd35a7b6cfa77d11e3b5bc637f0844acac"}]}
