)]}'
{"id":"openocd~master~I38c4db8124b7f4bbf53ddda53c13273449f49c15","project":"openocd","branch":"master","hashtags":[],"change_id":"I38c4db8124b7f4bbf53ddda53c13273449f49c15","subject":"target: try to reexamine even when polling fails","status":"MERGED","created":"2015-04-17 10:40:15.000000000","updated":"2015-04-24 13:46:59.000000000","submitted":"2015-04-24 13:46:59.000000000","submitter":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fcb2464fde02886edcf8e571c307092168578a79","_number":2721,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"value":0,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":1,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":1,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"value":2,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":1,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":1,"date":"2015-04-24 13:46:59.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-17 11:04:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-04-20 14:18:57.000000000","updated_by":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"reviewer":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"state":"REVIEWER"},{"updated":"2015-04-22 06:57:06.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2015-04-23 13:29:21.000000000","updated_by":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"reviewer":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"state":"REVIEWER"}],"messages":[{"id":"5ea6fffffc3162e7a5862be6318a986308323425","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-04-17 10:40:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"26f7877f97a29cf562c38ee4ce87640f33709030","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-04-17 11:04:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/5696/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5132/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4065429cd48d38de1e041effb3bb7d091cd7b377","author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"real_author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"date":"2015-04-17 13:40:30.000000000","message":"Patch Set 1: Code-Review-1\n\nThis helps with initiating openocd, but during reset halt/init, I still have problems and my target ends up not being halted:\n\n\u003e reset init\nadapter speed: 1000 kHz\nJTAG tap: am437x.icepick_d tap/device found: 0x2b98c02f (mfg: 0x017, part: 0xb98c, ver: 0x2)\nJTAG tap: am437x.debugss enabled\nDebug regions are unpowered, an unexpected reset might have happened\nDebug regions are unpowered, an unexpected reset might have happened\nDebug regions are unpowered, an unexpected reset might have happened\nin procedure \u0027reset\u0027 \nin procedure \u0027ocd_bouncer\u0027\n\n\nDebug regions are unpowered, an unexpected reset might have happened\nPolling target am437x.mpuss failed, trying to reexamine\nam437x.mpuss: hardware has 6 breakpoints, 4 watchpoints","accounts_in_message":[],"_revision_number":1},{"id":"6688e39bae9454fab0e8e2a49a8c77097b82f22a","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-04-20 04:46:58.000000000","message":"Patch Set 1:\n\nTomas, please check if this breaks any of your targets.","accounts_in_message":[],"_revision_number":1},{"id":"0b4389dc72b65f2f6271b7d08eede5736c420624","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-04-20 12:31:21.000000000","message":"Patch Set 1:\n\nThis doesn\u0027t seem to be causing any ill effects with ARM926 (i.MX25), runtime tested.","accounts_in_message":[],"_revision_number":1},{"id":"c6ecf1b75af15b7f0f94222b59fdc4c7bbf82af1","author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"real_author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"date":"2015-04-20 14:18:57.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b455b0c7b720db4fc0405be70bbe20a43152a108","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2015-04-22 06:57:06.000000000","message":"Patch Set 1: Code-Review+1\n\nTested together with 2606.\nNo problems found on SAM4L @ vsllink and on PSoC4 @ ftdi.\n\nJust a little inconvenience: polling of a dead target makes lot of noise in -d3 debug output as 10 unsuccessful trials in ahbap_debugport_init are logged each poll.","accounts_in_message":[],"_revision_number":1},{"id":"fa7772669b28c7a47db1b74c652ee3a1036f766d","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-04-23 13:29:21.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks okay. No new breakage for XMC4500.","accounts_in_message":[],"_revision_number":1},{"id":"01bc5bac39b9e6021673d8086a1d9b32f3bb6bb2","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-04-23 16:25:02.000000000","message":"Patch Set 1:\n\nHeh, thanks for testing. Would be very interesting to learn what caused the \"old\" breakage.","accounts_in_message":[],"_revision_number":1},{"id":"2cd0f50e2a33f9892d0be19f6f9b955ef6f6863a","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-04-24 13:46:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fcb2464fde02886edcf8e571c307092168578a79","date":"2015-04-24 13:46:59.000000000","message":"Change has been successfully cherry-picked as f7f9a37fa68432f583f33fe14d6bcec2270e576a","accounts_in_message":[],"_revision_number":1}],"current_revision":"f7f9a37fa68432f583f33fe14d6bcec2270e576a","revisions":{"3d0b46b2c4029ba98f08ff55e57e611df25549ee":{"kind":"REWORK","_number":1,"created":"2015-04-17 10:40:15.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/21/2721/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/2721/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/1 \u0026\u0026 git checkout -b change-2721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/2721/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2d4ae3f4c881696c60f2eb1d1c3b4b6a9577bbd6","subject":"configure the SWD frequency when setting adapter speed in SWD mode for versaloon"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2015-04-17 10:36:28.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2015-04-17 10:36:28.000000000","tz":180},"subject":"target: try to reexamine even when polling fails","message":"target: try to reexamine even when polling fails\n\nAfter intermittent connection failures or target power failures it\nmight be necessary to try reexamination even when polling fails. This\nshould make communication with Cortex-A targets more reliable.\n\nThis was runtime tested with stlink attached to an stm32l1 and an FTDI JTAG\nadapter attached to an stm32f1 target.\n\nChange-Id: I38c4db8124b7f4bbf53ddda53c13273449f49c15\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"f7f9a37fa68432f583f33fe14d6bcec2270e576a":{"kind":"REWORK","_number":2,"created":"2015-04-24 13:46:59.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/21/2721/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/2721/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/2 \u0026\u0026 git checkout -b change-2721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/2721/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/2721/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0d50dfe31840ddd282aa2ca7507c45f607284fc6","subject":"rtos: fix print format specifiers"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2015-04-17 10:36:28.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2015-04-24 13:46:59.000000000","tz":60},"subject":"target: try to reexamine even when polling fails","message":"target: try to reexamine even when polling fails\n\nAfter intermittent connection failures or target power failures it\nmight be necessary to try reexamination even when polling fails. This\nshould make communication with Cortex-A targets more reliable.\n\nThis was runtime tested with stlink attached to an stm32l1 and an FTDI JTAG\nadapter attached to an stm32f1 target.\n\nChange-Id: I38c4db8124b7f4bbf53ddda53c13273449f49c15\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/2721\nTested-by: jenkins\nReviewed-by: Felipe Balbi \u003cbalbi@ti.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Andreas Färber \u003cafaerber@suse.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}