)]}'
{"id":"openocd~master~Idf2cb8d8578e650fda4082f6bbf272518762ebf0","project":"openocd","branch":"master","hashtags":[],"change_id":"Idf2cb8d8578e650fda4082f6bbf272518762ebf0","subject":"tcl/board: Add Digilent Analog Discovery config","status":"MERGED","created":"2015-04-29 07:29:42.000000000","updated":"2015-10-30 11:53:05.000000000","submitted":"2015-10-30 11:53:05.000000000","submitter":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8726224b65da6fb0c25093c196d39dca154cb31f","_number":2752,"owner":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":1,"date":"2015-10-30 11:53:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":0,"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},{"value":2,"date":"2015-10-30 11:53:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":1,"date":"2015-10-30 11:53:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-29 07:49:02.000000000","updated_by":{"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},"reviewer":{"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},"state":"REVIEWER"},{"updated":"2015-10-19 06:12:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-10-28 21:27:06.000000000","updated_by":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"reviewer":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"state":"REVIEWER"},{"updated":"2015-10-30 11:53:05.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"3c6d27464d25f1969d09a63a8e4d05e775917c22","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-04-29 07:29:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2ad73bd5c2e8f9665e1fb8679c255951d68518c3","author":{"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},"real_author":{"_account_id":1000864,"name":"Daniele Emancipato","email":"daniele12457@hotmail.com","username":"nearffxx"},"date":"2015-04-29 07:49:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4751be0240c72073daec8ddfb5c8e45381489204","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-04-29 07:54:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/5749/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5184/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d5d3a1c9a07930ad93e49130dc808fba3886a861","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-04-29 10:53:53.000000000","message":"Patch Set 1:\n\nShouldn\u0027t the interface bits rather go into tcl/interface/ftdi/?","accounts_in_message":[],"_revision_number":1},{"id":"4ca84c5dc90c55c8ad8ac263c65c734385b41d92","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-04-29 22:46:19.000000000","message":"Patch Set 1:\n\n\u003e Shouldn\u0027t the interface bits rather go into tcl/interface/ftdi/?\n\nThe Analog Discovery device is an  MSO/AWG and not a dev kit, so I thought it wouldn\u0027t be very useful to put the interface config in a separate file. I\u0027m fine with changing that, though, if that\u0027s better practice.","accounts_in_message":[],"_revision_number":1},{"id":"c729ec300cc89be25febc64e915cdb4e218f4508","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-04-29 22:53:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e5abb3397b10a37e58b5c112f40cc1ab28f7d6f2","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-04-29 22:55:02.000000000","message":"Patch Set 1:\n\n\u003e Uploaded patch set 2.\n\nI reduced the adapter clock to 25 MHz to bring it in line with the BSDL file\u0027s specifications.","accounts_in_message":[],"_revision_number":1},{"id":"612444ce4022653484b32a37a77f672f7c919359","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-04-29 23:51:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/5762/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5197/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"19df575a9504733351ef3ee32e119fc5393b43cc","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-05-09 17:36:05.000000000","message":"Patch Set 2: Code-Review+1\n\nForest, I checked and `git grep \"^interface\" -- tcl/board/` shows exactly one other config using ftdi directly: tcl/board/gumstix-aerocore.cfg. So no objection from my side.","accounts_in_message":[],"_revision_number":2},{"id":"d740d9c30c563466ec14ac57027229f55448c8ea","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-10-19 05:35:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"09a9e39920254fd179853be50e3a4db8b792cfc0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-19 05:47:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6267/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5702/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"7aebdfaea92fc109f0d0b0720c257b6aa3acac9c","author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"real_author":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"date":"2015-10-19 06:00:15.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ab41278a4adae266dbfef639e679979177cbd47f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-19 06:12:26.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6268/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5703/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"f05f5bbda31d25a01352edadd492869a356353df","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-10-22 08:01:07.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"c7a01e129d37997f01bcf036cd143171a1c5dc6d","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-10-28 21:27:06.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"8726224b65da6fb0c25093c196d39dca154cb31f","date":"2015-10-30 11:53:05.000000000","message":"Change has been successfully cherry-picked as 677dbf1823f8ddd2a98b39c4c5ed3b5b0fceb233 by Paul Fertser","accounts_in_message":[],"_revision_number":4}],"current_revision":"677dbf1823f8ddd2a98b39c4c5ed3b5b0fceb233","revisions":{"09eef135d0781de5e50ffe16d1187b30f56e2ea0":{"kind":"REWORK","_number":1,"created":"2015-04-29 07:29:42.000000000","uploader":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"ref":"refs/changes/52/2752/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/2752/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/1 \u0026\u0026 git checkout -b change-2752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/2752/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"abd7ad027ff3caa3887f449492eb8ff77f2eb02a","subject":"Restore -dev suffix"}],"author":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"committer":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"subject":"tcl/board: Add Digilent Analog Discovery config","message":"tcl/board: Add Digilent Analog Discovery config\n\nChange-Id: Idf2cb8d8578e650fda4082f6bbf272518762ebf0\nSigned-off-by: Forest Crossman \u003ccyrozap@gmail.com\u003e\n"}},"78e8917cc9ec8b710e636401ba720fcc02be4c34":{"kind":"REWORK","_number":2,"created":"2015-04-29 22:53:32.000000000","uploader":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"ref":"refs/changes/52/2752/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/2752/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/2 \u0026\u0026 git checkout -b change-2752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/2752/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"abd7ad027ff3caa3887f449492eb8ff77f2eb02a","subject":"Restore -dev suffix"}],"author":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"committer":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 22:53:09.000000000","tz":-240},"subject":"tcl/board: Add Digilent Analog Discovery config","message":"tcl/board: Add Digilent Analog Discovery config\n\nChange-Id: Idf2cb8d8578e650fda4082f6bbf272518762ebf0\nSigned-off-by: Forest Crossman \u003ccyrozap@gmail.com\u003e\n"}},"75d92d3104ff16d29cf0e830a0fa37c8645efc19":{"kind":"REWORK","_number":3,"created":"2015-10-19 05:35:26.000000000","uploader":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"ref":"refs/changes/52/2752/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/2752/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/3 \u0026\u0026 git checkout -b change-2752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/2752/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70a14db147eb80398bb012d72dacec7b6adc18fe","subject":"Restore normal development cycle"}],"author":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"committer":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-10-19 05:34:57.000000000","tz":-240},"subject":"tcl/board: Add Digilent Analog Discovery config","message":"tcl/board: Add Digilent Analog Discovery config\n\nChange-Id: Idf2cb8d8578e650fda4082f6bbf272518762ebf0\nSigned-off-by: Forest Crossman \u003ccyrozap@gmail.com\u003e\n"}},"9cc7750f7dd268a73b8110f403199e71c42f5101":{"kind":"REWORK","_number":4,"created":"2015-10-19 06:00:15.000000000","uploader":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"ref":"refs/changes/52/2752/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/2752/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/4 \u0026\u0026 git checkout -b change-2752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/2752/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d52070c8552617b8631f80c117f43686f76e7c52","subject":"nrf51: recognize hwid 0084"}],"author":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"committer":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-10-19 06:00:02.000000000","tz":-240},"subject":"tcl/board: Add Digilent Analog Discovery config","message":"tcl/board: Add Digilent Analog Discovery config\n\nChange-Id: Idf2cb8d8578e650fda4082f6bbf272518762ebf0\nSigned-off-by: Forest Crossman \u003ccyrozap@gmail.com\u003e\n"}},"677dbf1823f8ddd2a98b39c4c5ed3b5b0fceb233":{"kind":"REWORK","_number":5,"created":"2015-10-30 11:53:05.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/52/2752/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/2752/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/5 \u0026\u0026 git checkout -b change-2752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/2752/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/2752/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3edb15784eca5bdd7981f7889909e273ad9775d1","subject":"tcl: Support for reading \"Device DNA\" from Spartan 6 devices."}],"author":{"name":"Forest Crossman","email":"cyrozap@gmail.com","date":"2015-04-29 07:29:10.000000000","tz":-240},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2015-10-30 11:53:05.000000000","tz":0},"subject":"tcl/board: Add Digilent Analog Discovery config","message":"tcl/board: Add Digilent Analog Discovery config\n\nChange-Id: Idf2cb8d8578e650fda4082f6bbf272518762ebf0\nSigned-off-by: Forest Crossman \u003ccyrozap@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/2752\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-by: Andreas Färber \u003cafaerber@suse.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}