)]}'
{"id":"openocd~master~Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f","project":"openocd","branch":"master","hashtags":[],"change_id":"Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f","subject":"AM335x: allow simultaneous debugging of A8 and M3 cores","status":"MERGED","created":"2015-10-13 10:07:06.000000000","updated":"2015-12-29 21:16:54.000000000","submitted":"2015-12-29 21:16:54.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c654278c3b1dd3fc0d5845fd49f2076324aa367a","_number":3013,"owner":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":1,"date":"2015-12-29 21:16:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":0,"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"value":2,"date":"2015-12-29 21:16:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-03 13:58:57.000000000","updated_by":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"reviewer":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"state":"REVIEWER"},{"updated":"2015-11-03 22:08:26.000000000","updated_by":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"reviewer":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"state":"REVIEWER"},{"updated":"2015-11-30 13:01:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-01 06:56:21.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2015-12-29 21:16:54.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"e345886e0e1636ede36979664b468e8ae0de377b","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-10-13 10:07:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1765542287b82b8a1fac876e98861b123ffe2cf5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-13 10:21:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6223/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5658/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"22def99e1bb61cf52c79f8a912885c7362359ee2","author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"real_author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"date":"2015-10-13 18:50:26.000000000","message":"Patch Set 1: Code-Review+1\n\nTested with AM335x Beagle Bone Black","accounts_in_message":[],"_revision_number":1},{"id":"8354cdb15921174168e36b2b64c54b36afb16cf8","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-10-31 21:37:46.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"bb20a1fca171b46d97453e3aa676edf92530f3dc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-31 21:50:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6393/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5814/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f533f891f7a71a8947f0e727600ae7191606fb27","author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"real_author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"date":"2015-11-03 13:58:57.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7dfdf8ec548f1cf5391080ca4a02d9a346c871b7","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2015-11-03 22:08:26.000000000","message":"Patch Set 2:\n\nThe only issue I see is that some parts use spaces for indention, while other parts use tabs. I think we should stick to tabs to be consistent with other configs.","accounts_in_message":[],"_revision_number":2},{"id":"9e48144a1abfc028ce317e42664e1169df3522ce","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-11-30 11:51:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2e603724ece89e24c6de4835175f32a2417e3313","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-11-30 13:01:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6646/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6065/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"96ca46988d47bd85151d642b23ebe3db323cec4b","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-12-01 06:56:21.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c654278c3b1dd3fc0d5845fd49f2076324aa367a","date":"2015-12-29 21:16:54.000000000","message":"Change has been successfully cherry-picked as 0627bc3b43d4803b648011eee6ee9a27e7d496aa by Andreas Fritiofson","accounts_in_message":[],"_revision_number":3}],"current_revision":"0627bc3b43d4803b648011eee6ee9a27e7d496aa","revisions":{"2473d691348eb80476225502158c53fcc54113c0":{"kind":"REWORK","_number":1,"created":"2015-10-13 10:07:06.000000000","uploader":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"ref":"refs/changes/13/3013/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3013/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/1 \u0026\u0026 git checkout -b change-3013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3013/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48787e19ef7b620569c362410efd7de5a583306d","subject":"flash/nor/spi: Add Winbond w25q128fv"}],"author":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-13 10:02:58.000000000","tz":120},"committer":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-13 10:06:29.000000000","tz":120},"subject":"AM335x: allow simultaneous debugging of A8 and M3 cores","message":"AM335x: allow simultaneous debugging of A8 and M3 cores\n\nThis patch fixes the tap order so that it matches the actual jtag\nchain when all taps are enabled. It also introduces a variable\nDEFAULT_TAPS that can be set outside of this script, e.g. on the\ncommand line, to specify which taps are to be enabled on init.\nLastly, a new debug target \"am335x.m3\" is added so that the Wakeup-M3\ncan be selected for debugging.\n\nChange-Id: Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f\nSigned-off-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"af79f5a9eae732572fb1be85d2ee94bfc282e730":{"kind":"REWORK","_number":3,"created":"2015-11-30 11:51:16.000000000","uploader":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"ref":"refs/changes/13/3013/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3013/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/3 \u0026\u0026 git checkout -b change-3013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3013/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7cebf9bedca184a273c37d9d466ce603ac652cfd","subject":"cortex_a: select APB-AP as the default AP"}],"author":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-13 10:02:58.000000000","tz":120},"committer":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-11-30 11:51:23.000000000","tz":60},"subject":"AM335x: allow simultaneous debugging of A8 and M3 cores","message":"AM335x: allow simultaneous debugging of A8 and M3 cores\n\nThis patch fixes the tap order so that it matches the actual jtag\nchain when all taps are enabled. It also introduces a variable\nDEFAULT_TAPS that can be set outside of this script, e.g. on the\ncommand line, to specify which taps are to be enabled on init.\nLastly, a new debug target \"am335x.m3\" is added so that the Wakeup-M3\ncan be selected for debugging.\n\nChange-Id: Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f\nSigned-off-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"056aecb17bf767ca07c169e1fdeeaac218b9fa8b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-10-31 21:37:46.000000000","uploader":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"ref":"refs/changes/13/3013/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3013/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/2 \u0026\u0026 git checkout -b change-3013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3013/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"afb083625c9ee7871004f9f6a00d04173ddf83f0","subject":"rtos: handle STKALIGN adjustments on cortex m"}],"author":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-13 10:02:58.000000000","tz":120},"committer":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-31 21:37:46.000000000","tz":0},"subject":"AM335x: allow simultaneous debugging of A8 and M3 cores","message":"AM335x: allow simultaneous debugging of A8 and M3 cores\n\nThis patch fixes the tap order so that it matches the actual jtag\nchain when all taps are enabled. It also introduces a variable\nDEFAULT_TAPS that can be set outside of this script, e.g. on the\ncommand line, to specify which taps are to be enabled on init.\nLastly, a new debug target \"am335x.m3\" is added so that the Wakeup-M3\ncan be selected for debugging.\n\nChange-Id: Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f\nSigned-off-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"0627bc3b43d4803b648011eee6ee9a27e7d496aa":{"kind":"REWORK","_number":4,"created":"2015-12-29 21:16:54.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/13/3013/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3013/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/4 \u0026\u0026 git checkout -b change-3013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3013/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3013/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8be5de75d021b5e01a6739fc70c793a6603467c","subject":"ADIv5: convert numeric values to use defines with meaningful names"}],"author":{"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","date":"2015-10-13 10:02:58.000000000","tz":120},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 21:16:54.000000000","tz":0},"subject":"AM335x: allow simultaneous debugging of A8 and M3 cores","message":"AM335x: allow simultaneous debugging of A8 and M3 cores\n\nThis patch fixes the tap order so that it matches the actual jtag\nchain when all taps are enabled. It also introduces a variable\nDEFAULT_TAPS that can be set outside of this script, e.g. on the\ncommand line, to specify which taps are to be enabled on init.\nLastly, a new debug target \"am335x.m3\" is added so that the Wakeup-M3\ncan be selected for debugging.\n\nChange-Id: Iccf177fda8d5e3737b1b2bb8fd1eaa7d3262ed9f\nSigned-off-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\nReviewed-on: http://openocd.zylin.com/3013\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
