)]}'
{"id":"openocd~master~Iad7ee06330b3259ea0ce0d174dfdade6785913eb","project":"openocd","branch":"master","hashtags":[],"change_id":"Iad7ee06330b3259ea0ce0d174dfdade6785913eb","subject":"tcl: add STM32F469 discovery board config","status":"MERGED","created":"2015-10-23 22:19:00.000000000","updated":"2015-11-03 21:38:02.000000000","submitted":"2015-11-03 21:38:02.000000000","submitter":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"62f1930b96cd31786eac6e482a4b52548fcaa066","_number":3043,"owner":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":1,"date":"2015-11-03 21:38:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"all":[{"value":1,"date":"2015-11-03 21:38:02.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},{"value":2,"date":"2015-11-03 21:38:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-24 12:11:32.000000000","updated_by":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"reviewer":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"state":"REVIEWER"},{"updated":"2015-10-28 11:10:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-10-31 14:35:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2015-11-03 21:38:02.000000000","updated_by":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"reviewer":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"state":"REVIEWER"}],"messages":[{"id":"f552d4ed6480c8c87cd465d31f8a31ec71bab70e","author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"real_author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"date":"2015-10-23 22:19:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cbe622636e01c3dd7c01f46a4f3c78a58f5fbaa4","author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"real_author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"date":"2015-10-23 22:23:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a22f929773c9e49dff7731dccc122033d42eaf61","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-23 22:53:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6285/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5719/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c0a81e980ad6a83254bd8578bfa9f073a9eed6f1","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-10-24 12:11:32.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nOne remaining copy\u0026paste issue.","accounts_in_message":[],"_revision_number":2},{"id":"b0311fc015333f73968be311a3d1db57fc1575ca","author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"real_author":{"_account_id":1000725,"name":"Andreas Färber","email":"afaerber@suse.de","username":"afaerber"},"date":"2015-10-24 12:17:33.000000000","message":"Patch Set 2:\n\nYour other patch has topic \"flash/nor/stm32f2x:\", so \"tcl/board:\" or \"tcl:\" may be more appropriate here as there is no \"cfg\" directory or file involved. But there\u0027s precedence for both in `git log --oneline -- tcl/board/`.","accounts_in_message":[],"_revision_number":2},{"id":"2554c430ec867ff356da0586ba0bc33e3c6675aa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2015-10-26 16:46:43.000000000","message":"Patch Set 2:\n\nTested on a board F469-discovery, together with the other patch.\nWaiting to get the link in line 3 fixed, as Andreas already pointed-out.","accounts_in_message":[],"_revision_number":2},{"id":"69dd65ce908d7114f2a5fde94243fe8c566b92ff","author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"real_author":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"date":"2015-10-27 20:06:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c9b1e3cb0841d5abc21e7112ca114c3be42c4eb3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-27 20:06:55.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/5731/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/6306/ : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"0d469bda6de7277844614605c789a8b6c20a58ab","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-28 09:19:30.000000000","message":"Patch Set 3:\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/5734/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit/6314/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"efb340a80e3f4cc91babe9779374128767dac8f5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-10-28 11:10:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6329/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/5750/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"41686e3fe9ed2279f2dd30131ece85cf5153f887","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2015-10-31 14:35:38.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e35d9520c18a67b12847507768d20d4e0f4ef9ea","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2015-11-03 21:32:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"62f1930b96cd31786eac6e482a4b52548fcaa066","date":"2015-11-03 21:38:02.000000000","message":"Change has been successfully cherry-picked as 26045588f462476cee356d15a24944d6c26befb4 by Freddie Chopin","accounts_in_message":[],"_revision_number":3}],"current_revision":"26045588f462476cee356d15a24944d6c26befb4","revisions":{"32e621d51dbe834b2ccf3f6e30c3fb18c72358ec":{"kind":"REWORK","_number":1,"created":"2015-10-23 22:19:00.000000000","uploader":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"ref":"refs/changes/43/3043/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/3043/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/1 \u0026\u0026 git checkout -b change-3043 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/3043/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"337ab7b51330c8399ea6132ba35ea4ebdc4e986a","subject":"flash/nor/stm32f2x: Add STM32F469 part"}],"author":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:13:38.000000000","tz":120},"committer":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:18:46.000000000","tz":120},"subject":"cfg: add STM32F469 discovery board config","message":"cfg: add STM32F469 discovery board config\n\nChange-Id: Iad7ee06330b3259ea0ce0d174dfdade6785913eb\nSigned-off-by: Maxime Coquelin \u003cmcoquelin.stm32@gmail.com\u003e\n"}},"01834f56b118c8f48aa92af00c6565b3873454fa":{"kind":"REWORK","_number":3,"created":"2015-10-27 20:06:32.000000000","uploader":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"ref":"refs/changes/43/3043/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/3043/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/3 \u0026\u0026 git checkout -b change-3043 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/3043/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"337ab7b51330c8399ea6132ba35ea4ebdc4e986a","subject":"flash/nor/stm32f2x: Add STM32F469 part"}],"author":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:13:38.000000000","tz":120},"committer":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-27 20:03:42.000000000","tz":60},"subject":"tcl: add STM32F469 discovery board config","message":"tcl: add STM32F469 discovery board config\n\nChange-Id: Iad7ee06330b3259ea0ce0d174dfdade6785913eb\nSigned-off-by: Maxime Coquelin \u003cmcoquelin.stm32@gmail.com\u003e\n"}},"b92ec2fbe22ff5a3aeb0a9fe1413ac7e1050c7a1":{"kind":"REWORK","_number":2,"created":"2015-10-23 22:23:51.000000000","uploader":{"_account_id":1001026,"name":"mcoquelin-stm32","email":"mcoquelin.stm32@gmail.com","username":"mcoquelin-stm32"},"ref":"refs/changes/43/3043/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/3043/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/2 \u0026\u0026 git checkout -b change-3043 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/3043/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"337ab7b51330c8399ea6132ba35ea4ebdc4e986a","subject":"flash/nor/stm32f2x: Add STM32F469 part"}],"author":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:13:38.000000000","tz":120},"committer":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:23:43.000000000","tz":120},"subject":"cfg: add STM32F469 discovery board config","message":"cfg: add STM32F469 discovery board config\n\nChange-Id: Iad7ee06330b3259ea0ce0d174dfdade6785913eb\nSigned-off-by: Maxime Coquelin \u003cmcoquelin.stm32@gmail.com\u003e\n"}},"26045588f462476cee356d15a24944d6c26befb4":{"kind":"REWORK","_number":4,"created":"2015-11-03 21:38:02.000000000","uploader":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"ref":"refs/changes/43/3043/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/3043/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/4 \u0026\u0026 git checkout -b change-3043 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/3043/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/3043/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e219648c80a27f0519003f3b088cbb846e255d8","subject":"flash/nor/stm32f2x: Add STM32F469 part"}],"author":{"name":"Maxime Coquelin","email":"mcoquelin.stm32@gmail.com","date":"2015-10-23 22:13:38.000000000","tz":120},"committer":{"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","date":"2015-11-03 21:38:02.000000000","tz":0},"subject":"tcl: add STM32F469 discovery board config","message":"tcl: add STM32F469 discovery board config\n\nChange-Id: Iad7ee06330b3259ea0ce0d174dfdade6785913eb\nSigned-off-by: Maxime Coquelin \u003cmcoquelin.stm32@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3043\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Freddie Chopin \u003cfreddie.chopin@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
