)]}'
{"id":"openocd~master~I3e64e11a43ba2396bd646a4cf8f9bc331805d802","project":"openocd","branch":"master","hashtags":[],"change_id":"I3e64e11a43ba2396bd646a4cf8f9bc331805d802","subject":"swd: Remove DAP from parameter list","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:26:45.000000000","submitted":"2015-12-29 20:26:45.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"faeec90fc48d3b95ca6ab1ac42ecdf5de4fc8f5f","_number":3141,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:26:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":2,"date":"2015-12-29 20:26:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 14:37:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-29 19:48:17.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"56aaf750c55d588981d8426dc8d040fbb26542b4","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79ac09064326b646590efebdb5d4f011828217c0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 14:37:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6672/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6091/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e6381b41e369c00b06b269e64ffa6f61ab763821","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2015-12-29 19:48:17.000000000","message":"Patch Set 1: Code-Review+2\n\nThis change makes perfect sense to me. Still, every driver needing to know when to insert those cycles seems to be a violation leading to code duplication but this patch is a step in the right direction, obviously.","accounts_in_message":[],"_revision_number":1},{"id":"faeec90fc48d3b95ca6ab1ac42ecdf5de4fc8f5f","date":"2015-12-29 20:26:45.000000000","message":"Change has been successfully cherry-picked as a6c4eb03455f6e97fc25183aae249d6ccdcbfb0f by Andreas Fritiofson","accounts_in_message":[],"_revision_number":1}],"current_revision":"a6c4eb03455f6e97fc25183aae249d6ccdcbfb0f","revisions":{"a6c4eb03455f6e97fc25183aae249d6ccdcbfb0f":{"kind":"REWORK","_number":2,"created":"2015-12-29 20:26:45.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/41/3141/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/3141/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/2 \u0026\u0026 git checkout -b change-3141 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/3141/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf4cf766310768198cfa766467d47bdb180f9b27","subject":"arm_debug: Support multiple APs per DAP and remove DAP from armv7* structs"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-11-13 22:48:46.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:26:45.000000000","tz":0},"subject":"swd: Remove DAP from parameter list","message":"swd: Remove DAP from parameter list\n\nMaking the SWD driver aware of the DAP that controls it is a layering\nviolation.\n\nThe only usage for the DAP pointer is to store the number of idle cycles\nthe AP may need to avoid WAITs. Replace the DAP pointer with a cycle\ncount hint instead to avoid future misuse.\n\nChange-Id: I3e64e11a43ba2396bd646a4cf8f9bc331805d802\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3141\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"b9efbb742a1e2aba2c25e6aa29ac71f680ece002":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/41/3141/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/3141/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/1 \u0026\u0026 git checkout -b change-3141 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/3141/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/3141/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8a1fa78a9df41ca15bd83769c6874e3eb70d92f","subject":"arm_debug: Support multiple APs per DAP and remove DAP from armv7* structs"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-11-13 22:48:46.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:08.000000000","tz":60},"subject":"swd: Remove DAP from parameter list","message":"swd: Remove DAP from parameter list\n\nMaking the SWD driver aware of the DAP that controls it is a layering\nviolation.\n\nThe only usage for the DAP pointer is to store the number of idle cycles\nthe AP may need to avoid WAITs. Replace the DAP pointer with a cycle\ncount hint instead to avoid future misuse.\n\nChange-Id: I3e64e11a43ba2396bd646a4cf8f9bc331805d802\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}