)]}'
{"id":"openocd~master~I3b33709ef55372ef14522ed4337e9f2e817ae3ab","project":"openocd","branch":"master","hashtags":[],"change_id":"I3b33709ef55372ef14522ed4337e9f2e817ae3ab","subject":"target/arm: Remove usage of struct arm_jtag in ARMv7 targets","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:27:01.000000000","submitted":"2015-12-29 20:27:01.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"62e3b9daf3a25d1f3fecdeb6af2a8c0193c3fdb8","_number":3142,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:27:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":1,"date":"2015-12-29 20:27:01.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":2,"date":"2015-12-29 20:27:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 14:50:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 12:28:00.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"e43292e0e9122e3f04601fa244b01161a9f459a1","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f4505bf25a6b27c5480d241ad838bb8338c46b0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 14:50:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6673/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6092/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"833c06a08224599199bf8dbf3a46ff1ed3867996","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:28:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1e1dbb6430558576dfca22f5f8b74c1446e3d743","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:26:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"62e3b9daf3a25d1f3fecdeb6af2a8c0193c3fdb8","date":"2015-12-29 20:27:01.000000000","message":"Change has been successfully cherry-picked as dc574aa1da291405c6778383c1ad3b252602aee7 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":1}],"current_revision":"dc574aa1da291405c6778383c1ad3b252602aee7","revisions":{"3c93385319720b77226c6f7caa32de5d504281ed":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/42/3142/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/3142/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/1 \u0026\u0026 git checkout -b change-3142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/3142/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9efbb742a1e2aba2c25e6aa29ac71f680ece002","subject":"swd: Remove DAP from parameter list"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-11-13 23:30:28.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:08.000000000","tz":60},"subject":"target/arm: Remove usage of struct arm_jtag in ARMv7 targets","message":"target/arm: Remove usage of struct arm_jtag in ARMv7 targets\n\nThe Cortex-A and Cortex-M keeps an arm_jtag struct around just to be\nable to pass a pointer to it to one common JTAG function which anyway\nonly uses the TAP field.\n\nRefactor the function to take a TAP directly, remove the legacy struct\nfrom cortex instances and store the TAP pointer only in the DAP.\n\nCortex-M makes a call to arm_jtag_setup_connection() with the struct\nbut the function does nothing useful for a Cortex-M target so remove\nthe call.\n\nChange-Id: I3b33709ef55372ef14522ed4337e9f2e817ae3ab\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"dc574aa1da291405c6778383c1ad3b252602aee7":{"kind":"REWORK","_number":2,"created":"2015-12-29 20:27:01.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/42/3142/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/3142/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/2 \u0026\u0026 git checkout -b change-3142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/3142/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/3142/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a6c4eb03455f6e97fc25183aae249d6ccdcbfb0f","subject":"swd: Remove DAP from parameter list"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-11-13 23:30:28.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:27:01.000000000","tz":0},"subject":"target/arm: Remove usage of struct arm_jtag in ARMv7 targets","message":"target/arm: Remove usage of struct arm_jtag in ARMv7 targets\n\nThe Cortex-A and Cortex-M keeps an arm_jtag struct around just to be\nable to pass a pointer to it to one common JTAG function which anyway\nonly uses the TAP field.\n\nRefactor the function to take a TAP directly, remove the legacy struct\nfrom cortex instances and store the TAP pointer only in the DAP.\n\nCortex-M makes a call to arm_jtag_setup_connection() with the struct\nbut the function does nothing useful for a Cortex-M target so remove\nthe call.\n\nChange-Id: I3b33709ef55372ef14522ed4337e9f2e817ae3ab\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3142\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}