)]}'
{"id":"openocd~master~I76bb9bd800697776a375ab803402780c3c7bea35","project":"openocd","branch":"master","hashtags":[],"change_id":"I76bb9bd800697776a375ab803402780c3c7bea35","subject":"cortex_a: Call ahbap_debugport_init on the discovered AP and not 0","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:27:42.000000000","submitted":"2015-12-29 20:27:42.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ed31b131f6ac7485c26eeb81a2088973531b6f4a","_number":3145,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":1,"date":"2015-12-29 20:27:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":2,"date":"2015-12-29 20:27:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:27:42.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 15:27:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 13:41:53.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"288a83a06d63957bfb4d3b016121b6d18f4f2003","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c53c9bbf1751511168865c8d2d2ed322190b46b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 15:27:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6676/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6095/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"102e209b2a7a4291e95711d00614bb4b0c59bfdd","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:41:09.000000000","message":"Patch Set 1:\n\nDoes this also select the \"active\" ap?  (dap apsel equivalent)","accounts_in_message":[],"_revision_number":1},{"id":"1305f092245a5742a25a7016b3f53962d31d896d","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-14 13:02:20.000000000","message":"Patch Set 1:\n\nDo you mean if ahbap_debugport_init() also sets dap-\u003eapsel? I don\u0027t think so. If it does at this commit, a later commit removes the selection.\n\nDoes it matter for correctness? Should it be selected?","accounts_in_message":[],"_revision_number":1},{"id":"e333df1d0e6aa2a6f6a08bd0d1d04060ca5a99b2","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 13:41:53.000000000","message":"Patch Set 1: Code-Review+1\n\nIt may be in the wrong place there. It\u0027s needed in cortex-a.","accounts_in_message":[],"_revision_number":1},{"id":"c8816ed35e3be73078ab885f238508d764bd5dd5","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:27:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ed31b131f6ac7485c26eeb81a2088973531b6f4a","date":"2015-12-29 20:27:42.000000000","message":"Change has been successfully cherry-picked as cd12c423dcc68c2a8ef3ba43a7b9f55e84de3d5d by Andreas Fritiofson","accounts_in_message":[],"_revision_number":1}],"current_revision":"cd12c423dcc68c2a8ef3ba43a7b9f55e84de3d5d","revisions":{"cd12c423dcc68c2a8ef3ba43a7b9f55e84de3d5d":{"kind":"REWORK","_number":2,"created":"2015-12-29 20:27:42.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/45/3145/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/3145/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/2 \u0026\u0026 git checkout -b change-3145 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/3145/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5ae2fbda2b8744752f9a8d5dbdb0090df812a894","subject":"arm_adi_v5: Add a back-pointer from an AP to its DAP"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 00:19:19.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:27:42.000000000","tz":0},"subject":"cortex_a: Call ahbap_debugport_init on the discovered AP and not 0","message":"cortex_a: Call ahbap_debugport_init on the discovered AP and not 0\n\nChange-Id: I76bb9bd800697776a375ab803402780c3c7bea35\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3145\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"86be5b56b6c1f11ce9000d5ee0805d84630539b6":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/45/3145/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/3145/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/1 \u0026\u0026 git checkout -b change-3145 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/3145/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/3145/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa5bc3351fb59975fc3fafe516a5e3830ba39224","subject":"arm_adi_v5: Add a back-pointer from an AP to its DAP"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 00:19:19.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:08.000000000","tz":60},"subject":"cortex_a: Call ahbap_debugport_init on the discovered AP and not 0","message":"cortex_a: Call ahbap_debugport_init on the discovered AP and not 0\n\nChange-Id: I76bb9bd800697776a375ab803402780c3c7bea35\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}