)]}'
{"id":"openocd~master~I39d7b134d78000564b7eec5bff464adf0ef89147","project":"openocd","branch":"master","hashtags":[],"change_id":"I39d7b134d78000564b7eec5bff464adf0ef89147","subject":"arm_adi_v5: Convert the AP references from numbers to pointers","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:28:33.000000000","submitted":"2015-12-29 20:28:33.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"41f82f8d4cfccd3f2cd5b1fbc0e42ec0c55e425e","_number":3147,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":1,"date":"2015-12-29 20:28:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":2,"date":"2015-12-29 20:28:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:28:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 15:52:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 12:42:40.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"06a0bc7a85b6491796f58bf1db81ffc10790a5e0","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4d1027b68bac9a2c06f2a98de246fbb5c1796e4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 15:52:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6678/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6097/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"027d7f686ba481c83928a6e2e974fa3effbb908c","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:42:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"eba1aa189ea6d6c25f404900a4036a54da38380b","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:28:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"41f82f8d4cfccd3f2cd5b1fbc0e42ec0c55e425e","date":"2015-12-29 20:28:33.000000000","message":"Change has been successfully cherry-picked as 557aa6dc5c596f2475d41c62e5a62c53d17dd421 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":1}],"current_revision":"557aa6dc5c596f2475d41c62e5a62c53d17dd421","revisions":{"557aa6dc5c596f2475d41c62e5a62c53d17dd421":{"kind":"REWORK","_number":2,"created":"2015-12-29 20:28:33.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/47/3147/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/3147/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/2 \u0026\u0026 git checkout -b change-3147 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/3147/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"beb843d28dd1dcf5ef4f761128bb2639913bfcfe","subject":"cortex_m: Discover the AP to use, just like Cortex-A"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 00:34:09.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:28:33.000000000","tz":0},"subject":"arm_adi_v5: Convert the AP references from numbers to pointers","message":"arm_adi_v5: Convert the AP references from numbers to pointers\n\nChange the debug_ap and memory_ap fields of the cortex_a target and\nthe debug_ap field of the cortex_m target to be pointers to the\nstruct adiv5_ap instead of AP numbers in some known DAP.\n\nThis reduces the dependency on the DAP struct in the targets and\nenables MEM-AP accesses to take the relevant AP as parameter.\n\nChange-Id: I39d7b134d78000564b7eec5bff464adf0ef89147\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3147\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"f6a31dd0e2b9d986d5d53b7de592fd9b178945be":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/47/3147/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/3147/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/1 \u0026\u0026 git checkout -b change-3147 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/3147/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/3147/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d3f3739c126ab2591371583a14c6a39c01dad71","subject":"cortex_m: Discover the AP to use, just like Cortex-A"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 00:34:09.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:08.000000000","tz":60},"subject":"arm_adi_v5: Convert the AP references from numbers to pointers","message":"arm_adi_v5: Convert the AP references from numbers to pointers\n\nChange the debug_ap and memory_ap fields of the cortex_a target and\nthe debug_ap field of the cortex_m target to be pointers to the\nstruct adiv5_ap instead of AP numbers in some known DAP.\n\nThis reduces the dependency on the DAP struct in the targets and\nenables MEM-AP accesses to take the relevant AP as parameter.\n\nChange-Id: I39d7b134d78000564b7eec5bff464adf0ef89147\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}