)]}'
{"id":"openocd~master~I6b98c3b4486903029e5a0d6d964bd5c48ff55926","project":"openocd","branch":"master","hashtags":[],"change_id":"I6b98c3b4486903029e5a0d6d964bd5c48ff55926","subject":"cortex_a: Find debug base using the detected APB-AP and not AP 1","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:28:45.000000000","submitted":"2015-12-29 20:28:45.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"edb26206c99d8b22a943eda5ca08e9ea75367eec","_number":3148,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:28:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":1,"date":"2015-12-29 20:28:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":2,"date":"2015-12-29 20:28:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 16:57:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 12:44:38.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"f0d9f59504dace8ddbba0ad9fc58f55a48f865c6","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e75b2f880adbe9f453db058aa1ade4323c9cc4f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 15:53:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/6679/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6098/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"abd8ed2fbddad3887dd3eb9a7f85a8f5f93ddd5a","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"477d5c9e99117773f1b71f77a2b3d24f2f3f72d3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 16:57:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6684/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6103/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"75679d3591eccc8cf3f6668f730376e11e4cbfe3","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:44:38.000000000","message":"Patch Set 2: Code-Review+1\n\nI guess the reason why debugging ever worked was that we usually specify the debug base at target creation instead of parsing the romtable, on cortex-a at least.","accounts_in_message":[],"_revision_number":2},{"id":"b243e7ffd79815793e56f604ce1c3c4715fac307","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:28:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"edb26206c99d8b22a943eda5ca08e9ea75367eec","date":"2015-12-29 20:28:45.000000000","message":"Change has been successfully cherry-picked as f9dfbf3ac75f65dad324fea641e08acca6a8a5e3 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"f9dfbf3ac75f65dad324fea641e08acca6a8a5e3","revisions":{"943905e62b2c53b7c7c67f5f0ed68d1ede5fc94b":{"kind":"REWORK","_number":2,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/48/3148/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/3148/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/2 \u0026\u0026 git checkout -b change-3148 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/3148/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f6a31dd0e2b9d986d5d53b7de592fd9b178945be","subject":"arm_adi_v5: Convert the AP references from numbers to pointers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:18:40.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:18:40.000000000","tz":60},"subject":"cortex_a: Find debug base using the detected APB-AP and not AP 1","message":"cortex_a: Find debug base using the detected APB-AP and not AP 1\n\nChange-Id: I6b98c3b4486903029e5a0d6d964bd5c48ff55926\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"f9dfbf3ac75f65dad324fea641e08acca6a8a5e3":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:28:45.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/48/3148/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/3148/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/3 \u0026\u0026 git checkout -b change-3148 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/3148/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"557aa6dc5c596f2475d41c62e5a62c53d17dd421","subject":"arm_adi_v5: Convert the AP references from numbers to pointers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:18:40.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:28:45.000000000","tz":0},"subject":"cortex_a: Find debug base using the detected APB-AP and not AP 1","message":"cortex_a: Find debug base using the detected APB-AP and not AP 1\n\nChange-Id: I6b98c3b4486903029e5a0d6d964bd5c48ff55926\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3148\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"005c30f60ba8b69a2cb33c00d60edabd21dad022":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/48/3148/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/3148/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/1 \u0026\u0026 git checkout -b change-3148 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/3148/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/3148/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f6a31dd0e2b9d986d5d53b7de592fd9b178945be","subject":"arm_adi_v5: Convert the AP references from numbers to pointers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 01:19:26.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:09.000000000","tz":60},"subject":"cortex_a: Find debug base using the detected APB-AP and not AP 1","message":"cortex_a: Find debug base using the detected APB-AP and not AP 1\n\nChange-Id: I6b98c3b4486903029e5a0d6d964bd5c48ff55926\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}