)]}'
{"id":"openocd~master~I8e86b7de61811382afe99bf15094ab71b43f5fdf","project":"openocd","branch":"master","hashtags":[],"change_id":"I8e86b7de61811382afe99bf15094ab71b43f5fdf","subject":"arm_adi_v5: Clean up dap info command","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:29:32.000000000","submitted":"2015-12-29 20:29:32.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8a816668c807f195c0139666a7b07f18d1b8c3ee","_number":3150,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":1,"date":"2015-12-29 20:29:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":2,"date":"2015-12-29 20:29:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:29:32.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 17:23:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 12:45:07.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"00ba8175d2744fd1e8645491fe78492a1086227c","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c6b915ca2acbdaef492046751eb62c8ee9030bf","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 16:18:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6681/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6100/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ceb11d69afef642e7a815dd5e6ac04dad83abf1f","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"39a44e039199f351bb99db75997cffafd35c08cc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 17:23:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6686/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6105/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"427229de94d790f063cdd5d74520ba0787975438","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:45:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0e0001b42159754f030c6c6fb4212e9908635f08","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:29:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8a816668c807f195c0139666a7b07f18d1b8c3ee","date":"2015-12-29 20:29:32.000000000","message":"Change has been successfully cherry-picked as c6ce183055acebcc1c5ef004f2f6f4a4042700dd by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"c6ce183055acebcc1c5ef004f2f6f4a4042700dd","revisions":{"c6ce183055acebcc1c5ef004f2f6f4a4042700dd":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:29:32.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/50/3150/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/3150/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/3 \u0026\u0026 git checkout -b change-3150 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/3150/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a069b7b906fd7ce9c19439e2db2f116e8942b65","subject":"arm_adi_v5: Change mem_ap calls to take pointer to AP and not DAP"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 12:06:12.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:29:32.000000000","tz":0},"subject":"arm_adi_v5: Clean up dap info command","message":"arm_adi_v5: Clean up dap info command\n\nReduce use of magic numbers and add AXI type MEM-AP detection. Don\u0027t try\nto call dap_rom_display on a non-existent AP.\n\nAP identification is unique per designer, so make sure the JEDEC code\nmatches ARM when interpreting the AP type.\n\nChange-Id: I8e86b7de61811382afe99bf15094ab71b43f5fdf\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3150\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"aac7e91f3567e0e148f43717ab108b4cc7469072":{"kind":"NO_CHANGE","_number":2,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/50/3150/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/3150/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/2 \u0026\u0026 git checkout -b change-3150 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/3150/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"17748feae90c666ac9ca7abe30d5baa17565a686","subject":"arm_adi_v5: Change mem_ap calls to take pointer to AP and not DAP"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 12:06:12.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:19:50.000000000","tz":60},"subject":"arm_adi_v5: Clean up dap info command","message":"arm_adi_v5: Clean up dap info command\n\nReduce use of magic numbers and add AXI type MEM-AP detection. Don\u0027t try\nto call dap_rom_display on a non-existent AP.\n\nAP identification is unique per designer, so make sure the JEDEC code\nmatches ARM when interpreting the AP type.\n\nChange-Id: I8e86b7de61811382afe99bf15094ab71b43f5fdf\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"0e7e382e4adaf1e002a92db79b2439d5e6c19279":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/50/3150/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/3150/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/1 \u0026\u0026 git checkout -b change-3150 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/3150/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/3150/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbe3d1dd5f1ef72dd24a899c82d31ac8a4be2ede","subject":"arm_adi_v5: Change mem_ap calls to take pointer to AP and not DAP"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 12:06:12.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:09.000000000","tz":60},"subject":"arm_adi_v5: Clean up dap info command","message":"arm_adi_v5: Clean up dap info command\n\nReduce use of magic numbers and add AXI type MEM-AP detection. Don\u0027t try\nto call dap_rom_display on a non-existent AP.\n\nAP identification is unique per designer, so make sure the JEDEC code\nmatches ARM when interpreting the AP type.\n\nChange-Id: I8e86b7de61811382afe99bf15094ab71b43f5fdf\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}