)]}'
{"id":"openocd~master~I92f55e09754a93f3f01dd8e5aa1ffdf60c856126","project":"openocd","branch":"master","hashtags":[],"change_id":"I92f55e09754a93f3f01dd8e5aa1ffdf60c856126","subject":"arm_adi_v5: Split ahbap_debugport_init","status":"MERGED","created":"2015-12-06 13:14:14.000000000","updated":"2015-12-29 20:29:46.000000000","submitted":"2015-12-29 20:29:46.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7adb217f4883489b002caea952fdc64a2a6c6251","_number":3151,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":1,"date":"2015-12-29 20:29:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":2,"date":"2015-12-29 20:29:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:29:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-06 17:36:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-14 12:45:50.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"3e66acf0532e22b5ec3ede4128ede2a4c474412f","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 13:14:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d63495ab13c6bff765b1f5c5dea1b8f7eb2501f6","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"32c446dcac356471c66e8869b8d646a0bebf0813","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 16:30:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/6682/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6101/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"9fb723940611a2ba4d64d4533eb2055e7db28a2b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 17:36:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6687/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6106/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"99caf046c0aca3d963fdf7672a7d96f5c3286ce8","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:45:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"53d05c94fd09861ba0c091093bba4d1ab9c98686","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:29:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7adb217f4883489b002caea952fdc64a2a6c6251","date":"2015-12-29 20:29:46.000000000","message":"Change has been successfully cherry-picked as 00dbc185ee56e68fac04935f388259d13ecef315 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"00dbc185ee56e68fac04935f388259d13ecef315","revisions":{"af159434ea7677c2113c26260becaccc2768bd54":{"kind":"REWORK","_number":1,"created":"2015-12-06 13:14:14.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/51/3151/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/3151/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/1 \u0026\u0026 git checkout -b change-3151 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/3151/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0e7e382e4adaf1e002a92db79b2439d5e6c19279","subject":"arm_adi_v5: Clean up dap info command"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:04:24.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:13:09.000000000","tz":60},"subject":"arm_adi_v5: Split ahbap_debugport_init","message":"arm_adi_v5: Split ahbap_debugport_init\n\nThis function does two separate things, powering up the DP and setting\nup a MEM-AP. But the DP needs to be powered before even searching for a\nMEM-AP to initialize and targets may have multiple MEM-APs that need\ninitializing.\n\nSplit the function into dap_dp_init() and mem_ap_init() and change all\ncall sites to use the appropriate one.\n\nChange-Id: I92f55e09754a93f3f01dd8e5aa1ffdf60c856126\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"00dbc185ee56e68fac04935f388259d13ecef315":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:29:46.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/51/3151/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/3151/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/3 \u0026\u0026 git checkout -b change-3151 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/3151/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c6ce183055acebcc1c5ef004f2f6f4a4042700dd","subject":"arm_adi_v5: Clean up dap info command"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:04:24.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:29:46.000000000","tz":0},"subject":"arm_adi_v5: Split ahbap_debugport_init","message":"arm_adi_v5: Split ahbap_debugport_init\n\nThis function does two separate things, powering up the DP and setting\nup a MEM-AP. But the DP needs to be powered before even searching for a\nMEM-AP to initialize and targets may have multiple MEM-APs that need\ninitializing.\n\nSplit the function into dap_dp_init() and mem_ap_init() and change all\ncall sites to use the appropriate one.\n\nChange-Id: I92f55e09754a93f3f01dd8e5aa1ffdf60c856126\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3151\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"0807991d86550a31027f17f4f9663a42d11d0076":{"kind":"REWORK","_number":2,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/51/3151/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/3151/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/2 \u0026\u0026 git checkout -b change-3151 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/3151/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/3151/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aac7e91f3567e0e148f43717ab108b4cc7469072","subject":"arm_adi_v5: Clean up dap info command"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 13:04:24.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:25:08.000000000","tz":60},"subject":"arm_adi_v5: Split ahbap_debugport_init","message":"arm_adi_v5: Split ahbap_debugport_init\n\nThis function does two separate things, powering up the DP and setting\nup a MEM-AP. But the DP needs to be powered before even searching for a\nMEM-AP to initialize and targets may have multiple MEM-APs that need\ninitializing.\n\nSplit the function into dap_dp_init() and mem_ap_init() and change all\ncall sites to use the appropriate one.\n\nChange-Id: I92f55e09754a93f3f01dd8e5aa1ffdf60c856126\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}