)]}'
{"id":"openocd~master~Ib193d8930fabb6a25715064355f98258c9580b5d","project":"openocd","branch":"master","hashtags":[],"change_id":"Ib193d8930fabb6a25715064355f98258c9580b5d","subject":"arm_adi_v5: Remove all mem_ap_sel_* functions","status":"MERGED","created":"2015-12-06 16:30:30.000000000","updated":"2015-12-29 20:31:20.000000000","submitted":"2015-12-29 20:31:20.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25f0f170f845cf2f5d9d0f6835b8f5c5c9224945","_number":3153,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:31:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":1,"date":"2015-12-29 20:31:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":2,"date":"2015-12-29 20:31:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-28 19:04:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-28 21:18:04.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"cb6d5aae7fc1cca87ee6655478b80fd51a9a7654","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2208e211ca02746e692e2b6854e57c20e72d90c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 18:01:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6689/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6108/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"43f55d66a1164f0e3eaacd3fa423ee7b5b2252dd","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 11:17:22.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"44bae5907ff0e978c1bbd62fa8d549399cfbb3f4","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-14 13:03:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"973eb0653cb67058dd079312151ceda573ce0dd0","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-28 17:53:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"12413e9dc268731245456ba1d15a769160db735b","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-28 18:04:57.000000000","message":"Patch Set 2:\n\nFixed the Doxygen headers","accounts_in_message":[],"_revision_number":2},{"id":"764fcef6ed1f0a834017bb165042ea21d563ab9c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-28 19:04:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6755/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6173/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3734b7884b5d7f3cababfabb76a30fd365a6de7b","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-28 21:18:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7d6c2e3eea46f5f4c236e229a8efe4a7cb4b56da","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:30:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"25f0f170f845cf2f5d9d0f6835b8f5c5c9224945","date":"2015-12-29 20:31:20.000000000","message":"Change has been successfully cherry-picked as 4a7bb931e37e54e8b0cd9d3a6b41c693d1042106 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"4a7bb931e37e54e8b0cd9d3a6b41c693d1042106","revisions":{"f4dfae50667f678b91d3e29234ce26487de0fd7c":{"kind":"REWORK","_number":1,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/53/3153/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/3153/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/1 \u0026\u0026 git checkout -b change-3153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/3153/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3c698c6755a6e74764cd8a7bce540de0803e0281","subject":"arm_adi_v5: Rename TAR and CSW setters and make them AP-specific"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 15:23:17.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:25:08.000000000","tz":60},"subject":"arm_adi_v5: Remove all mem_ap_sel_* functions","message":"arm_adi_v5: Remove all mem_ap_sel_* functions\n\nAll mem_ap_* functions now make sure the SELECT register is updated with\nthe AP number that it\u0027s operating on. This shouldn\u0027t have to be handled\nexplicitly.\n\nChange-Id: Ib193d8930fabb6a25715064355f98258c9580b5d\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"586c986498cb1e81fe46c0e0fd54ebf47923063a":{"kind":"REWORK","_number":2,"created":"2015-12-28 17:53:21.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/53/3153/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/3153/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/2 \u0026\u0026 git checkout -b change-3153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/3153/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3c698c6755a6e74764cd8a7bce540de0803e0281","subject":"arm_adi_v5: Rename TAR and CSW setters and make them AP-specific"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-28 17:43:22.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-28 17:43:22.000000000","tz":60},"subject":"arm_adi_v5: Remove all mem_ap_sel_* functions","message":"arm_adi_v5: Remove all mem_ap_sel_* functions\n\nAll mem_ap_* functions now make sure the SELECT register is updated with\nthe AP number that it\u0027s operating on. This shouldn\u0027t have to be handled\nexplicitly.\n\nChange-Id: Ib193d8930fabb6a25715064355f98258c9580b5d\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"4a7bb931e37e54e8b0cd9d3a6b41c693d1042106":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:31:20.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/53/3153/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/3153/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/3 \u0026\u0026 git checkout -b change-3153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/3153/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/3153/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4da8915fb93369cfe21a86ff208813736cf9d9d9","subject":"arm_adi_v5: Rename TAR and CSW setters and make them AP-specific"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-28 17:43:22.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:31:19.000000000","tz":0},"subject":"arm_adi_v5: Remove all mem_ap_sel_* functions","message":"arm_adi_v5: Remove all mem_ap_sel_* functions\n\nAll mem_ap_* functions now make sure the SELECT register is updated with\nthe AP number that it\u0027s operating on. This shouldn\u0027t have to be handled\nexplicitly.\n\nChange-Id: Ib193d8930fabb6a25715064355f98258c9580b5d\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3153\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}