)]}'
{"id":"openocd~master~I97580a0662dcf02e80646e45445cdbfc251122d8","project":"openocd","branch":"master","hashtags":[],"change_id":"I97580a0662dcf02e80646e45445cdbfc251122d8","subject":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck","status":"MERGED","created":"2015-12-06 16:30:30.000000000","updated":"2015-12-29 20:31:35.000000000","submitted":"2015-12-29 20:31:35.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f668062f41fee6499022822774cb66e96a7f1ad","_number":3154,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":1,"date":"2015-12-29 20:31:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":1,"date":"2015-12-29 20:31:35.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":2,"date":"2015-12-29 20:31:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-28 19:29:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-28 21:17:55.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"57575f6179e0d6194923694760f40eae5fa894f9","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c78dcf2ac89466e06c7efa664b255ec81bb6642d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 18:14:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6690/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6109/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8ab64b394701626038b518533d4ea998218a0648","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:47:17.000000000","message":"Patch Set 1:\n\nWhy? Because not useful? Due to TAR auto-increment?","accounts_in_message":[],"_revision_number":1},{"id":"da81e870748958e2aead0d9f0a220f6158af83c7","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-14 12:53:47.000000000","message":"Patch Set 1:\n\nIf some code does\n\n dap_ap_select(ap 0);\n dap_queue_apxxx();\n dap_ap_select(ap 1);\n dap_queue_apxxx();\n dap_run();\n\nand the AP 0 access fails, this code will print the TAR and CSW for AP 1.\n\nAnyway, at this level you can\u0027t assume that the AP is even an MEM-AP, it could be something else, with unknown side-effects from reading what would be TAR/CSW.","accounts_in_message":[],"_revision_number":1},{"id":"b61872b07bffa9c15dbb60ce8dd85ad3af559b4a","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 13:37:56.000000000","message":"Patch Set 1: Code-Review+1\n\nok","accounts_in_message":[],"_revision_number":1},{"id":"bfe4f0d588fa2c09007e9427c11537581db59351","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-28 17:53:21.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"e6e320b607d02cf2d00f7ee62ce993115cdbe3a6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-28 19:29:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6757/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6175/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"fc17685bd31880b42874d057363f3f79a4e1378a","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-28 21:17:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"9fa11b0b2d1d42ea68e892049b77826128e0c55d","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:31:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7f668062f41fee6499022822774cb66e96a7f1ad","date":"2015-12-29 20:31:35.000000000","message":"Change has been successfully cherry-picked as 1d17b32829e1b89d5d9c045c7b7b3ceb98e5f4f4 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"1d17b32829e1b89d5d9c045c7b7b3ceb98e5f4f4","revisions":{"bb25a5eeb7eece1cdc09ef4aa990ee2c8c864dec":{"kind":"REWORK","_number":1,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/54/3154/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/3154/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/1 \u0026\u0026 git checkout -b change-3154 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/3154/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4dfae50667f678b91d3e29234ce26487de0fd7c","subject":"arm_adi_v5: Remove all mem_ap_sel_* functions"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 15:29:36.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:25:08.000000000","tz":60},"subject":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck","message":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck\n\nThe AP for which the TAR/CSW is printed may not be the one that caused\nthe failure. Remove the flawed output entirely. The correct info is\nprinted in mem_ap_read/write anyway.\n\nChange-Id: I97580a0662dcf02e80646e45445cdbfc251122d8\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"98acd31474748c42a886780ff18090d95763ab9c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-12-28 17:53:21.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/54/3154/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/3154/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/2 \u0026\u0026 git checkout -b change-3154 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/3154/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"586c986498cb1e81fe46c0e0fd54ebf47923063a","subject":"arm_adi_v5: Remove all mem_ap_sel_* functions"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 15:29:36.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-28 17:43:32.000000000","tz":60},"subject":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck","message":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck\n\nThe AP for which the TAR/CSW is printed may not be the one that caused\nthe failure. Remove the flawed output entirely. The correct info is\nprinted in mem_ap_read/write anyway.\n\nChange-Id: I97580a0662dcf02e80646e45445cdbfc251122d8\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"1d17b32829e1b89d5d9c045c7b7b3ceb98e5f4f4":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:31:35.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/54/3154/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/3154/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/3 \u0026\u0026 git checkout -b change-3154 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/3154/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/3154/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a7bb931e37e54e8b0cd9d3a6b41c693d1042106","subject":"arm_adi_v5: Remove all mem_ap_sel_* functions"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 15:29:36.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:31:35.000000000","tz":0},"subject":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck","message":"adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck\n\nThe AP for which the TAR/CSW is printed may not be the one that caused\nthe failure. Remove the flawed output entirely. The correct info is\nprinted in mem_ap_read/write anyway.\n\nChange-Id: I97580a0662dcf02e80646e45445cdbfc251122d8\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3154\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}