)]}'
{"id":"openocd~master~Icacb0c76ef2a5ac36b4d2f26b52ec01a8850286e","project":"openocd","branch":"master","hashtags":[],"change_id":"Icacb0c76ef2a5ac36b4d2f26b52ec01a8850286e","subject":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()","status":"MERGED","created":"2015-12-06 16:30:30.000000000","updated":"2015-12-29 20:32:10.000000000","submitted":"2015-12-29 20:32:10.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"893c26a144569694e179fbeccd98a9cd0e4eeb29","_number":3156,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":1,"date":"2015-12-29 20:32:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":1,"date":"2015-12-29 20:32:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":2,"date":"2015-12-29 20:32:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-16 10:34:20.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2015-12-28 18:51:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-12-28 21:17:19.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"}],"messages":[{"id":"395d66cf88e397c315b30fb9385115139e70f557","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-06 16:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e759477491a2d9a51d5d2235ba84d710fab98ecc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-06 18:39:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6692/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6111/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"00bc42590a04ead543ae7ffdccdcf8634c9be7b0","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-14 12:48:03.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5011b74ea9c751e91828f82b5acda02cefc90ca2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2015-12-16 10:34:20.000000000","message":"Patch Set 1: Code-Review+1\n\nMDM-AP access tested on Kinetis K02 and K66. No regression found.","accounts_in_message":[],"_revision_number":1},{"id":"ec4c4697c74198bcdecac0ffc79bb2e2f53bbc21","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-28 17:53:21.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"694567e4a4cdc954261cbc0dea6462b23eeb5fc4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2015-12-28 18:51:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/6754/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/6172/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"cbc56c0553a96f7d641f65002eab4c9ee967c948","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2015-12-28 21:17:19.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"212e567105c5a855031cb8d249e2ab166335e7f2","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2015-12-29 20:32:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"893c26a144569694e179fbeccd98a9cd0e4eeb29","date":"2015-12-29 20:32:10.000000000","message":"Change has been successfully cherry-picked as e7d165f3dbff0fbe11f458becdccbb3d4fa8ccc4 by Andreas Fritiofson","accounts_in_message":[],"_revision_number":2}],"current_revision":"e7d165f3dbff0fbe11f458becdccbb3d4fa8ccc4","revisions":{"f20e76c084a0fdd46a8a4893b875dabf39af3cd0":{"kind":"REWORK","_number":1,"created":"2015-12-06 16:30:30.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/56/3156/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/3156/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/1 \u0026\u0026 git checkout -b change-3156 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/3156/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9dca6127205ed585735789a5c8b8b6f4c8ba8695","subject":"cortex: Set default memaccess_tck only during examine"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:16:31.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:25:08.000000000","tz":60},"subject":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()","message":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()\n\nAll AP operations should select the AP to use before calling it so\nthere\u0027s no point in restoring the previous value afterwards.\n\nThe explicit call to dap_ap_select() before all AP operations should be\nmoved into dap_queue_ap_read/write() which then would have to take the\nAP as an argument instead of the DAP.\n\nChange-Id: Icacb0c76ef2a5ac36b4d2f26b52ec01a8850286e\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"f08c1cab32ee2ba3ffa0c4e25588a9b0841afb3d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-12-28 17:53:21.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/56/3156/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/3156/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/2 \u0026\u0026 git checkout -b change-3156 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/3156/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"081029667925767d5495dd081cb63915e65c5855","subject":"cortex: Set default memaccess_tck only during examine"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:16:31.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-28 17:43:32.000000000","tz":60},"subject":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()","message":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()\n\nAll AP operations should select the AP to use before calling it so\nthere\u0027s no point in restoring the previous value afterwards.\n\nThe explicit call to dap_ap_select() before all AP operations should be\nmoved into dap_queue_ap_read/write() which then would have to take the\nAP as an argument instead of the DAP.\n\nChange-Id: Icacb0c76ef2a5ac36b4d2f26b52ec01a8850286e\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"e7d165f3dbff0fbe11f458becdccbb3d4fa8ccc4":{"kind":"REWORK","_number":3,"created":"2015-12-29 20:32:10.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/56/3156/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/3156/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/3 \u0026\u0026 git checkout -b change-3156 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/3156/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/3156/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d84c7d91960bbba0079268d165f0bb29a0da4d86","subject":"cortex: Set default memaccess_tck only during examine"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-06 16:16:31.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2015-12-29 20:32:10.000000000","tz":0},"subject":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()","message":"arm_adi_v5: Remove all cases of \"restoring\" previous dap_ap_select()\n\nAll AP operations should select the AP to use before calling it so\nthere\u0027s no point in restoring the previous value afterwards.\n\nThe explicit call to dap_ap_select() before all AP operations should be\nmoved into dap_queue_ap_read/write() which then would have to take the\nAP as an argument instead of the DAP.\n\nChange-Id: Icacb0c76ef2a5ac36b4d2f26b52ec01a8850286e\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3156\nTested-by: jenkins\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}