)]}'
{"src/target/adi_v5_jtag.c":[{"author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"change_message_id":"e8236411a9a700c9d00e3a4d5723e077a6565f97","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#ifdef DEBUG_WAIT"},{"line_number":59,"context_line":"static const char *dap_reg_name(int instr, int reg_addr)"},{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"\tchar *reg_name \u003d \"UNK\";"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"\tif (instr \u003d\u003d JTAG_DP_DPACC) {"},{"line_number":64,"context_line":"\t\tswitch (reg_addr) {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_cba849dd","line":61,"updated":"2015-12-29 01:14:20.000000000","message":"If you move DEBUG_WAIT to the body of the function, you don\u0027t need #ifdef DEBUG_WAIT in all callers","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"change_message_id":"de972f953fa89868323329b055e9ef32d5ba817f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#ifdef DEBUG_WAIT"},{"line_number":59,"context_line":"static const char *dap_reg_name(int instr, int reg_addr)"},{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"\tchar *reg_name \u003d \"UNK\";"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"\tif (instr \u003d\u003d JTAG_DP_DPACC) {"},{"line_number":64,"context_line":"\t\tswitch (reg_addr) {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_ab7ea514","line":61,"in_reply_to":"e99d9970_cba849dd","updated":"2015-12-29 21:49:58.000000000","message":"Yes, but there is only one caller.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"change_message_id":"e8236411a9a700c9d00e3a4d5723e077a6565f97","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"\tchar *reg_name \u003d \"UNK\";"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"\tif (instr \u003d\u003d JTAG_DP_DPACC) {"},{"line_number":64,"context_line":"\t\tswitch (reg_addr) {"},{"line_number":65,"context_line":"\t\tcase DP_ABORT:"},{"line_number":66,"context_line":"\t\t\treg_name \u003d  \"ABORT\";"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_ebb50d32","line":63,"updated":"2015-12-29 01:14:20.000000000","message":"This could be two nested switch statements.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"change_message_id":"de972f953fa89868323329b055e9ef32d5ba817f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"\tchar *reg_name \u003d \"UNK\";"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"\tif (instr \u003d\u003d JTAG_DP_DPACC) {"},{"line_number":64,"context_line":"\t\tswitch (reg_addr) {"},{"line_number":65,"context_line":"\t\tcase DP_ABORT:"},{"line_number":66,"context_line":"\t\t\treg_name \u003d  \"ABORT\";"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_cb7be923","line":63,"in_reply_to":"e99d9970_ebb50d32","updated":"2015-12-29 21:49:58.000000000","message":"That would not improve legibility, IMHO.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"change_message_id":"e8236411a9a700c9d00e3a4d5723e077a6565f97","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_0bb3314d","line":172,"updated":"2015-12-29 01:14:20.000000000","message":"cmd-\u003einvalue \u003d invalue ?: (uint8_t *) \u0026cmd-\u003edef_invalue;\n\nMaybe openocd\u0027s style guidelines are against above ? no idea","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"change_message_id":"de972f953fa89868323329b055e9ef32d5ba817f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_eb78ad29","line":172,"in_reply_to":"e99d9970_0bb3314d","updated":"2015-12-29 21:49:58.000000000","message":"Don\u0027t know either. At least it passes tools/checkpatch inspection (and jenkins doesn\u0027t complain, either)","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"136d657c098f1bdfc83c7c4bd86b95881eb52a98","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_8b064185","line":172,"in_reply_to":"e99d9970_4b0c59a7","updated":"2015-12-30 13:56:19.000000000","message":"This IS the verbose form... The non-standard GCC extension would be as Felipe wrote above. Keep it as it is, that\u0027s fine (preferred).\n\nBut the pointer cast is not OK. Make sure def_invalue is of the correct type.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"change_message_id":"b45034b1530d961c448b5f6cb7d48135ba9d621e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_4b0c59a7","line":172,"in_reply_to":"e99d9970_6b967d3f","updated":"2015-12-30 13:20:20.000000000","message":"OK, but I\u0027ll keep log_dap_cmd() as it is. Verbose form will introduce temp variables.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"a10f5ee6959ce688c9519ad3826159c608d364f9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_cbf76989","line":172,"in_reply_to":"e99d9970_8b064185","updated":"2015-12-30 14:02:39.000000000","message":"To be fair, this it the only kind of pointer cast that is somewhat acceptable. But I have a general aversion to pointer casts and while this one is safe, it\u0027s just as easy to avoid it.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"24e4df1eb9b98e8a17f4c7246e8f63fe3049e48c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\t\tcmd-\u003eRnW \u003d RnW;"},{"line_number":170,"context_line":"\t\tif (outvalue !\u003d NULL)"},{"line_number":171,"context_line":"\t\t\tmemcpy(cmd-\u003eoutvalue, outvalue, 4);"},{"line_number":172,"context_line":"\t\tcmd-\u003einvalue \u003d (invalue !\u003d NULL) ? invalue : (uint8_t *)\u0026cmd-\u003edef_invalue;"},{"line_number":173,"context_line":"\t\tcmd-\u003ememaccess_tck \u003d memaccess_tck;"},{"line_number":174,"context_line":"\t}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e99d9970_6b967d3f","line":172,"in_reply_to":"e99d9970_eb78ad29","updated":"2015-12-29 22:03:26.000000000","message":"I\u0027ve replaced ?: with the verbose form in one of my own changes after review, if that\u0027s any precedence.\n\nIMHO, it\u0027s not really worth deviating further from standard C for that operator.","commit_id":"5105eef8d138a2edf3297850b4ac3bfae0206fda"}]}