)]}'
{"id":"openocd~master~I0a80746e2075c7df1ce35b9db00d9d0b997a3feb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002186":{"account":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"last_update":"2023-11-18 11:29:49.000000000","reason":"Change was submitted"},"1000410":{"account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"last_update":"2023-11-09 20:57:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000410\u003e replied on the change","reason_account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}},"1001086":{"account":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"last_update":"2023-11-18 11:29:49.000000000","reason":"Change was submitted"},"1002205":{"account":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"last_update":"2023-11-18 11:29:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0a80746e2075c7df1ce35b9db00d9d0b997a3feb","subject":"mips32: MIPS32_OP_SRL was using SRA opcode.","status":"MERGED","created":"2016-08-01 18:33:40.000000000","updated":"2023-11-18 11:29:49.000000000","submitted":"2023-11-18 11:29:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3613","meta_rev_id":"d362007e7f05872476b207a536ec0acb46a7fc40","_number":3613,"owner":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:29:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:29:49.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:29:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-01 18:58:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-09 12:59:33.000000000","updated_by":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"reviewer":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"state":"REVIEWER"},{"updated":"2023-11-09 13:47:22.000000000","updated_by":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"reviewer":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"state":"REVIEWER"},{"updated":"2023-11-09 13:47:22.000000000","updated_by":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2023-11-18 11:29:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d43bd4816243e73224819c72d9a814d5c095426e","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2016-08-01 18:33:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b557fbb53b5f36933a9db0af0425b4462f864993","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2016-08-01 18:58:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit-build/7152/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit/7746/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"12eff7a53e5b562eb684d31fea4ffd64d3a5f051","author":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"real_author":{"_account_id":1002205,"name":"Matsievskiy S.V.","display_name":"Sergey Matsievskiy","email":"matsievskiysv@gmail.com","username":"matsievskiysv"},"date":"2023-11-09 12:59:33.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cad33ed46827442302b73fc6f9a3021f21caac73","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2023-11-09 14:12:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c00ce542368d4ca6a88c55c489769146cea15595","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2023-11-09 14:41:34.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cd7cfd83b7af1559f8bc846566dd6c5f5373174e","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 15:11:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"52f99aeabefb7c753af4765d78b29315e837b1a1","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2023-11-09 16:48:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fca1ce557be423f6e17ac13eb3c97cc868d3c472","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 17:02:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f9cb7a2bda693ffcc33627a31d14a0b9c720022b","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 17:05:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"52288b98fb4b589e52f54026d41612640c9d1230","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2023-11-09 17:25:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4f522a6e072f46128d08b209c7e10f4feb331ded","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 20:16:22.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5b4d900d9b9ec85b96412f0ed8a70d7e8073bc18","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-09 20:17:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/18695/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17879/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"1e848aca73179b91e975084f200297cae2487f52","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 20:18:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c7f0981cc43db98e3996a463f7ff4fbec65fafb9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"real_author":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"date":"2023-11-09 20:21:12.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"d4d9151d296d713754582f27392348b284b32703","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-09 20:47:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18696/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17880/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9bcb3bf55bac8c05b6f686d87f189433c5a0821c","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2023-11-09 20:57:18.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"689d8506831bcf98d6c7b9fa2f344507c0d5ad17","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:29:45.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"d362007e7f05872476b207a536ec0acb46a7fc40","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:29:49.000000000","message":"Change has been successfully cherry-picked as 62b526dbbdec073cdcf95bf5cdf622401aa55e78","accounts_in_message":[],"_revision_number":4}],"current_revision":"62b526dbbdec073cdcf95bf5cdf622401aa55e78","revisions":{"62b526dbbdec073cdcf95bf5cdf622401aa55e78":{"kind":"REWORK","_number":4,"created":"2023-11-18 11:29:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/13/3613/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3613/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/4 \u0026\u0026 git checkout -b change-3613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3613/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f55b122b42c212fcb3219e372a7361d6573bd6a3","subject":"jtag/drivers/kitprog: Restructure commands"}],"author":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2016-08-01 18:29:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:29:49.000000000","tz":0},"subject":"mips32: MIPS32_OP_SRL was using SRA opcode.","message":"mips32: MIPS32_OP_SRL was using SRA opcode.\n\nThe mips opcode macro for the SRL opcode was using the wrong constant\nvalue:\n\nSRA -- Shift right arithmetic\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0011\n\nSRL -- Shift right logical\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0010\n\nThis corrects the opcode constant for SRL and adds the SRA opcode for\ncompleteness.\n\nThere is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c:\nSince the mask constant (0x00000080 for the DQ7 mask) shifted in this\ncase would never have the sign bit set, it worked fine even though it\nwas accidentally using the SRA opcode instead of SRL.\n\nChange-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb\nSigned-off-by: Tobias Diedrich \u003cranma+openocd@tdiedrich.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/3613\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\n"}},"eec3ceaa5a41a9317464b075ff3ee8f333062979":{"kind":"REWORK","_number":1,"created":"2016-08-01 18:33:40.000000000","uploader":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"ref":"refs/changes/13/3613/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3613/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/1 \u0026\u0026 git checkout -b change-3613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3613/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f19ac83152b54a204b8148815a538d868973e1e1","subject":"Fix usage of timeval_ms()"}],"author":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2016-08-01 18:29:41.000000000","tz":120},"committer":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2016-08-01 18:29:41.000000000","tz":120},"subject":"mips32: MIPS32_OP_SRL was using SRA opcode.","message":"mips32: MIPS32_OP_SRL was using SRA opcode.\n\nThe mips opcode macro for the SRL opcode was using the wrong constant\nvalue:\n\nSRA -- Shift right arithmetic\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0011\n\nSRL -- Shift right logical\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0010\n\nCorrect the opcode constant and add the opcodes for SRL and SLL for completeness.\nThere is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c.\nSince I can\u0027t test it I replaced the opcode used there with\nMIPS32_OP_SRA which will result in the same machine code as before.\n\nChange-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb\nSigned-off-by: Tobias Diedrich \u003cranma+openocd@tdiedrich.de\u003e\n"}},"0f08cf0bacd6344e895541a2202ad1104ea3425a":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-11-09 20:21:12.000000000","uploader":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"ref":"refs/changes/13/3613/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3613/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/3 \u0026\u0026 git checkout -b change-3613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3613/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b388f4805c3ce6e0b7ce7e5995c9305529db8e46","subject":"OpenOCD memory leak in `hwthread_update_threads()`"}],"author":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2016-08-01 18:29:41.000000000","tz":120},"committer":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2023-11-09 20:19:36.000000000","tz":60},"subject":"mips32: MIPS32_OP_SRL was using SRA opcode.","message":"mips32: MIPS32_OP_SRL was using SRA opcode.\n\nThe mips opcode macro for the SRL opcode was using the wrong constant\nvalue:\n\nSRA -- Shift right arithmetic\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0011\n\nSRL -- Shift right logical\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0010\n\nThis corrects the opcode constant for SRL and adds the SRA opcode for\ncompleteness.\n\nThere is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c:\nSince the mask constant (0x00000080 for the DQ7 mask) shifted in this\ncase would never have the sign bit set, it worked fine even though it\nwas accidentally using the SRA opcode instead of SRL.\n\nChange-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb\nSigned-off-by: Tobias Diedrich \u003cranma+openocd@tdiedrich.de\u003e\n"}},"b513d9602eba43610e64ea09cec943fb9f4c3763":{"kind":"REWORK","_number":2,"created":"2023-11-09 20:16:22.000000000","uploader":{"_account_id":1001086,"name":"Tobias Diedrich","email":"tobiasdiedrich@gmail.com","username":"ranma"},"ref":"refs/changes/13/3613/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/3613/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/2 \u0026\u0026 git checkout -b change-3613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/3613/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/3613/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b388f4805c3ce6e0b7ce7e5995c9305529db8e46","subject":"OpenOCD memory leak in `hwthread_update_threads()`"}],"author":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2016-08-01 18:29:41.000000000","tz":120},"committer":{"name":"Tobias Diedrich","email":"ranma+openocd@tdiedrich.de","date":"2023-11-09 20:09:55.000000000","tz":60},"subject":"mips32: MIPS32_OP_SRL was using SRA opcode.","message":"mips32: MIPS32_OP_SRL was using SRA opcode.\n\nThe mips opcode macro for the SRL opcode was using the wrong constant\nvalue:\n\nSRA -- Shift right arithmetic\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0011\n\nSRL -- Shift right logical\nEncoding: 0000 00-- ---t tttt dddd dhhh hh00 0010\n\nCorrect the opcode constant and add the opcodes for SRL and SLL for completeness.\nThere is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c.\n\nSince the mask constant (0x00000080 for the DQ7 mask) shifted in this\ncase would never have the sign bit set, it worked fine even though it\nwas accidentally using the SRA opcode instead of SRL.\n\nChange-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb\nSigned-off-by: Tobias Diedrich \u003cranma+openocd@tdiedrich.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}