)]}'
{"id":"openocd~master~I4aa80a92fb0226174356adaf2f8ff949920a621f","project":"openocd","branch":"master","hashtags":[],"change_id":"I4aa80a92fb0226174356adaf2f8ff949920a621f","subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","status":"MERGED","created":"2017-01-21 11:00:35.000000000","updated":"2018-01-12 20:17:55.000000000","submitted":"2018-01-12 20:17:55.000000000","submitter":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3952-1515788275161-8c2b109c","meta_rev_id":"b639932ebb4dffbfcbdf60ed98456d402d561b0a","_number":3952,"owner":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":1,"date":"2018-01-12 20:17:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"value":0,"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},{"value":0,"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"value":0,"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":2,"date":"2018-01-12 20:17:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"value":1,"date":"2018-01-12 20:17:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},{"value":0,"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-29 23:49:40.000000000","updated_by":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2017-10-31 15:17:20.000000000","updated_by":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"reviewer":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"state":"REVIEWER"},{"updated":"2017-12-17 10:06:18.000000000","updated_by":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"reviewer":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"state":"REVIEWER"},{"updated":"2018-01-02 02:48:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-02 07:58:44.000000000","updated_by":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"reviewer":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"state":"REVIEWER"},{"updated":"2018-01-02 08:48:15.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2018-01-12 20:17:55.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"3c14dc7eddbb1b89d1be673ed5ef03bccc5dd46c","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-01-21 11:00:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2bc0abff77cf83f5112d81611df5430dc6cf7c59","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-01-21 11:22:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8499/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/7877/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f3eaf4d9b92442caa00c244a9cbc63083927e30e","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-01-22 19:20:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7fa43107ec4aec0aebf4db884a81b61a804f6e5b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-01-22 19:50:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8503/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/7881/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d70065bdf7d4c0c87a5122d676125405d114c02a","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-01-22 20:03:25.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"287a302de4436b832f9393ce2698959e8158edbb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-01-22 20:18:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8504/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/7882/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"807089e0b2ef66343d4557d4d4910d90366f9aa0","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-01-23 20:16:56.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"738113d3f6e7b760f721b4e72d1fac1abbed3ada","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-01-23 20:46:13.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8507/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/7885/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"bf16cc11087c2749d60839c694e1e6dbd81434be","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-02-26 09:19:34.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"94d826d68b113bfc4c7cfd9fec78f4ecc1a5604b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-02-26 09:34:37.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8753/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8130/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"923b03e5d24a445873992093e39215bf9f1af964","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-24 19:31:13.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"401fe93b7c22ffb3fa65409116a32e9ba12a334e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-10-24 19:47:24.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9334/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8708/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"a7c13b3da622250ca967bebf3b3fb5f860864b93","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2017-10-29 23:49:40.000000000","message":"Patch Set 6:\n\n(1 comment)\n\ninline","accounts_in_message":[],"_revision_number":6},{"id":"0b402fbccc01c88e7235804d3a36f989efe1cc0e","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2017-10-31 15:17:20.000000000","message":"Patch Set 6:\n\nCan\u0027t say anything regarding functionality for stm8, but doesn\u0027t seem to break anything for ST-Link V2-1 either: Adapters on L0535-disco, F429I-disco, F469I-disco, F769I-disco all work fine.","accounts_in_message":[],"_revision_number":6},{"id":"399e4e6207ebe4d0112dc7de2ef4afccff8868ff","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-01 22:40:33.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b158949f5a66e74ede248d71728da0dbe4db30ce","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-11-01 23:13:14.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9384/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8758/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"fce5cc247a532436ab5558a22e71e898ef3802be","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-17 08:39:42.000000000","message":"Patch Set 7:\n\nAs far as I understand the source SWIM mode has \u0027low\u0027 and \u0027high\u0027 speeds only. Do you know what real speed in kHz it means? It might be better for an user to enter realistic numbers in adapter_khz input. Driver then just compares if requested speed is over some value and sets high or low speed - and shows warning if selected speed differs from request, as SWD/JTAG mode does.\nUsing adapter_khz 0 usually means auto setting by RCLK, so a misunderstanding is possible.","accounts_in_message":[],"_revision_number":7},{"id":"b93186fe2d450ba7a29d83830e61f44e17119a29","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-17 22:15:11.000000000","message":"Patch Set 7:\n\nI\u0027m not sure how to handle speed setting. What it does is changing the bit encoding between 10 bits and 20 bits of the individual data bits. The speed in khz is dependant on what the internal RC oscillator on the target is running at, normally 16 MHz resulting at either 400kHz or 800kHz bit rate. But changing the \u0027adapter speed\u0027 also requires the SWIM_CSR HS bit in the target device to be changed as well. So if the user decides to change the adapter speed after init is only going to cause the dongle to fail talking to the DM since the target device does not know the adapter speed was changed. Currently the target driver is hard coded to use \u0027high speed\u0027 making a call to -\u003espeed() during initialization.\n\n \u003e As far as I understand the source SWIM mode has \u0027low\u0027 and \u0027high\u0027\n \u003e speeds only. Do you know what real speed in kHz it means? It might\n \u003e be better for an user to enter realistic numbers in adapter_khz\n \u003e input. Driver then just compares if requested speed is over some\n \u003e value and sets high or low speed - and shows warning if selected\n \u003e speed differs from request, as SWD/JTAG mode does.\n \u003e Using adapter_khz 0 usually means auto setting by RCLK, so a\n \u003e misunderstanding is possible.","accounts_in_message":[],"_revision_number":7},{"id":"4a47fa7930c63a2fe334ca653b291bb662b177af","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-21 19:25:39.000000000","message":"Patch Set 7: Code-Review+1\n\nNeither I have a STM8 to test. At least SWIM support does not break anything.","accounts_in_message":[],"_revision_number":7},{"id":"1ab034eba3fcdf523e2dab2a0f1b41892f5d24f1","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2018-01-02 02:31:39.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"2036ecfed8e131d5513ba1023f992adfe5666937","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-02 02:48:51.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9517/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8891/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"7ff79b1710f7c58cdd8d52a4f318bad2f8e1c3e3","author":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"real_author":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"date":"2018-01-02 07:58:44.000000000","message":"Patch Set 8: Code-Review+1\n\nI have tested the basic functionality (flashing, debugging with breakpoints and looking into the the values of variables) on the following hardware:\n\n* STM8A-Discovery board (STM8AF5288) using the integrated ST-Link/v2 using API v1.\n* STM8S-Discovery board (STM8S105C6) using the integrated ST-Link/v1 using API v1.\n* EX-STM8-Q64a-207 board (STM8S207R8) using an external ST-Link/v2 using API v2.\n\nIt works for me with the current version of patch #4265.\n\nPhilipp","accounts_in_message":[],"_revision_number":8},{"id":"0fd796c1412d478f168ad04a310e4dac71f99d0e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2018-01-02 08:48:15.000000000","message":"Patch Set 8: Code-Review+2","accounts_in_message":[],"_revision_number":8},{"id":"b639932ebb4dffbfcbdf60ed98456d402d561b0a","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-12 20:17:55.000000000","message":"Change has been successfully cherry-picked as 3de6b5f6e52f46a4b6dcbdeaddb6d75d2bf48519 by Paul Fertser","accounts_in_message":[],"_revision_number":9}],"current_revision":"3de6b5f6e52f46a4b6dcbdeaddb6d75d2bf48519","revisions":{"37813c2e2a0d53b74921130bcf81bb4c54d67149":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2018-01-02 02:31:39.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/8 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1c2e3d41de30c5e47d3fc8eda3de0a0a8229895a","subject":"config for ESPRESSObin from Globalscale Tech. Inc."}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2018-01-02 02:05:31.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"3de6b5f6e52f46a4b6dcbdeaddb6d75d2bf48519":{"kind":"REWORK","_number":9,"created":"2018-01-12 20:17:55.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/52/3952/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/9 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"779e95cc326e77f628d5feb7d72a064ffedfd820","subject":"arm_adi_v5: fix regression from 4553abf9064fe3c0e4ea2ed29a1d2217df74ff5f"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-12 20:17:55.000000000","tz":0},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/3952\nTested-by: jenkins\nReviewed-by: Philipp Klaus Krause\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ae4c18ec125afe2abcf7f6b9ce67ca9330da8bae":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2017-10-24 19:31:13.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/6 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"079d78f7de917e33b58c5ea6147c818e573b3dc4","subject":"Fix GCC7 warnings about string truncation"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-10-24 19:29:03.000000000","tz":120},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"b83d1ba3c9add362cea5f79a7a9dd381ad1c5113":{"kind":"REWORK","_number":7,"created":"2017-11-01 22:40:33.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/7 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41092636d1a10d7fe55a986f0d5556a4c34b58d2","subject":"ftdi: Enable SWDIO output before sending data on it"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-01 22:12:45.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"314eb28557aaac9094bd99b3d59873b923d0e834":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-01-23 20:16:56.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/4 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ecee8326608a070b476a757cf517d0f50b5ca07","subject":"Restore normal development cycle"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-23 18:36:24.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"75c6d1e2cc502e6949976e699c669713f6973cef":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2017-02-26 09:19:34.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/5 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77189db85630cef21a4887a9b1c15dac3fd48473","subject":"tcl: add Hi6220 target and LeMaker HiKey board config"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-02-26 09:08:41.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"ec7fdc5a7a67ec5eaeb5e8918ee5d8b0e706acde":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-01-22 19:20:58.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/2 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0e7bcf850bd2fe2f09f0ee527e8e51bc5b8f2882","subject":"NEWS: last pre-release changes"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-22 18:01:38.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"9c2cfa554ebe56de6e670d3f42f84bad4fbe76d9":{"kind":"REWORK","_number":3,"created":"2017-01-22 20:03:25.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/3 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0e7bcf850bd2fe2f09f0ee527e8e51bc5b8f2882","subject":"NEWS: last pre-release changes"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-22 19:58:06.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nFixed a bug in stlink_usb_read_mem/write_mem preventing large data transfers\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"040042cee1dbb966c9346db7626792cba107777c":{"kind":"REWORK","_number":1,"created":"2017-01-21 11:00:35.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/52/3952/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/3952/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/1 \u0026\u0026 git checkout -b change-3952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/3952/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/3952/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"59820c18d0d8be93344b00a10a2a4e56601fb094","subject":"arm_dpm: avoid duplicating the register cache"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 09:42:11.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-01-21 10:59:17.000000000","tz":60},"subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support","message":"jtag/drivers/stlink_usb : implemented and repaired SWIM support\n\nThe SWIM support in stlink_usb was basically non existent so I have\nimplemented the missing parts. The bCBWCBLength and dCBWDataTransferLength\nfor STLINK-V1 protocol was not correct so that was fixed. The reason for\nadding SWIM support is to add STM8 support for OpenOCD.\n\nI have tested the driver on:\nSTM8 discovery board with the built-in STLINK-V1\nSTM8 discovery board with STLINK-V2 dongle\nSTM32 vldiscovery board with the built-in STLINK-V1\nSTM32F1xxx processor with STLINK-V2 dongle\n\nChange-Id: I4aa80a92fb0226174356adaf2f8ff949920a621f\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}