)]}'
{"id":"openocd~master~Idcd0182d6763e53784adeb304018fb5a862ef1cb","project":"openocd","branch":"master","hashtags":[],"change_id":"Idcd0182d6763e53784adeb304018fb5a862ef1cb","subject":"Add support for Coldfire BDM (26pin, known as v2-3-4) and mcf5441x","status":"ABANDONED","created":"2017-02-08 21:12:20.000000000","updated":"2017-02-10 08:36:49.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"50ff4d0f3e9daae3159a155ba3871c26587b2486","_number":3970,"owner":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"date":"2017-02-08 22:28:26.000000000","_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"date":"2017-02-09 09:11:26.000000000","_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},{"value":-1,"date":"2017-02-08 21:12:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-08 21:12:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-02-08 22:28:26.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"96e5b8ba8db7a203e3f4b524ea2c2827b28fe8fc","author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"real_author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"date":"2017-02-08 21:12:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b20ec94a0350c51896eeec3b98ec15be99a067b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-02-08 21:12:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit/8536/ : FAILURE\n\nhttp://build.openocd.org/job/openocd-gerrit-build/7914/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"32ef5fe8bf3fac52a7464a6b9f3fe478f94957c2","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2017-02-08 22:28:26.000000000","message":"Patch Set 1:\n\n(6 comments)\n\nAfter a quick read-through it looks pretty good. I noticed a lot of casts in pe_mu_usb.c which is often a sign of problems. I think the buffer access through the structs is a bit convoluted and it would probably be less confusing to simply build the buffer byte-wise and avoid all the potentially unsafe tricks.","accounts_in_message":[],"_revision_number":1},{"id":"e6c349c3ca7cee59f719aea21863a229fad46cb7","author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"real_author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"date":"2017-02-09 09:11:26.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nHi Andreas,\n\nthanks for the review.\n\nI found also wrong include-guards style (fixed)\n\nLine 78: those structure has been implemented to allow a maintainer to understand\nthe structure of a packet, of course i can buff[n]\u003dx, as you prefer. Only\nissue i see with those structures is if you compile openocd on an arm, where\nstruck cannot be packed the same, so eventually \"__attribute__ ((packed));\"\nfixes all. As you prefer.\n\nLine 82: \"__attribute__ ((packed));\" on all structs should keep all safe, but \nagain, if for your common scheme those structs are weird, i can go buff[n].\n\nLine 97: ok i can use container_of()\n\nLine 210: seems connected with 97, ok, will use container_of()\n\nLine 307: ack, done\n\nLine 662: ok will use buff[n] method.","accounts_in_message":[],"_revision_number":1},{"id":"50ff4d0f3e9daae3159a155ba3871c26587b2486","author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"real_author":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"date":"2017-02-10 08:36:49.000000000","message":"Abandoned\n\nAbandoning to re-push a single squashed commit. Sry for chaos, still learning.","accounts_in_message":[],"_revision_number":1}],"current_revision":"4c2ccf060f20dfdb6bfda51823db8d61e0710f8d","revisions":{"4c2ccf060f20dfdb6bfda51823db8d61e0710f8d":{"kind":"REWORK","_number":1,"created":"2017-02-08 21:12:20.000000000","uploader":{"_account_id":1001310,"name":"Angelo Dureghello","email":"angelo@sysam.it","username":"angelo"},"ref":"refs/changes/70/3970/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/3970/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/3970/1 \u0026\u0026 git checkout -b change-3970 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/3970/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/3970/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/3970/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/3970/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/3970/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ecee8326608a070b476a757cf517d0f50b5ca07","subject":"Restore normal development cycle"}],"author":{"name":"Angelo Dureghello","email":"angelo@sysam.it","date":"2017-02-08 20:44:28.000000000","tz":60},"committer":{"name":"Angelo Dureghello","email":"angelo@sysam.it","date":"2017-02-08 21:12:11.000000000","tz":60},"subject":"Add support for Coldfire BDM (26pin, known as v2-3-4) and mcf5441x","message":"Add support for Coldfire BDM (26pin, known as v2-3-4) and mcf5441x\n\n- add support for BDM 26pin transport (known as v2-3-4)\n- add support for P\u0026E Multilink Universal USB programmer\n- add support for mcf5441x coldfire target family\n\nChange-Id: Idcd0182d6763e53784adeb304018fb5a862ef1cb\nSigned-off-by: Angelo Dureghello \u003cangelo@sysam.it\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}