)]}'
{"id":"openocd~master~Ibe56473a3b218288699f5aa6282a43abc76c9592","project":"openocd","branch":"master","hashtags":[],"change_id":"Ibe56473a3b218288699f5aa6282a43abc76c9592","subject":"flash/nor/stm32f1x: Added RDP Level 2 support","status":"NEW","created":"2017-05-01 15:15:57.000000000","updated":"2018-07-12 07:21:34.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97355dfa1af8c2e36311090253f4ebc91caa87d8","_number":4111,"owner":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2018-06-07 20:54:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"disliked":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":1,"date":"2018-07-11 12:45:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":-1,"date":"2018-07-12 07:21:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-27 11:07:57.000000000","updated_by":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"reviewer":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"state":"REVIEWER"},{"updated":"2018-06-07 20:54:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-11 12:45:46.000000000","updated_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2018-07-12 07:21:34.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"10beb2f31495a16f6efb42b41eb182d6f93fd7d8","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-05-01 15:15:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"520fdbee734dd83dfbb1c2bf4e4a3acb08b380b9","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-05-01 15:24:42.000000000","message":"Patch Set 1:\n\nIf you want to test the lock_irreversibly function without bricking your STM32, I recommend to do the following TEMPORARY change:\n\nReplace\n    #define FLASH_PROTECTION_LEVEL2\t0xCC\nwith\n    #define FLASH_PROTECTION_LEVEL2\t0xBB\n\nThis will lock your controller only to protection level 1, which is non-permanent and removable.\nPlease check, whether the (replacement) value 0xBB was correctly written into the RDP byte.\n\n(I tested the code with 0xCC and it successfully locked my device into protection level 2.)","accounts_in_message":[],"_revision_number":1},{"id":"1e92c1689352871e3b324bd5e29552381e07afbb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-05-01 15:32:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/8984/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8359/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f8734aa27ac3316494deef113b01465a8c6f341f","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-07-14 11:10:07.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"88da6bf890df4a9bae9afb8ab970105beebf2318","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-07-14 11:26:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9142/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8516/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8a866df6459333dc905568423e47be3e26ec48dd","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-10-08 19:41:06.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"02d8db7b90e2408cde87e9c53e07c2928a80ca62","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-10-08 19:57:06.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9298/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8672/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"0774cd0bf622c269474716705aface215e090d41","author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"real_author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"date":"2017-11-27 11:07:57.000000000","message":"Patch Set 3: Code-Review-1\n\nHm, I don\u0027t fancy this possibility at all. It might be useful only for production programming, not for development nor debugging. And at least partially doesn\u0027t go along well with open source.\nBut if somebody needs this fuctionality desperately, it\u0027s trivial to implement in a simple script with some \u0027mww\u0027 commands, so no need to cut it into stone. \nWith RDP 1 it\u0027s a bit different as RDP regression is useful for mass erasing.","accounts_in_message":[],"_revision_number":3},{"id":"e06254b1e92e087dc0e18a3dc6e2c9f4390ce66d","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-11-28 10:01:12.000000000","message":"Patch Set 3:\n\nI do not share your opinion about my patch.\n\n \u003e Hm, I don\u0027t fancy this possibility at all. It might be useful only\n \u003e for production programming, not for development nor debugging. \nWhy do we want to restrict OpenOCD exclusively to development and debugging use? Especially some smaller companies also use OpenOCD for production programming. Also for me as a security researcher and developer, I have to test different chip security configurations. I do not see any disadvantage by adding features that make the software more versatile.\n\n \u003e And\n \u003e at least partially doesn\u0027t go along well with open source.\nThe patch just provides an interface for a feature that already exists in hardware. Any questions whether this feature interferes with open source should rather be discussed with the hardware manufacturer (\u003dST).\n\n \u003e But if somebody needs this fuctionality desperately, it\u0027s trivial\n \u003e to implement in a simple script with some \u0027mww\u0027 commands, so no\n \u003e need to cut it into stone.\nThe same applies to most other functions (e.g., lock to level 1). I prefer having such functions at hand without having to go to the data sheet first and then writing some scripts.\n\nNevertheless, I am quite unhappy with the current implementation. OpenOCD reports \"stm32x locked\" despite the chip is still partly open.\nEspecially latest discoveries regarding STM32F0 security show that this chip cannot be considered \"locked\" when configured to RDP level 1. ( https://www.usenix.org/conference/woot17/workshop-program/presentation/obermaier ). We also know some guys that were mislead by \"locking\" their chip using OpenOCD but the debug interface still allowed access to SRAM.\n\nThus, I recommend supporting RDP level 2 and CLEARLY stating, which level has been selected.","accounts_in_message":[],"_revision_number":3},{"id":"4f8c76a14d3f16e244db1da661e76f111ce72ab3","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2017-12-21 09:52:43.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"21ac6253f12ce8a299c6fd358a29f339ba3c7b55","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-12-21 10:10:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9505/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8879/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"23e5cc0dceb5c27b72f3d6a3aa7fed045e25b6d9","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2018-02-14 11:29:42.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"76107ef8226eafefdf24e1490b81a2987a4f6dca","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-02-14 11:46:30.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9727/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9097/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"ffeac26623ff8c146d7a22c2da7b9b26050fe167","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2018-03-23 09:57:54.000000000","message":"Patch Set 5:\n\nPlease trim the line length of the commit message.","accounts_in_message":[],"_revision_number":5},{"id":"f0aa46224f40911aa81d99ed37e79d791a8031c8","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2018-03-25 14:29:21.000000000","message":"Patch Set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"fd72178adbf20b3ede73e82a68ce93ecc15cc2ff","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-03-25 15:02:11.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10042/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9404/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"7db74348d037949f45e218dcc47830aad9bfe6d8","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2018-03-25 19:03:49.000000000","message":"Patch Set 6: Code-Review+1\n\nSince the changes introduce new user-visible commands, they should be explained in the documentation together with a fat warning. Apart from that, the change looks reasonably clean. Don\u0027t have a device to test, though.","accounts_in_message":[],"_revision_number":6},{"id":"251373c6149f0f70a3e51e7418212fdf10204a13","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2018-04-10 11:10:02.000000000","message":"Patch Set 7: Published edit on patch set 6.","accounts_in_message":[],"_revision_number":7},{"id":"f76c90f48a3e11f36ba4269a35cbf22660de23a4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-04-10 11:33:06.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10102/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9464/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"b9aa4027828de27092f38ee53f0f65cc10d6f766","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2018-04-10 11:34:58.000000000","message":"Patch Set 8: Patch Set 7 was rebased","accounts_in_message":[],"_revision_number":8},{"id":"a3a6fd5dcbcfbbe5127657efaf0340761f59fb29","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-04-10 11:56:54.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10103/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9465/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"6952a3c5d4ab2800147f6a20c8818546d8c3a9da","author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"real_author":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"date":"2018-06-07 20:35:27.000000000","message":"Patch Set 9: Patch Set 8 was rebased","accounts_in_message":[],"_revision_number":9},{"id":"0e10d9aaa16882f7db1cee87d12d4dc221a9ff17","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-06-07 20:54:08.000000000","message":"Patch Set 9: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10249/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9611/ : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"9be259038879503bc12a06516d062463d092e998","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2018-07-11 12:45:46.000000000","message":"Patch Set 9: Code-Review+1","accounts_in_message":[],"_revision_number":9},{"id":"97355dfa1af8c2e36311090253f4ebc91caa87d8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2018-07-12 07:21:34.000000000","message":"Patch Set 9: Code-Review-1\n\n(1 comment)\n\nJohannes, please review\nhttp://openocd.zylin.com/4576\nand rebase your work on top of it if possible.\nI know you submitted the change much earlier than #4576 but\n#4576 seems me very important as it makes write protection handling simpler. #4576 changes in option storing would require substantial rework of your code anyway.\nThanks","accounts_in_message":[],"_revision_number":9}],"current_revision":"32fa0b665311947455a83b99596079fa0b522902","revisions":{"393f98a44f4ead41ed2e680b09e6465ea081320c":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-12-21 09:52:43.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/4 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1c2e3d41de30c5e47d3fc8eda3de0a0a8229895a","subject":"config for ESPRESSObin from Globalscale Tech. Inc."}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-12-21 09:52:43.000000000","tz":0},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported. This patch adds Protection Level 2 support for STM32F0x and STM32F3x. STM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug interface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" was chosen. This should prevent users from unintentionally bricking their devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"dce844b770a8c061850a75081f3727e80a35da64":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2018-02-14 11:29:42.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/5 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d390e1b2a393505b38e1d0fcd741cd0b1cf92aa","subject":"efm32: Refactor EFM32 chip family data, add more chips"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2018-02-14 11:29:42.000000000","tz":0},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported. This patch adds Protection Level 2 support for STM32F0x and STM32F3x. STM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug interface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" was chosen. This should prevent users from unintentionally bricking their devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"d038ee6525439a6caaa45d9bd721c7900527aab9":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2018-03-25 14:29:21.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/6 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d390e1b2a393505b38e1d0fcd741cd0b1cf92aa","subject":"efm32: Refactor EFM32 chip family data, add more chips"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2018-03-25 14:25:39.000000000","tz":0},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported.\nThis patch adds Protection Level 2 support for STM32F0x and STM32F3x.\nSTM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug\ninterface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" \nwas chosen. This should prevent users from unintentionally bricking \ntheir devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"1da5ab32a96a3ceea5475261403e9e6e61c8bd96":{"kind":"REWORK","_number":7,"created":"2018-04-10 11:10:02.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/7 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d390e1b2a393505b38e1d0fcd741cd0b1cf92aa","subject":"efm32: Refactor EFM32 chip family data, add more chips"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2018-04-10 11:06:20.000000000","tz":0},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported.\nThis patch adds Protection Level 2 support for STM32F0x and STM32F3x.\nSTM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug\ninterface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\"\nwas chosen. This should prevent users from unintentionally bricking\ntheir devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"e283cf6fb8e156b79fb333cd845e31cfee1d9b0d":{"kind":"REWORK","_number":1,"created":"2017-05-01 15:15:57.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/1 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb317eabf2d162365467aeb89b564828e5e6d6f3","subject":"mips32, write handler code in a more compact way"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported. This patch adds Protection Level 2 support for STM32F0x and STM32F3x. STM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug interface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" was chosen. This should prevent users from unintentionally bricking their devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"47d7eb3323bb55e137c6a5c923559c464051014f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-07-14 11:10:07.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/2 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29cfe9c5eede2cd2fb3a62f44bdaf4f58377b027","subject":"mips32: inline functions in headers must be static"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-07-14 11:10:07.000000000","tz":60},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported. This patch adds Protection Level 2 support for STM32F0x and STM32F3x. STM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug interface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" was chosen. This should prevent users from unintentionally bricking their devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"d885b09ba4a3a0f7a520b12a02c392bd9807b224":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2017-10-08 19:41:06.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/3 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2168c475ff7ca0f2914bee39700952600014ac40","subject":"nrf5: Add nRF52832-QFAA support"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-10-08 19:41:06.000000000","tz":60},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported. This patch adds Protection Level 2 support for STM32F0x and STM32F3x. STM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug interface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\" was chosen. This should prevent users from unintentionally bricking their devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"5ea05c46528147a9fb4b9fae60e85c066470454e":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2018-04-10 11:34:58.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/8 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09076d10dd553dc63f08e74aedb1b6aa030857f9","subject":"armv8: valgrind memleak fixes"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2018-04-10 11:34:58.000000000","tz":60},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported.\nThis patch adds Protection Level 2 support for STM32F0x and STM32F3x.\nSTM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug\ninterface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\"\nwas chosen. This should prevent users from unintentionally bricking\ntheir devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}},"32fa0b665311947455a83b99596079fa0b522902":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2018-06-07 20:35:27.000000000","uploader":{"_account_id":1001374,"name":"Johannes Obermaier","email":"mail@obermaier-johannes.de","username":"johannes.obermaier"},"ref":"refs/changes/11/4111/9","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/4111/9","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/9 \u0026\u0026 git checkout -b change-4111 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/4111/9","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/4111/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06123153f38280608b1e92dcb766b31ade7e4668","subject":"psoc5lp: Add NV Latch flash driver"}],"author":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2017-05-01 15:06:12.000000000","tz":120},"committer":{"name":"Johannes Obermaier","email":"johannes.obermaier@aisec.fraunhofer.de","date":"2018-06-07 20:35:27.000000000","tz":60},"subject":"flash/nor/stm32f1x: Added RDP Level 2 support","message":"flash/nor/stm32f1x: Added RDP Level 2 support\n\nCurrently, only Flash Readout Protection Level 0 and 1 are supported.\nThis patch adds Protection Level 2 support for STM32F0x and STM32F3x.\nSTM32F1x does not support this protection level in hardware.\nProtection Level 2 permanently locks the microcontroller\u0027s debug\ninterface, thus providing a higher level of security.\nSince this level is irreversible, the command \"lock_irreversibly\"\nwas chosen. This should prevent users from unintentionally bricking\ntheir devices.\n\nChange-Id: Ibe56473a3b218288699f5aa6282a43abc76c9592\nSigned-off-by: Johannes Obermaier \u003cjohannes.obermaier@aisec.fraunhofer.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}