)]}'
{"src/jtag/drivers/stlink_usb.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"a6461efdc9c7c601ce3031105fd84e3f5af90505","unresolved":false,"context_lines":[{"line_number":907,"context_line":"\t/* preliminary SRST assert:"},{"line_number":908,"context_line":"\t * We want SRST is asserted before activating debug signals (mode_enter)."},{"line_number":909,"context_line":"\t * As the required mode has not been set, the adapter may not know what pin to use."},{"line_number":910,"context_line":"\t * Tested firmware STLINK v2 JTAG v29 API v2 SWIM v... uses T_NRST pin by default"},{"line_number":911,"context_line":"\t * after power on, SWIM_RST stays unchanged */"},{"line_number":912,"context_line":"\tif (connect_under_reset \u0026\u0026 emode !\u003d STLINK_MODE_DEBUG_SWIM) {"},{"line_number":913,"context_line":"\t\tres \u003d stlink_usb_assert_srst(handle, 0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_43b746d4","line":910,"range":{"start_line":910,"start_character":52,"end_line":910,"end_character":55},"updated":"2017-11-03 10:53:22.000000000","message":"I hope you fill your fw SWIM version. I have SWIM v0 as all my adapters are on STM32 boards. Or list both complete versions.","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"a6461efdc9c7c601ce3031105fd84e3f5af90505","unresolved":false,"context_lines":[{"line_number":911,"context_line":"\t * after power on, SWIM_RST stays unchanged */"},{"line_number":912,"context_line":"\tif (connect_under_reset \u0026\u0026 emode !\u003d STLINK_MODE_DEBUG_SWIM) {"},{"line_number":913,"context_line":"\t\tres \u003d stlink_usb_assert_srst(handle, 0);"},{"line_number":914,"context_line":"\t\tif (res !\u003d ERROR_OK)"},{"line_number":915,"context_line":"\t\t\treturn res;"},{"line_number":916,"context_line":"\t}"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"\tres \u003d stlink_usb_mode_enter(handle, emode);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_23ac4a84","line":915,"range":{"start_line":914,"start_character":2,"end_line":915,"end_character":14},"updated":"2017-11-03 10:53:22.000000000","message":"ignore err here and comment","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"a6461efdc9c7c601ce3031105fd84e3f5af90505","unresolved":false,"context_lines":[{"line_number":915,"context_line":"\t\t\treturn res;"},{"line_number":916,"context_line":"\t}"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"\tres \u003d stlink_usb_mode_enter(handle, emode);"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"\t/* assert SRST again: a little bit late but now the adapter knows for sure what pin to use */"},{"line_number":921,"context_line":"\tif (connect_under_reset) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_e3c51243","line":918,"updated":"2017-11-03 10:53:22.000000000","message":"and test err here","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"a6461efdc9c7c601ce3031105fd84e3f5af90505","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"\tenum stlink_mode emode;"},{"line_number":1958,"context_line":"\tstruct stlink_usb_handle_s *h \u003d handle;"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"\tassert(handle !\u003d NULL);"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_a3bf1aa7","line":1960,"updated":"2017-11-03 10:53:22.000000000","message":"I\u0027m not sure if leaving mode is a good idea. The dongle probably runs the target on OpenOCD exit (please test it). If so, do we really want it? I would prefer to keep target state unchanged: one can reopen debug session later and continue the work. Maybe this is the reason why mode was left as is in orig code. I meant this when I wrote about \"problem or feature\" in the mail from Nov 2nd.\nDoes it help to smt8 somehow?","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"0b25e1154ba87a87ace2619ac0abfaff0e784cf3","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"\tenum stlink_mode emode;"},{"line_number":1958,"context_line":"\tstruct stlink_usb_handle_s *h \u003d handle;"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"\tassert(handle !\u003d NULL);"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_23fa0a74","line":1960,"in_reply_to":"2e489777_a3bf1aa7","updated":"2017-11-03 15:50:16.000000000","message":"O.K. I tested it and can confirm both SWCLK and SWDIO go to Hi-Z state. Perfect.\n\nSorry, my speculation was completely wrong.","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"0b25e1154ba87a87ace2619ac0abfaff0e784cf3","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"\tassert(handle !\u003d NULL);"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":1965,"context_line":"\t\treturn res;"},{"line_number":1966,"context_line":""},{"line_number":1967,"context_line":"\tLOG_DEBUG(\"MODE: 0x%02X\", mode);"},{"line_number":1968,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_4305067c","line":1965,"range":{"start_line":1963,"start_character":0,"end_line":1965,"end_character":13},"updated":"2017-11-03 15:50:16.000000000","message":"Don\u0027t return on err as it prevents jtag_libusb_close()","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"change_message_id":"9456465c4150d9b14e7b13147ebf5e695b7023d3","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"\tassert(handle !\u003d NULL);"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":1965,"context_line":"\t\treturn res;"},{"line_number":1966,"context_line":""},{"line_number":1967,"context_line":"\tLOG_DEBUG(\"MODE: 0x%02X\", mode);"},{"line_number":1968,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_e3f3d29a","line":1965,"range":{"start_line":1963,"start_character":0,"end_line":1965,"end_character":13},"in_reply_to":"2e489777_4305067c","updated":"2017-11-03 15:55:48.000000000","message":"\u003e Don\u0027t return on err as it prevents jtag_libusb_close()\n\nGood point","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"0b25e1154ba87a87ace2619ac0abfaff0e784cf3","unresolved":false,"context_lines":[{"line_number":1987,"context_line":"\tif (emode !\u003d STLINK_MODE_UNKNOWN) {"},{"line_number":1988,"context_line":"\t\tres \u003d stlink_usb_mode_leave(handle, emode);"},{"line_number":1989,"context_line":""},{"line_number":1990,"context_line":"\t\tif (res !\u003d ERROR_OK)"},{"line_number":1991,"context_line":"\t\t\treturn res;"},{"line_number":1992,"context_line":"\t}"},{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_6300026e","line":1991,"range":{"start_line":1990,"start_character":0,"end_line":1991,"end_character":14},"updated":"2017-11-03 15:50:16.000000000","message":"Don\u0027t return on err as it prevents jtag_libusb_close()","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"0b25e1154ba87a87ace2619ac0abfaff0e784cf3","unresolved":false,"context_lines":[{"line_number":1991,"context_line":"\t\t\treturn res;"},{"line_number":1992,"context_line":"\t}"},{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":1997,"context_line":"\t\treturn res;"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"\tLOG_DEBUG(\"MODE: 0x%02X\", mode);"},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"\tif (h \u0026\u0026 h-\u003efd)"},{"line_number":2002,"context_line":"\t\tjtag_libusb_close(h-\u003efd);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_a3d6faf4","line":1999,"range":{"start_line":1994,"start_character":0,"end_line":1999,"end_character":33},"updated":"2017-11-03 15:50:16.000000000","message":"Do we need to display mode before exit?","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"},{"author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"change_message_id":"9456465c4150d9b14e7b13147ebf5e695b7023d3","unresolved":false,"context_lines":[{"line_number":1991,"context_line":"\t\t\treturn res;"},{"line_number":1992,"context_line":"\t}"},{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"\tres \u003d stlink_usb_current_mode(handle, \u0026mode);"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":1997,"context_line":"\t\treturn res;"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"\tLOG_DEBUG(\"MODE: 0x%02X\", mode);"},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"\tif (h \u0026\u0026 h-\u003efd)"},{"line_number":2002,"context_line":"\t\tjtag_libusb_close(h-\u003efd);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e489777_c3f0d690","line":1999,"range":{"start_line":1994,"start_character":0,"end_line":1999,"end_character":33},"in_reply_to":"2e489777_a3d6faf4","updated":"2017-11-03 15:55:48.000000000","message":"\u003e Do we need to display mode before exit?\n\nNope","commit_id":"ddbf24927813c7af2a2a65c27968a319a805e257"}],"src/target/stm8.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"727c22c4a9754c437e8eb12265a648d2eeed1f97","unresolved":false,"context_lines":[{"line_number":1615,"context_line":"\t\t\tretval \u003d stm8_set_speed(target, 1);"},{"line_number":1616,"context_line":"\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1617,"context_line":"\t\t\t\tstm8-\u003eswim_configured \u003d true;"},{"line_number":1618,"context_line":"\t\t\t/* now is the time to deassert reset if connect_under_reset */"},{"line_number":1619,"context_line":"\t\t\tif (adapter-\u003eparam.connect_under_reset)"},{"line_number":1620,"context_line":"\t\t\t\tstm8_reset_deassert(target);"},{"line_number":1621,"context_line":"\t\t} else {"},{"line_number":1622,"context_line":"\t\t\tLOG_INFO(\"trying to reconnect\");"},{"line_number":1623,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e489777_2380ca4a","line":1620,"range":{"start_line":1618,"start_character":0,"end_line":1620,"end_character":32},"updated":"2017-10-29 22:26:37.000000000","message":"If you connect under reset in OpenOCD, you have normally issue a reset command to release SRST signal. This behavior should be same for all target.","commit_id":"773d6e12f943acf72288135f8fdfeafe285db75a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"123f9c6ce2a9b5aff65291f42230a664920906a1","unresolved":false,"context_lines":[{"line_number":1615,"context_line":"\t\t\tretval \u003d stm8_set_speed(target, 1);"},{"line_number":1616,"context_line":"\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1617,"context_line":"\t\t\t\tstm8-\u003eswim_configured \u003d true;"},{"line_number":1618,"context_line":"\t\t\t/* now is the time to deassert reset if connect_under_reset */"},{"line_number":1619,"context_line":"\t\t\tif (adapter-\u003eparam.connect_under_reset)"},{"line_number":1620,"context_line":"\t\t\t\tstm8_reset_deassert(target);"},{"line_number":1621,"context_line":"\t\t} else {"},{"line_number":1622,"context_line":"\t\t\tLOG_INFO(\"trying to reconnect\");"},{"line_number":1623,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e489777_c3c45697","line":1620,"range":{"start_line":1618,"start_character":0,"end_line":1620,"end_character":32},"in_reply_to":"2e489777_03d38e62","updated":"2017-10-30 08:28:46.000000000","message":"ok then","commit_id":"773d6e12f943acf72288135f8fdfeafe285db75a"},{"author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"change_message_id":"488863fa712a552009c276b0b5087d404a832167","unresolved":false,"context_lines":[{"line_number":1615,"context_line":"\t\t\tretval \u003d stm8_set_speed(target, 1);"},{"line_number":1616,"context_line":"\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1617,"context_line":"\t\t\t\tstm8-\u003eswim_configured \u003d true;"},{"line_number":1618,"context_line":"\t\t\t/* now is the time to deassert reset if connect_under_reset */"},{"line_number":1619,"context_line":"\t\t\tif (adapter-\u003eparam.connect_under_reset)"},{"line_number":1620,"context_line":"\t\t\t\tstm8_reset_deassert(target);"},{"line_number":1621,"context_line":"\t\t} else {"},{"line_number":1622,"context_line":"\t\t\tLOG_INFO(\"trying to reconnect\");"},{"line_number":1623,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e489777_03d38e62","line":1620,"range":{"start_line":1618,"start_character":0,"end_line":1620,"end_character":32},"in_reply_to":"2e489777_03fcaed4","updated":"2017-10-30 06:41:05.000000000","message":"\u003e I tried removing this line and it actually works as it should.\n \u003e Perhaps it was a problem with 0.10.0 release...\n\nActually according to the spec the reset line should be released (de-asserted) after speed change to load RC oscillator option bytes. Also, it will cause a bunch of read failures during some time after speed change unless the reset line is released. I think it should stay...","commit_id":"773d6e12f943acf72288135f8fdfeafe285db75a"},{"author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"change_message_id":"bcabd8584a98becc778fbc8e2daf771ab66ece5c","unresolved":false,"context_lines":[{"line_number":1615,"context_line":"\t\t\tretval \u003d stm8_set_speed(target, 1);"},{"line_number":1616,"context_line":"\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1617,"context_line":"\t\t\t\tstm8-\u003eswim_configured \u003d true;"},{"line_number":1618,"context_line":"\t\t\t/* now is the time to deassert reset if connect_under_reset */"},{"line_number":1619,"context_line":"\t\t\tif (adapter-\u003eparam.connect_under_reset)"},{"line_number":1620,"context_line":"\t\t\t\tstm8_reset_deassert(target);"},{"line_number":1621,"context_line":"\t\t} else {"},{"line_number":1622,"context_line":"\t\t\tLOG_INFO(\"trying to reconnect\");"},{"line_number":1623,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e489777_03fcaed4","line":1620,"range":{"start_line":1618,"start_character":0,"end_line":1620,"end_character":32},"in_reply_to":"2e489777_2380ca4a","updated":"2017-10-29 23:44:32.000000000","message":"I tried removing this line and it actually works as it should. Perhaps it was a problem with 0.10.0 release...","commit_id":"773d6e12f943acf72288135f8fdfeafe285db75a"}]}