)]}'
{"id":"openocd~master~I35444ec0e6caace3e072c60085059602f4cdf0a4","project":"openocd","branch":"master","hashtags":[],"change_id":"I35444ec0e6caace3e072c60085059602f4cdf0a4","subject":"stlink_usb: Changes to make connect_under_reset work","status":"MERGED","created":"2017-10-24 19:31:13.000000000","updated":"2018-01-12 20:19:42.000000000","submitted":"2018-01-12 20:19:42.000000000","submitter":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4265-1515788382028-ce81949b","meta_rev_id":"aa5171d192a99c16eb93b31d19d66c9f731d759b","_number":4265,"owner":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":1,"date":"2018-01-12 20:19:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"value":0,"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":2,"date":"2018-01-12 20:19:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":1,"date":"2018-01-12 20:19:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-02 03:46:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-02 07:54:37.000000000","updated_by":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"reviewer":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"state":"REVIEWER"},{"updated":"2018-01-02 08:44:57.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2018-01-12 20:19:42.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"645f32c33d25b6c9c8f9b27ee66058610ea2b26d","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-24 19:31:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4726a16a4592a26b8647411739c7404dc00dbe48","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-10-24 20:38:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9337/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8711/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"727c22c4a9754c437e8eb12265a648d2eeed1f97","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-10-29 22:26:37.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nAke, I don\u0027t have a STM8 device. I just wanted to check the change with an STM32 for possible regression.\nWhat is the problem on STM8 without this patch? I tested connecting under reset on STM32F722 nucleo and SRST signal is asserted as expected. Please make sure you have ST-Link firmware updated.\nSTM32 with your change seems to work. Unfortunately I\u0027m not sure if a SWD starting sequence is not send just after stlink_usb_mode_enter() - it would need check with l.a.","accounts_in_message":[],"_revision_number":1},{"id":"171e9535faff689fcae1d57c0a453caace810138","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-29 23:35:01.000000000","message":"Patch Set 1:\n\n\u003e \n \u003e Ake, I don\u0027t have a STM8 device. I just wanted to check the change\n \u003e with an STM32 for possible regression.\n \u003e What is the problem on STM8 without this patch? \n\nSee debug log below. I added the debug log \"CONNECT_UNDER_RESET\" just to make it clear.\n\n\nDebug: 196 11 hla_layout.c:40 hl_layout_open(): hl_layout_open\nDebug: 197 11 stlink_usb.c:1976 stlink_usb_open(): stlink_usb_open\nDebug: 198 11 stlink_usb.c:1993 stlink_usb_open(): transport: 3 vid: 0x0483 pid: 0x3748 serial:\nInfo : 199 49 stlink_usb.c:658 stlink_usb_version(): STLINK v2 JTAG v27 API v2 SWIM v6 VID 0x0483 PID 0x3748\nInfo : 200 49 stlink_usb.c:2104 stlink_usb_open(): using stlink api v2\nDebug: 201 50 stlink_usb.c:859 stlink_usb_init_mode(): MODE: 0x03\nInfo : 202 51 stlink_usb.c:690 stlink_usb_check_voltage(): Target voltage: 3.245115\nDebug: 203 51 stlink_usb.c:914 stlink_usb_init_mode(): MODE: 0x01\n\u003e\u003e\u003e\u003e\u003eDebug: 204 51 stlink_usb.c:925 stlink_usb_init_mode(): CONNECT_UNDER_RESET\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\nDebug: 205 53 stlink_usb.c:342 stlink_usb_xfer_rw(): bulk read failed\nError: 206 53 stlink_usb.c:2113 stlink_usb_open(): init mode failed (unable to connect to the target)\nDebug: 207 53 hla_layout.c:47 hl_layout_open(): failed","accounts_in_message":[],"_revision_number":1},{"id":"bcabd8584a98becc778fbc8e2daf771ab66ece5c","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-29 23:44:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"488863fa712a552009c276b0b5087d404a832167","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-30 06:41:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"123f9c6ce2a9b5aff65291f42230a664920906a1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-10-30 08:28:46.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nAke, moving stlink_usb_assert_srst() after stlink_usb_mode_enter()\nwould break the basic principle why reset under connect is designed for.\nDebug interface should be activated AFTER reset is asserted, not before.\n\n \u003e Debug: 203 51 stlink_usb.c:914 stlink_usb_init_mode(): MODE: 0x01\n \u003e \u003e\u003e\u003e\u003e\u003eDebug: 204 51 stlink_usb.c:925 stlink_usb_init_mode():\n \u003e CONNECT_UNDER_RESET\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\n \u003e Debug: 205 53 stlink_usb.c:342 stlink_usb_xfer_rw(): bulk read\n \u003e failed\n\nIf there is not a better solution, use a delayed stlink_usb_mode_enter in swim mode only.","accounts_in_message":[],"_revision_number":1},{"id":"0de89c94d3329d17c38ae242ca3a5c8a624cc3f1","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-30 09:22:20.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e Ake, moving stlink_usb_assert_srst() after stlink_usb_mode_enter()\n \u003e would break the basic principle why reset under connect is designed\n \u003e for.\n \u003e Debug interface should be activated AFTER reset is asserted, not\n \u003e before.\n\nThe whole idea is to circumvent malformed code execution or option bytes preventing proper debugger attachment to the target, right? So changing mode is not doing anything at all to the target (at least for SWIM targets). As I understand it is just mode change for the dongle it self. And obviously the dongle does not like resetting the target when in the wrong mode.\n\nAccording to the manual: \"connect_assert_srst, indicating that SRST will be asserted before any target connection. Only some targets support this feature, STM32 and STR9 are examples. This feature is useful if you are unable to connect to your target due to incorrect options byte config or illegal program execution. \"\n\n\n \u003e If there is not a better solution, use a delayed stlink_usb_mode_enter\n \u003e in swim mode only.\n\nDelayed reset for swim mode you mean?","accounts_in_message":[],"_revision_number":1},{"id":"fdb972392d0cebb38971324c370f02e5c589d38c","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-10-30 09:29:55.000000000","message":"Patch Set 1:\n\n\u003e And obviously the dongle does not like\n \u003e resetting the target when in the wrong mode.\n \u003e \n\nActually I don\u0027t understand how it could work for swd targets either. How could it know which line to yank when we have not defined what interface to use...","accounts_in_message":[],"_revision_number":1},{"id":"428e941417e459514242b7ec11acded253827dc6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-10-30 09:41:08.000000000","message":"Patch Set 1:\n\n\u003e \u003e Debug interface should be activated AFTER reset is asserted, not\n \u003e \u003e before.\n \u003e \n \u003e The whole idea is to circumvent malformed code execution or option\n \u003e bytes preventing proper debugger attachment to the target, right?\n \u003e So changing mode is not doing anything at all to the target (at\n \u003e least for SWIM targets).\n\nChanging to SWD mode enables dongle to drive SWCLK and SWDIO signals. The dongle changes pin mode to output immediately. \nIf a target firmware uses same pins for output, it is safer to assert reset first to prevent both target and dongle from driving same line.\n\n \u003e And obviously the dongle does not like\n \u003e resetting the target when in the wrong mode.\n\nWhy do you think so? Is there a swim reset output on a different pin of dongle MCU?\n\n \u003e \u003e If there is not a better solution, use a delayed\n \u003e stlink_usb_mode_enter\n \u003e \u003e in swim mode only.\n \u003e \n \u003e Delayed reset for swim mode you mean?\n\nYes, delayed for swim, and before mode_enter for swd.","accounts_in_message":[],"_revision_number":1},{"id":"8af555771f07601ecc501d3fefd3c0969261c2e9","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-01 22:43:31.000000000","message":"Abandoned\n\nSquished into 3953","accounts_in_message":[],"_revision_number":1},{"id":"5a9fec900a52e384f000af2ef531c9a1ac01a9d4","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-03 10:21:31.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"ade396073252ad6f61add4a826f44cf03e0b69ff","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-03 10:21:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f17c8c3cb51ddb0bcdc781526a598be225a1466","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-11-03 10:38:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9393/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8767/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a6461efdc9c7c601ce3031105fd84e3f5af90505","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-03 10:53:22.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0b25e1154ba87a87ace2619ac0abfaff0e784cf3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-03 15:50:16.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9456465c4150d9b14e7b13147ebf5e695b7023d3","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-03 15:55:48.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ef7c3fa729ec5a1364efb240c66c8be0ed6c4f63","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-04 18:31:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1b658ea01cdcd14e012c2d8624904ca5cd29d45f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-04 18:40:24.000000000","message":"Patch Set 3: Code-Review+2\n\nPerfect :-)","accounts_in_message":[],"_revision_number":3},{"id":"8ad3226032f04f8d9e062a44eb20be05bd2e64f1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-11-04 18:47:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9410/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8784/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9bb116a745835df9bbd3a4f85c6ff874bc47d883","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-05 14:55:09.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"8144560f18a7477c5e004749a3a3604a930c14b6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-11-05 15:44:20.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9414/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8788/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"c64dd6f1f98a4fd1b61771e9677f519b2f4900cb","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2017-11-06 19:05:10.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"f70bff39dab1ff81ee0a790da81ea414136c4a02","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-11-06 19:21:55.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9415/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8789/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"2c06af0cbb8a7770d2b0ccd9e2d840ceef497d2c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2017-11-17 07:58:01.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"31fa677f1abdbcacacd43a2ff48efca5538bd41c","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2018-01-02 02:31:39.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"4a1bb3e874bc5a3b0f0626cec9ef0c2094612157","author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"real_author":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"date":"2018-01-02 02:58:22.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"36c5f12288b55438060928a9ad1631ffa5e093d3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-02 02:58:22.000000000","message":"Patch Set 6: Verified-1\n\nBuild Failed \n\nhttp://build.openocd.org/job/openocd-gerrit-build/8892/ : ABORTED\n\nhttp://build.openocd.org/job/openocd-gerrit/9518/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"48dad9e4734c65e8b689389c28b6a6b965284ff7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-02 03:46:34.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9522/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8895/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"f4317af19e506648fa894801f4355b9ee67add6d","author":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"real_author":{"_account_id":1001468,"name":"Philipp Klaus Krause","username":"spth"},"date":"2018-01-02 07:54:37.000000000","message":"Patch Set 7: Code-Review+1\n\nI have tested the basic functionality on the following hardware:\n\n* STM8A-Discovery board (STM8AF5288) using the integrated ST-Link/v2 using API v1.\n* STM8S-Discovery board (STM8S105C6) using the integrated ST-Link/v1 using API v1.\n* EX-STM8-Q64a-207 board (STM8S207R8) using an external  ST-Link/v2 using API v2.\n\nIn the previous version 5 of the patch only the last configuration (API v2) worked. But in the current version 7 all three configurations work for me.\n\nPhilipp","accounts_in_message":[],"_revision_number":7},{"id":"26d4bbd32cd8f79405fc5b8fe05e20a762446876","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2018-01-02 08:44:57.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"aa5171d192a99c16eb93b31d19d66c9f731d759b","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-12 20:19:42.000000000","message":"Change has been successfully cherry-picked as a6dea119a3f48ebc2efffdfba960421c9ac43c27 by Paul Fertser","accounts_in_message":[],"_revision_number":8}],"current_revision":"a6dea119a3f48ebc2efffdfba960421c9ac43c27","revisions":{"a6dea119a3f48ebc2efffdfba960421c9ac43c27":{"kind":"REWORK","_number":8,"created":"2018-01-12 20:19:42.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/65/4265/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/8 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3de6b5f6e52f46a4b6dcbdeaddb6d75d2bf48519","subject":"jtag/drivers/stlink_usb : implemented and repaired SWIM support"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-12 20:19:42.000000000","tz":0},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\nResolved a collision with JTAG API v1 error/status\nchecking overwriting SWIM status bytes\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/4265\nTested-by: jenkins\nReviewed-by: Philipp Klaus Krause\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"61f93df0e00567b926b0b148779ee6f4232258f2":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2017-11-06 19:05:10.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/5 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35929b78138e397a90da576a81eaebf89bab1cd8","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-06 19:01:36.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"77dd9e634410220e60716284cdf66a482a726031":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-11-05 14:55:09.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/4 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71af047240346b9716724954016658153bb2a2a3","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-05 14:51:33.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"af1c871837cc2a3481b53557610d5524ee92a67a":{"kind":"REWORK","_number":7,"created":"2018-01-02 02:58:22.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/7 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53a913cb2dee91b7a8bec2a17d98a78ff44fc429","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2018-01-02 02:56:39.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\nResolved a collision with JTAG API v1 error/status\nchecking overwriting SWIM status bytes\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"008d585c1b11181b49b122d5ee98e3a19ccd5e86":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2018-01-02 02:31:39.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/6 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53a913cb2dee91b7a8bec2a17d98a78ff44fc429","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2018-01-02 02:10:05.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"773d6e12f943acf72288135f8fdfeafe285db75a":{"kind":"REWORK","_number":1,"created":"2017-10-24 19:31:13.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/1 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0467b0e3ada58fd69a5474f13fdee7334bca1ab6","subject":"Bug in stm8_write_flash preventing flashing of small blocks"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-10-24 17:22:36.000000000","tz":120},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-10-24 19:29:21.000000000","tz":120},"subject":"Changes to make connect_under_reset work","message":"Changes to make connect_under_reset work\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"f2d6bd13077410cca2ca9b324021294e4ce51cbe":{"kind":"REWORK","_number":3,"created":"2017-11-04 18:31:30.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/3 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ae1dc11dbdd832a3ddca940872a129fc3eb8c8d","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:12:17.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-04 18:30:28.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}},"ddbf24927813c7af2a2a65c27968a319a805e257":{"kind":"REWORK","_number":2,"created":"2017-11-03 10:21:45.000000000","uploader":{"_account_id":1001281,"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","username":"akre"},"ref":"refs/changes/65/4265/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/4265/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/2 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/4265/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/4265/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ae1dc11dbdd832a3ddca940872a129fc3eb8c8d","subject":"Added config files for stm8l152 stm8s003 and stm8s105"}],"author":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-03 10:19:12.000000000","tz":60},"committer":{"name":"Ake Rehnman","email":"ake.rehnman@gmail.com","date":"2017-11-03 10:19:12.000000000","tz":60},"subject":"stlink_usb: Changes to make connect_under_reset work","message":"stlink_usb: Changes to make connect_under_reset work\n\nLeaving mode before closing added\n\nChange-Id: I35444ec0e6caace3e072c60085059602f4cdf0a4\nSigned-off-by: Ake Rehnman \u003cake.rehnman@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}