)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9b803bbe72797ee00060baced5cdcbb5b59ea215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f82391fb_f25b4b7a","updated":"2023-12-12 23:31:14.000000000","message":"Damn! I have https://review.openocd.org/7472\nalready queued for merge next weekend!\nThis patch does not fit as is after 7472!\nI need to ask you to wait for 7472 to be merged, then rebase this again.","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"601151eb4cfdd65e78fe7412873728089dd52566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c29ebf9c_9c2f06d0","updated":"2023-12-12 22:39:49.000000000","message":"Thanks for the rebase.\nI still have one remark","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"00d5ad1a631a5df39eb73b7d195918f3b2f87210","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1941d25a_abaea17b","updated":"2023-12-16 07:56:09.000000000","message":"https://review.openocd.org/7472 merged!","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"44de8c0c8724747079c058a6501001d4f8657800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47a696d8_af180ee1","updated":"2023-12-18 22:15:32.000000000","message":"Thanks!","commit_id":"c2ee0f60de1dcc313dcfc5c85d2375ee94597dc5"}],"src/jtag/drivers/bitbang.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"601151eb4cfdd65e78fe7412873728089dd52566","unresolved":true,"context_lines":[{"line_number":351,"context_line":"\t\t\t\tbreak;"},{"line_number":352,"context_line":"\t\t\tcase JTAG_SLEEP:"},{"line_number":353,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIu32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":354,"context_line":"\t\t\t\tif (bitbang_interface-\u003eflush \u0026\u0026 (bitbang_interface-\u003eflush() !\u003d ERROR_OK))"},{"line_number":355,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":356,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":357,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f2b6828c_23aa1af6","line":354,"updated":"2023-12-12 22:39:49.000000000","message":"The error code should be propagated (even if the only current implementation remote_bitbang_flush() only returns ERROR_FAIL, for now):\n\nif (bitbang_interface-\u003eflush) {\n  retval \u003d bitbang_interface-\u003eflush();\n  if (retval !\u003d ERROR_OK)\n    return retval;\n}","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"},{"author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"change_message_id":"1e6818944e411a28f4cda888210a8ff78cc671c3","unresolved":true,"context_lines":[{"line_number":351,"context_line":"\t\t\t\tbreak;"},{"line_number":352,"context_line":"\t\t\tcase JTAG_SLEEP:"},{"line_number":353,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIu32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":354,"context_line":"\t\t\t\tif (bitbang_interface-\u003eflush \u0026\u0026 (bitbang_interface-\u003eflush() !\u003d ERROR_OK))"},{"line_number":355,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":356,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":357,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f906ac5d_a78b62c6","line":354,"in_reply_to":"f2b6828c_23aa1af6","updated":"2023-12-12 23:13:40.000000000","message":"Presently the existing code does not propagate the error codes in most cases -- e.g. from bitbang_runtest(), bitbang_stableclocks(), bitbang_state_move(), bitbang_path_move(), bitbang_scan(), jtag_read_buffer(), and bitbang_interface-\u003eblink(0). Only when bitbang_execute_tms(cmd) is called in the JTAG_TMS case is the error code propagated.\n\nTherefore, changing how the error code is propagated would necessitate a more significant refactor of the bitbang_execute_queue() function. How best to proceed?","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"be7636090caceaf8d4f9722212a62e3a23b737ce","unresolved":false,"context_lines":[{"line_number":351,"context_line":"\t\t\t\tbreak;"},{"line_number":352,"context_line":"\t\t\tcase JTAG_SLEEP:"},{"line_number":353,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIu32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":354,"context_line":"\t\t\t\tif (bitbang_interface-\u003eflush \u0026\u0026 (bitbang_interface-\u003eflush() !\u003d ERROR_OK))"},{"line_number":355,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":356,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":357,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"bc7dea47_c6374b18","line":354,"in_reply_to":"f906ac5d_a78b62c6","updated":"2023-12-12 23:24:26.000000000","message":"You are right. I didn\u0027t check the whole loop.\n\nIt remains quite confusing, here, if in case of error we should really return ERROR_FAIL or simply assign retval\u003dERROR_FAIL and continue to next iteration.\nCurrent code use retval only for read error on JTAG_SCAN and for error sending JTAG_TMS sequence; I don\u0027t see a clear pattern.\n\nLet\u0027s keep your current proposal. It could be improved in the future.","commit_id":"b106dbfc8e989c2c17a939965bced0dbe0da6d06"}],"src/jtag/drivers/remote_bitbang.c":[{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"09eedfb9e4badb8045825d07153f7c930b61cb0d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"static void remote_bitbang_flush(void)"},{"line_number":53,"context_line":"{"},{"line_number":54,"context_line":"\t\tif (EOF \u003d\u003d fflush(remote_bitbang_out)) {"},{"line_number":55,"context_line":"\t\t\tLOG_ERROR(\"fflush: %s\", strerror(errno));"},{"line_number":56,"context_line":"\t\t}"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e489777_8312deff","line":54,"updated":"2017-10-31 18:30:44.000000000","message":"This looks like it\u0027s indented too deep.","commit_id":"00ea4fb467c72a158d73a1148fda0f538d0db48e"}]}