)]}'
{"id":"openocd~master~If40894a63d29a260a4ded134b008df6dd1e89c46","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002210":{"account":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"last_update":"2023-12-30 13:10:08.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-18 22:15:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2023-12-30 13:10:08.000000000","reason":"Change was submitted"},"1001453":{"account":{"_account_id":1001453,"name":"Alex Shargalin","email":"myokaski@gmail.com","username":"myokaski"},"last_update":"2023-12-30 13:10:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If40894a63d29a260a4ded134b008df6dd1e89c46","subject":"bitbang: Add flush before sleep","status":"MERGED","created":"2017-10-31 14:45:59.000000000","updated":"2023-12-30 13:10:08.000000000","submitted":"2023-12-30 13:10:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4284","meta_rev_id":"510ca94d6f235791662b86aeb97e74ce1c9332cc","_number":4284,"owner":{"_account_id":1001453,"name":"Alex Shargalin","email":"myokaski@gmail.com","username":"myokaski"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-30 13:10:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-30 13:10:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-31 15:03:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-10-31 18:30:44.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2020-10-23 14:59:04.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-12-12 19:50:39.000000000","updated_by":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"reviewer":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"state":"REVIEWER"}],"messages":[{"id":"12febe74a4ad2f2478b7a5962e611ad7084317e4","author":{"_account_id":1001453,"name":"Alex Shargalin","email":"myokaski@gmail.com","username":"myokaski"},"real_author":{"_account_id":1001453,"name":"Alex Shargalin","email":"myokaski@gmail.com","username":"myokaski"},"date":"2017-10-31 14:45:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ecd49db4e9c11d132b8a7cedf3f87822042db7ed","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2017-10-31 15:03:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9375/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8749/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"09eedfb9e4badb8045825d07153f7c930b61cb0d","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2017-10-31 18:30:44.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks like a good improvement.","accounts_in_message":[],"_revision_number":1},{"id":"41dd0948b4542136b36df5d4922b67fd01dbdaa7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2020-10-23 14:59:04.000000000","message":"Patch Set 1: Code-Review-1\n\nAlex,\nagree on this patch, but need rebase it on current master branch to be merged and there is one comment from Tim.\nWould you please provide a new version?","accounts_in_message":[],"_revision_number":1},{"id":"c3bdc40a6367e9c4e566a981db6d3a272d7bd36a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2023-12-12 19:50:39.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c1282b1c66a2112a449bdf4a4611537afb2c25ca","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-12 19:52:07.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19044/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18209/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"9116f7dca1d59100d4d1e0062747a078e447558e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2023-12-12 19:53:06.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c3b3e3b8dddae3940ca3426b566cad4ed844e85f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-12 19:54:03.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19045/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18210/ : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"34d00332d4952023de055cf884597ed9adec20d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2023-12-12 19:54:07.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"f6b7173e8b34b3b7298d644792cd077548e56a7c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-12 20:07:53.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19046/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18211/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"601151eb4cfdd65e78fe7412873728089dd52566","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-12 22:39:49.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"1e6818944e411a28f4cda888210a8ff78cc671c3","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2023-12-12 23:13:40.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"be7636090caceaf8d4f9722212a62e3a23b737ce","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-12 23:24:26.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9b803bbe72797ee00060baced5cdcbb5b59ea215","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-12 23:31:14.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"00d5ad1a631a5df39eb73b7d195918f3b2f87210","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 07:56:09.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"32c3afc0565aa7c8519c48bf9bf2e81f17e7972b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2023-12-18 20:54:55.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"7b22c5eac16f4f1aefe5363773cb483a98580f32","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-18 21:08:13.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19097/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18261/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"44de8c0c8724747079c058a6501001d4f8657800","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-18 22:15:32.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"957c00bbb929ac7c72e1ca4b1e043896d6c091ed","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-30 13:09:50.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"510ca94d6f235791662b86aeb97e74ce1c9332cc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-30 13:10:08.000000000","message":"Change has been successfully cherry-picked as 8df529fa663cef2004a6a26e8f147b8c96e03de9","accounts_in_message":[],"_revision_number":6}],"current_revision":"8df529fa663cef2004a6a26e8f147b8c96e03de9","revisions":{"b106dbfc8e989c2c17a939965bced0dbe0da6d06":{"kind":"REWORK","_number":4,"created":"2023-12-12 19:54:07.000000000","uploader":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"ref":"refs/changes/84/4284/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/4 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1ae95f6f55168a15a7cf359c1d4c5f1d4b04c01","subject":"HACKING: fix how to retrieve hooks/commit-msg"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"David Ryskalczyk","email":"david.rysk@gmail.com","date":"2023-12-12 19:54:02.000000000","tz":-300},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only the sequence of execuded commands is guaranteed but\nnot the timing. It works most of time with one exception: when the\nJTAG_SLEEP command is executed, we expect that all previous commands\nalready finished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time has passed but\nprevious commands are not actually executed.\nThis patch adds a flush command to the bitbang interface, connects it\nto the existing implementation for remote_bitbang, and runs it when\nthe JTAG_SLEEP command is executed.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\nSigned-off-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\n"}},"c2ee0f60de1dcc313dcfc5c85d2375ee94597dc5":{"kind":"REWORK","_number":5,"created":"2023-12-18 20:54:55.000000000","uploader":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"ref":"refs/changes/84/4284/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/5 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8e09b1b5513f0decf31aaa25151858fae126e1e","subject":"remote_bitbang: add use_remote_sleep option to send delays to remote"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"David Ryskalczyk","email":"david.rysk@gmail.com","date":"2023-12-18 20:51:43.000000000","tz":-300},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only the sequence of execuded commands is guaranteed but\nnot the timing. It works most of time with one exception: when the\nJTAG_SLEEP command is executed, we expect that all previous commands\nalready finished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time has passed but\nprevious commands are not actually executed.\nThis patch adds a flush command to the bitbang interface, connects it\nto the existing implementation for remote_bitbang, and runs it when\nthe JTAG_SLEEP command is executed.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\nSigned-off-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\n"}},"8df529fa663cef2004a6a26e8f147b8c96e03de9":{"kind":"REWORK","_number":6,"created":"2023-12-30 13:10:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/84/4284/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/6 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65fc586d6ee18813937ec0fdb264b9e0d4bc1c76","subject":"tcl/target: add Marvell Octeon TX2 CN9130 target"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-30 13:10:08.000000000","tz":0},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only the sequence of execuded commands is guaranteed but\nnot the timing. It works most of time with one exception: when the\nJTAG_SLEEP command is executed, we expect that all previous commands\nalready finished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time has passed but\nprevious commands are not actually executed.\nThis patch adds a flush command to the bitbang interface, connects it\nto the existing implementation for remote_bitbang, and runs it when\nthe JTAG_SLEEP command is executed.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\nSigned-off-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/4284\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"00ea4fb467c72a158d73a1148fda0f538d0db48e":{"kind":"REWORK","_number":1,"created":"2017-10-31 14:45:59.000000000","uploader":{"_account_id":1001453,"name":"Alex Shargalin","email":"myokaski@gmail.com","username":"myokaski"},"ref":"refs/changes/84/4284/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/1 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f2d2c48d8bcfccd8aba20d4b1e1f72b24ae9f0","subject":"remote_bitbang_sysfsgpio: fix reset handling"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only sequence of execuded commands is guaranteed but not\nthe timing. It works most of time with one exception: when JTAG_SLEEP\ncommand is executed, we expect that all previous commands already\nfinished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time have passed but\nprevious commands are not actually executed.\nThis patch adds flush command to the bitbang interface and its\nimplementation for remote_bitbang.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\n"}},"28bace976552e89760d6a9f40133feb8bc006de0":{"kind":"REWORK","_number":2,"created":"2023-12-12 19:50:39.000000000","uploader":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"ref":"refs/changes/84/4284/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/2 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1ae95f6f55168a15a7cf359c1d4c5f1d4b04c01","subject":"HACKING: fix how to retrieve hooks/commit-msg"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"David Ryskalczyk","email":"david.rysk@gmail.com","date":"2023-12-12 19:50:17.000000000","tz":-300},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only sequence of execuded commands is guaranteed but not\nthe timing. It works most of time with one exception: when JTAG_SLEEP\ncommand is executed, we expect that all previous commands already\nfinished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time have passed but\nprevious commands are not actually executed.\nThis patch adds flush command to the bitbang interface and its\nimplementation for remote_bitbang.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\nSigned-off-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\n"}},"93f08d33d11bea5c6b53ebe0d52d3d3c8362b2cc":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-12-12 19:53:06.000000000","uploader":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"ref":"refs/changes/84/4284/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/4284/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/3 \u0026\u0026 git checkout -b change-4284 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/4284/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/4284/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1ae95f6f55168a15a7cf359c1d4c5f1d4b04c01","subject":"HACKING: fix how to retrieve hooks/commit-msg"}],"author":{"name":"Aleksey Shargalin","email":"myokaski@gmail.com","date":"2017-10-31 14:23:40.000000000","tz":180},"committer":{"name":"David Ryskalczyk","email":"david.rysk@gmail.com","date":"2023-12-12 19:51:17.000000000","tz":-300},"subject":"bitbang: Add flush before sleep","message":"bitbang: Add flush before sleep\n\nSome bitbang interfaces have no speed regulation and work as fast as\nthey can. Only the sequence of execuded commands is guaranteed but\nnot the timing. It works most of time with one exception: when the\nJTAG_SLEEP command is executed, we expect that all previous commands\nalready finished so that the sleep interval is guaranteed.\nFor now  there may be situations when the sleep time has passed but\nprevious commands are not actually executed.\nThis patch adds a flush command to the bitbang interface, connects it\nto the existing implementation for remote_bitbang, and runs it when\nthe JTAG_SLEEP command is executed.\n\nChange-Id: If40894a63d29a260a4ded134b008df6dd1e89c46\nSigned-off-by: Aleksey Shargalin \u003cmyokaski@gmail.com\u003e\nSigned-off-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}