)]}'
{"src/jtag/drivers/xds110.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"98a64e3aab6d7a84389913652e96a47d14d36363","unresolved":true,"context_lines":[{"line_number":1907,"context_line":"\t\t}"},{"line_number":1908,"context_line":""},{"line_number":1909,"context_line":"\t\tfor (uint32_t i \u003d 0; i \u003c len; i++)"},{"line_number":1910,"context_line":"\t\t\txds110.serial[i] \u003d (char)serial[i];"},{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"\t\txds110.serial[len] \u003d 0;"},{"line_number":1913,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"a486f461_54fa2b2d","line":1910,"updated":"2021-10-08 13:38:21.000000000","message":"Hi Edward,\ndo you still remember \"why\" you have to run this conversion here?\nYou get char\u0027s from CMD_ARGV[0], run mbstowcs() then cherry-pick the least significant byte as a char.\nIn line 335 above you get an ascii string as char\u0027s with libusb_get_string_descriptor_ascii(..,desc.iSerialNumber,...) and runs a strcmp!\n\nI\u0027m working at centralizing the command \"serial\" and this code is an odd exception.","commit_id":"2ba27e2f3edd37e5dce4b2a231d2ae84c14cb59a"},{"author":{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"},"change_message_id":"a5a108bf3923bb1b1774c472da327b906cc4fb46","unresolved":true,"context_lines":[{"line_number":1907,"context_line":"\t\t}"},{"line_number":1908,"context_line":""},{"line_number":1909,"context_line":"\t\tfor (uint32_t i \u003d 0; i \u003c len; i++)"},{"line_number":1910,"context_line":"\t\t\txds110.serial[i] \u003d (char)serial[i];"},{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"\t\txds110.serial[len] \u003d 0;"},{"line_number":1913,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"29246903_7afc3669","line":1910,"in_reply_to":"a486f461_54fa2b2d","updated":"2021-10-08 14:08:44.000000000","message":"I’m not 100% sure now what I was thinking. But it likely had something to do with that internally, the XDS110 only saves the serial string as a char string, not wchar.  It expands the values to service the string descriptor request, but any character that has to be represented as a wchar with something in the upper byte will never match.  I was probably over-thinking this back then.  Now, I think I probably should have just skipped that conversion and let the comparison fail if the requestor provided a value with a non-single byte ascii character in it.","commit_id":"2ba27e2f3edd37e5dce4b2a231d2ae84c14cb59a"}]}