)]}'
{"id":"openocd~master~I17e3506553986ec2cf232b5bbd2a218c7bbd2dae","project":"openocd","branch":"master","hashtags":[],"change_id":"I17e3506553986ec2cf232b5bbd2a218c7bbd2dae","subject":"server: telnet: fix comparison between signed and unsigned warning","status":"ABANDONED","created":"2018-01-13 10:57:55.000000000","updated":"2018-01-13 15:16:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0514af060b0fe840e30f8f22f377b8f6e84efe67","_number":4330,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":1,"date":"2018-01-13 11:15:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"date":"2018-01-13 10:59:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-13 10:59:01.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2018-01-13 11:15:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"504d37a6fbb14a307c6999234200bfa0aaabb1f2","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-13 10:57:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1d786a24e8f6b45f22e01a82d40c944cca34c43","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-13 11:15:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9558/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8931/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"38da6e8aa423d3bdcc7ce6a464d7f87e28a6113d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-13 11:44:57.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9558/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8932/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0514af060b0fe840e30f8f22f377b8f6e84efe67","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-13 15:16:24.000000000","message":"Abandoned\n\nIn favour of http://openocd.zylin.com/#/c/3413/","accounts_in_message":[],"_revision_number":1}],"current_revision":"ea9e712bfb407841a28fcec7256afd5cbf5dc0f7","revisions":{"ea9e712bfb407841a28fcec7256afd5cbf5dc0f7":{"kind":"REWORK","_number":1,"created":"2018-01-13 10:57:55.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/30/4330/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/30/4330/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/30/4330/1 \u0026\u0026 git checkout -b change-4330 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/30/4330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/30/4330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/30/4330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/30/4330/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/30/4330/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"79cbeafe9f948217d388045882015bdd00df706c","subject":"Support listening on port 0."}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-13 10:54:53.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-13 10:54:53.000000000","tz":180},"subject":"server: telnet: fix comparison between signed and unsigned warning","message":"server: telnet: fix comparison between signed and unsigned warning\n\nExposed with clang 4.0.0.\n\nSince tc-\u003eline_cursor is a signed int (-1 is (ab)used to suppress prompt\nduring log output) and pos is unsigned as required by the semantics of\nthis function an explicit cast is needed to suppress the warning when\ncomparing the two.\n\nChange-Id: I17e3506553986ec2cf232b5bbd2a218c7bbd2dae\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}