)]}'
{"id":"openocd~master~Iea58cd3880d89e927d10113649d9a63f146f6368","project":"openocd","branch":"master","hashtags":[],"change_id":"Iea58cd3880d89e927d10113649d9a63f146f6368","subject":"tcl: interface: usb-jtag: clarify Xilinx cables support","status":"NEW","created":"2018-01-18 08:29:22.000000000","updated":"2018-01-30 09:22:07.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f9377a1a1c6cb06d32ac97a680ec19195e315cb9","_number":4353,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000979,"name":"Tim \"mithro\" Ansell","email":"me@mith.ro","username":"mithro"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},{"value":1,"date":"2018-01-18 08:46:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"rejected":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"value":0,"date":"2018-01-18 08:29:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000979,"name":"Tim \"mithro\" Ansell","email":"me@mith.ro","username":"mithro"},{"value":-2,"date":"2018-01-30 09:09:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"date":"2018-01-30 09:17:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000979,"name":"Tim \"mithro\" Ansell","email":"me@mith.ro","username":"mithro"},{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-18 08:29:51.000000000","updated_by":{"_account_id":1000979,"name":"Tim \"mithro\" Ansell","email":"me@mith.ro","username":"mithro"},"reviewer":{"_account_id":1000979,"name":"Tim \"mithro\" Ansell","email":"me@mith.ro","username":"mithro"},"state":"REVIEWER"},{"updated":"2018-01-18 08:46:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-30 09:17:25.000000000","updated_by":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"reviewer":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"state":"REVIEWER"}],"messages":[{"id":"b0cac8eea7357f8094e5b562443facbbd1550a61","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-18 08:29:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7aacedd095fa0112ac2e02504b488609626d1bd0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-01-18 08:46:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/9601/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/8973/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fc8f16dba2048fac5d1a844709357756630038de","author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"real_author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"date":"2018-01-30 06:34:11.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Paul,\n\nI\u0027ve tested that XPC USB II doesn\u0027t work with ixo-jtag firmware. Only the original older XPC USB (Version 1 you can say, generally named as Model DLC9LP, and whose clones are readily available). So, we should not specify \"II\" in the comments.","accounts_in_message":[],"_revision_number":1},{"id":"b558bdc10d9b3cd43d2f689955e8dd93ce1b3aa3","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-30 06:55:34.000000000","message":"Patch Set 1:\n\nOk, but how come Xilinx docs say all software that\u0027s compatible with the first cable will work with the second without changes?","accounts_in_message":[],"_revision_number":1},{"id":"ec8716dfed68cb94ce796383d9b7b03dbb0c768e","author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"real_author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"date":"2018-01-30 09:06:06.000000000","message":"Patch Set 1: -Code-Review\n\nUmm, I\u0027ve no idea why is that. Maybe ixo-jtag firmware issue? I just tested with the current latest firmware in the master branch of ixo-jtag repo.","accounts_in_message":[],"_revision_number":1},{"id":"fc41d56aed750ff0d08c5497b5a4d8ebcc30ab5a","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-30 09:09:08.000000000","message":"Patch Set 1:\n\nI hoped you have everything handy to open it and actually check... That interface seems to be quite common among FPGA developers so it would be nice to have it supported.","accounts_in_message":[],"_revision_number":1},{"id":"a4a443998fa800f069e75c5c088cfa5ace2f0846","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-30 09:09:32.000000000","message":"Patch Set 1: Code-Review-2\n\nBlocking the merger for now","accounts_in_message":[],"_revision_number":1},{"id":"250d89f14bac96fc405f6b0167ae4075d6b44b85","author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"real_author":{"_account_id":1001481,"name":"Rohit Singh","email":"rohit91.2008@gmail.com","username":"rohitk-singh"},"date":"2018-01-30 09:17:25.000000000","message":"Patch Set 1:\n\nHi Paul, Sure I\u0027ll try to sneak out the XPC USB II out from my company (I tested it today in my company itself. Will mail you the test results) and try to get it working with ixo-jtag :)","accounts_in_message":[],"_revision_number":1},{"id":"f9377a1a1c6cb06d32ac97a680ec19195e315cb9","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2018-01-30 09:22:07.000000000","message":"Patch Set 1:\n\nThank you very much in advance! :)","accounts_in_message":[],"_revision_number":1}],"current_revision":"5c328c075ea2634704aabab33fb9b1baf4300e0e","revisions":{"5c328c075ea2634704aabab33fb9b1baf4300e0e":{"kind":"REWORK","_number":1,"created":"2018-01-18 08:29:22.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/53/4353/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/4353/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/4353/1 \u0026\u0026 git checkout -b change-4353 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/4353/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/4353/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/4353/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/4353/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/4353/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"edb67962865d5d3cc4a8ec1790b4c8c5327e98fd","subject":"Fix Jim interpreter memory leak"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-18 08:28:50.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2018-01-18 08:28:50.000000000","tz":180},"subject":"tcl: interface: usb-jtag: clarify Xilinx cables support","message":"tcl: interface: usb-jtag: clarify Xilinx cables support\n\nChange-Id: Iea58cd3880d89e927d10113649d9a63f146f6368\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"REJECT","applied_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}