)]}'
{"id":"openocd~master~I01c430bfa593d20ea7a51c90d67052e374d239b3","project":"openocd","branch":"master","hashtags":[],"change_id":"I01c430bfa593d20ea7a51c90d67052e374d239b3","subject":"flash/nrf5: support for nRF52810","status":"MERGED","created":"2018-09-25 19:28:53.000000000","updated":"2018-10-08 18:07:05.000000000","submitted":"2018-10-08 18:07:05.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4680-1539022025446-3eaeb5a5","meta_rev_id":"c1a8057c5f8ef4d4370a5f6e08ac2bc0676bcce0","_number":4680,"owner":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":1,"date":"2018-10-08 18:07:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"value":1,"date":"2018-10-08 18:07:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},{"value":2,"date":"2018-10-08 18:07:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-09-25 21:06:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-09-26 04:45:27.000000000","updated_by":{"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},"reviewer":{"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},"state":"REVIEWER"},{"updated":"2018-10-08 18:07:05.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"fd8eafe201c5d09699ab5bf69c2399fcf6e1bf92","author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"real_author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"date":"2018-09-25 19:28:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"14d2284c2827783f08e0ca3a0eeacc9b4eddebdf","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2018-09-25 19:45:27.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThanks, looks good. Just nitpicking:","accounts_in_message":[],"_revision_number":1},{"id":"7e61574396aecd88edc18633648bdbd28a48ce5e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-09-25 19:48:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10593/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9949/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b561fc57aa1d0abe2bdc8bdab2cb4549927d0ffb","author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"real_author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"date":"2018-09-25 20:47:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1604dbd597f07914ad764071e142448edee0f95a","author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"real_author":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"date":"2018-09-25 20:49:14.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nNo problem, changed now..","accounts_in_message":[],"_revision_number":1},{"id":"9b7819f504997aea6952126a175ecfaefa0375fe","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-09-25 21:06:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10594/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/9950/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0ef8676c3b596158ec9971e74268b19cf4f85793","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2018-09-25 21:49:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"528eb5a872775cff57ef356861024d25baa67856","author":{"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},"real_author":{"_account_id":1001416,"name":"Slowcoder","email":"slowcoder@gmail.com","username":"jajac"},"date":"2018-09-26 04:45:27.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c1a8057c5f8ef4d4370a5f6e08ac2bc0676bcce0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2018-10-08 18:07:05.000000000","message":"Change has been successfully cherry-picked as 76ee93a81db72d16cc2e446f6f43411de5d6e8c2 by Tomas Vanek","accounts_in_message":[],"_revision_number":3}],"current_revision":"76ee93a81db72d16cc2e446f6f43411de5d6e8c2","revisions":{"76ee93a81db72d16cc2e446f6f43411de5d6e8c2":{"kind":"REWORK","_number":3,"created":"2018-10-08 18:07:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/80/4680/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/4680/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/3 \u0026\u0026 git checkout -b change-4680 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/4680/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1afec4f561392539197fae678de4cd2ca01c127d","subject":"tcl/board: Add Renesas R-Car Salvator-X(S) boards."}],"author":{"name":"Anders Westrup","email":"anders@westrup.se","date":"2018-09-25 19:18:53.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2018-10-08 18:07:05.000000000","tz":60},"subject":"flash/nrf5: support for nRF52810","message":"flash/nrf5: support for nRF52810\n\nChange-Id: I01c430bfa593d20ea7a51c90d67052e374d239b3\nSigned-off-by: Anders Westrup \u003canders@westrup.se\u003e\nReviewed-on: http://openocd.zylin.com/4680\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Slowcoder \u003cslowcoder@gmail.com\u003e\n"}},"857e4cb56e404eb9abae7a25966b394364671d35":{"kind":"REWORK","_number":2,"created":"2018-09-25 20:47:52.000000000","uploader":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"ref":"refs/changes/80/4680/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/4680/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/2 \u0026\u0026 git checkout -b change-4680 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/4680/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2d259f67cc3ee4b689e704228d97943bae94064","subject":"Added support for STM32L4X option bytes writing."}],"author":{"name":"Anders Westrup","email":"anders@westrup.se","date":"2018-09-25 19:18:53.000000000","tz":120},"committer":{"name":"Anders Westrup","email":"anders@westrup.se","date":"2018-09-25 20:47:44.000000000","tz":120},"subject":"flash/nrf5: support for nRF52810","message":"flash/nrf5: support for nRF52810\n\nChange-Id: I01c430bfa593d20ea7a51c90d67052e374d239b3\nSigned-off-by: Anders Westrup \u003canders@westrup.se\u003e\n"}},"38219c07593d55377be71159bb20308a8eb5708e":{"kind":"REWORK","_number":1,"created":"2018-09-25 19:28:53.000000000","uploader":{"_account_id":1001564,"name":"Anders Westrup","email":"anders@westrup.se","username":"a_westrup"},"ref":"refs/changes/80/4680/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/4680/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/1 \u0026\u0026 git checkout -b change-4680 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/4680/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/4680/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2d259f67cc3ee4b689e704228d97943bae94064","subject":"Added support for STM32L4X option bytes writing."}],"author":{"name":"Anders Westrup","email":"anders@westrup.se","date":"2018-09-25 19:18:53.000000000","tz":120},"committer":{"name":"Anders Westrup","email":"anders@westrup.se","date":"2018-09-25 19:26:44.000000000","tz":120},"subject":"flash/nrf5: support for nRF52810","message":"flash/nrf5: support for nRF52810\n\nChange-Id: I01c430bfa593d20ea7a51c90d67052e374d239b3\nSigned-off-by: Anders Westrup \u003canders@westrup.se\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}