)]}'
{"id":"openocd~master~I9245eef0936ea7eea28ae84ab5e8ce05fa63af40","project":"openocd","branch":"master","hashtags":[],"change_id":"I9245eef0936ea7eea28ae84ab5e8ce05fa63af40","subject":"icepick.cfg: add cancel reset bit to TAP register writes","status":"MERGED","created":"2018-12-06 00:00:41.000000000","updated":"2019-01-08 09:51:13.000000000","submitted":"2019-01-08 09:51:13.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4789-1546941073497-cffd1597","meta_rev_id":"f5062ee62f74f68aaff9ed4af624f6ed83107122","_number":4789,"owner":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2019-01-08 09:51:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"all":[{"value":2,"date":"2019-01-08 09:51:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-12-06 00:21:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-12-11 10:45:51.000000000","updated_by":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"reviewer":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"state":"REVIEWER"},{"updated":"2019-01-08 09:51:13.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"869d8478520acc4383e4b42aa16db85a58757c45","author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"real_author":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"date":"2018-12-06 00:00:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9eea27d07aff64b9bfead6d79cb2955b3b8de343","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2018-12-06 00:21:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://build.openocd.org/job/openocd-gerrit/10873/ : SUCCESS\n\nhttp://build.openocd.org/job/openocd-gerrit-build/10223/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"312791326e6195ff6bf6b371462cddcd3d8c5176","author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"real_author":{"_account_id":1000000,"name":"Spencer Oliver","email":"spen@spen-soft.co.uk","username":"ntfreak"},"date":"2018-12-11 10:45:51.000000000","message":"Patch Set 1: Code-Review+2\n\nunable to test.","accounts_in_message":[],"_revision_number":1},{"id":"f5062ee62f74f68aaff9ed4af624f6ed83107122","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2019-01-08 09:51:13.000000000","message":"Change has been successfully cherry-picked as 5fd1cb0e5b4ec60d34109febac25443a9394b8f1 by Tomas Vanek","accounts_in_message":[],"_revision_number":2}],"current_revision":"5fd1cb0e5b4ec60d34109febac25443a9394b8f1","revisions":{"4e1179dd927db44221ab04cabea772c8e954f79b":{"kind":"REWORK","_number":1,"created":"2018-12-06 00:00:41.000000000","uploader":{"_account_id":1001391,"name":"Edward Fewell","email":"edwardfewell@hotmail.com","username":"EdwardFewell"},"ref":"refs/changes/89/4789/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/4789/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/1 \u0026\u0026 git checkout -b change-4789 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/4789/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"63fcef493ab23e6f00a8e815c4f59688a088d285","subject":"flash/nor: use default_flash_blank_check() instead of dummy"}],"author":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2018-12-05 23:54:42.000000000","tz":-360},"committer":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2018-12-05 23:54:42.000000000","tz":-360},"subject":"icepick.cfg: add cancel reset bit to TAP register writes","message":"icepick.cfg: add cancel reset bit to TAP register writes\n\nThe Agama family of devices (CC26x2/CC13x2) required an\nadditional bit to be set when adding the core\u0027s TAP into\nthe scan chain. The cancel reset bit 0x10000 tells the\nICEPick to take the bus out of reset so that the other\nbits will take effect. This bit is a NOP on other devices\nand ICEPicks, so the change shouldn\u0027t adversely affect\nother devices.\n\nChange-Id: I9245eef0936ea7eea28ae84ab5e8ce05fa63af40\nSigned-off-by: Edward Fewell \u003cefewell@ti.com\u003e\n"}},"5fd1cb0e5b4ec60d34109febac25443a9394b8f1":{"kind":"REWORK","_number":2,"created":"2019-01-08 09:51:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/89/4789/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/4789/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/2 \u0026\u0026 git checkout -b change-4789 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/4789/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/4789/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"615a066629656aaa375c50885ef2f1530d1a5465","subject":"drivers: xds110: Add support for XDS110 stand-alone probe"}],"author":{"name":"Edward Fewell","email":"efewell@ti.com","date":"2018-12-05 23:54:42.000000000","tz":-360},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2019-01-08 09:51:13.000000000","tz":0},"subject":"icepick.cfg: add cancel reset bit to TAP register writes","message":"icepick.cfg: add cancel reset bit to TAP register writes\n\nThe Agama family of devices (CC26x2/CC13x2) required an\nadditional bit to be set when adding the core\u0027s TAP into\nthe scan chain. The cancel reset bit 0x10000 tells the\nICEPick to take the bus out of reset so that the other\nbits will take effect. This bit is a NOP on other devices\nand ICEPicks, so the change shouldn\u0027t adversely affect\nother devices.\n\nChange-Id: I9245eef0936ea7eea28ae84ab5e8ce05fa63af40\nSigned-off-by: Edward Fewell \u003cefewell@ti.com\u003e\nReviewed-on: http://openocd.zylin.com/4789\nTested-by: jenkins\nReviewed-by: Spencer Oliver \u003cspen@spen-soft.co.uk\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}